Re: [NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-15 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Mon, 15 Aug 2005 13:43:39 +0400 > On Mon, Aug 15, 2005 at 11:06:27AM +0200, Patrick McHardy ([EMAIL PROTECTED]) > wrote: > > Evgeniy Polyakov wrote: > > >it's not Dave's bug, all this changes force compiler to scream, which > > >thrusts forward. >

Re: [NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-15 Thread Evgeniy Polyakov
On Mon, Aug 15, 2005 at 11:06:27AM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >it's not Dave's bug, all this changes force compiler to scream, which > >thrusts forward. > > I don't get any compiler warnings with gcc-4.0.1 on x86 and amd64, > so could you please

Re: [NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-15 Thread Patrick McHardy
Evgeniy Polyakov wrote: it's not Dave's bug, all this changes force compiler to scream, which thrusts forward. I don't get any compiler warnings with gcc-4.0.1 on x86 and amd64, so could you please be more specific? - To unsubscribe from this list: send the line "unsubscribe netdev" in the b

Re: [NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-15 Thread Evgeniy Polyakov
On Mon, Aug 15, 2005 at 10:16:19AM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >>+ nlk->groups[0] = (nlk->groups[0] & ~0xUL) | > >>nladdr->nl_groups; netlink_table_ungrab(); > > > > > >I have some doubt about 64bit platforms. > > We want to replace the

Re: [NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-15 Thread Patrick McHardy
Evgeniy Polyakov wrote: + nlk->groups[0] = (nlk->groups[0] & ~0xUL) | nladdr->nl_groups; netlink_table_ungrab(); I have some doubt about 64bit platforms. We want to replace the lower 32 bit. What are the doubts you're haveing? return 0; @@ -590,7 +619,7 @@ static int netli

Re: [NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-15 Thread Evgeniy Polyakov
On Mon, Aug 15, 2005 at 09:45:22AM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: > David S. Miller wrote: > >I applied patches 1 -> 7, but I had to stop after that. > > > >This patch here will break netlink on my workstation :-) > > > >These "u32" tricks with nlk->groups[0] will not work on >

Re: [NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-15 Thread Patrick McHardy
David S. Miller wrote: I applied patches 1 -> 7, but I had to stop after that. This patch here will break netlink on my workstation :-) These "u32" tricks with nlk->groups[0] will not work on big-endian 64-bit. If unsigned long is 64-bit, you end up accessing bits 32-63 of nlk->groups[0] in so

Re: [NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-14 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 15 Aug 2005 02:33:30 +0200 > [NETLINK]: Support dynamic number of multicast groups per netlink family > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> I applied patches 1 -> 7, but I had to stop after that. This patch here will break ne

[NETLINK 8/10]: Support dynamic number of multicast groups per netlink family

2005-08-14 Thread Patrick McHardy
[NETLINK]: Support dynamic number of multicast groups per netlink family Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 68bcf4640f376652194969a64317e13c35371bfc tree a131b8cd33df58e4679f69b0a50852d4b8ba3120 parent 159b54716bcf5aea4c3141a64072613db7934e11 author Patrick McHardy <[E