Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-24 Thread Jamal Hadi Salim
On Sun, 2005-24-07 at 20:16 -0700, David S. Miller wrote: > From: Jamal Hadi Salim <[EMAIL PROTECTED]> > Date: Sun, 24 Jul 2005 23:11:22 -0400 > > > ->cb could be used or made to grow dynamically ? > > Yes, and back to the whole SKB extensions idea and how tricky > that is to get right and effici

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-24 Thread David S. Miller
From: Jamal Hadi Salim <[EMAIL PROTECTED]> Date: Sun, 24 Jul 2005 23:11:22 -0400 > ->cb could be used or made to grow dynamically ? Yes, and back to the whole SKB extensions idea and how tricky that is to get right and efficient at the same time. It is also a good time to remember what I said ab

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-24 Thread Jamal Hadi Salim
On Sun, 2005-24-07 at 19:07 -0700, David S. Miller wrote: > From: Thomas Graf <[EMAIL PROTECTED]> > Date: Mon, 25 Jul 2005 03:31:18 +0200 > > > Anyways, tc_verd needs a serious cleanup, not just for the > > macros which we might want to replace with bitfields or > > at least have generic macros to

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-24 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sat, 23 Jul 2005 07:03:08 +0200 > [NET]: Reduce tc_index/tc_verd to u16 > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev&qu

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-24 Thread Jamal Hadi Salim
On Mon, 2005-25-07 at 03:31 +0200, Thomas Graf wrote: > Anyways, tc_verd needs a serious cleanup, not just for the > macros which we might want to replace with bitfields or > at least have generic macros to generate the masks. Right - and as we discussed: -> recall that the use of bit operations

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-24 Thread David S. Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Mon, 25 Jul 2005 03:31:18 +0200 > Anyways, tc_verd needs a serious cleanup, not just for the > macros which we might want to replace with bitfields or > at least have generic macros to generate the masks. I'll > look into this once I'm back. I think tc_

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-24 Thread Thomas Graf
* Thomas Graf <[EMAIL PROTECTED]> 2005-07-23 18:23 > Hold on, I'm working on a patch to introduce TC_CB() so we can > move some of the fields of tc_verd into the control buffer so > I can do the cleanup at the same time. I tried but none of the bits can be moved into cb as-is except for TC_MUNGED

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-23 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-23 17:58 > Jamal Hadi Salim wrote: > >Did you check if there was no side effect with the macros that > >manipulate tc_verdict? > > Of course, these macros are basically the only user. They could use > some cleanup btw, I think I'll do that later. Hold

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-23 Thread Patrick McHardy
Jamal Hadi Salim wrote: Did you check if there was no side effect with the macros that manipulate tc_verdict? Of course, these macros are basically the only user. They could use some cleanup btw, I think I'll do that later. - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [NET]: Reduce tc_index/tc_verd to u16

2005-07-23 Thread Jamal Hadi Salim
Did you check if there was no side effect with the macros that manipulate tc_verdict? cheers, jamal On Sat, 2005-23-07 at 07:03 +0200, Patrick McHardy wrote: > plain text document attachment (x) > [NET]: Reduce tc_index/tc_verd to u16 > > Signed-off-by: Patrick McHardy <[

[NET]: Reduce tc_index/tc_verd to u16

2005-07-22 Thread Patrick McHardy
[NET]: Reduce tc_index/tc_verd to u16 Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 97d4e0b5dc8578e9839dae473c61c82760a15a29 tree 47f9c319d51825b4afba489bbf9edf50ae72ed5e parent 5bfc21c2a7b496ae6e4ca9efe9f69f9a14770ff5 author Patrick McHardy <[EMAIL PROTECTED]> Sat,