Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-05-24 Thread Jeff Garzik
Sergei Shtylyov wrote: Jeff Garzik wrote: This driver's 4-packet deep TX queue is too sensible to the "careless" callers ignoring its state (like netpoll in trapped mode), so add "queue full" check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-05-24 Thread Sergei Shtylyov
Jeff Garzik wrote: This driver's 4-packet deep TX queue is too sensible to the "careless" callers ignoring its state (like netpoll in trapped mode), so add "queue full" check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the queue will get stuck onc

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-05-24 Thread Jeff Garzik
Sergei Shtylyov wrote: Hello, I wrote: This driver's 4-packet deep TX queue is too sensible to the "careless" callers ignoring its state (like netpoll in trapped mode), so add "queue full" check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the queu

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-05-24 Thread Sergei Shtylyov
Hello, I wrote: This driver's 4-packet deep TX queue is too sensible to the "careless" callers ignoring its state (like netpoll in trapped mode), so add "queue full" check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the queue will get stuck once dirt

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-04-06 Thread Sergei Shtylyov
Hello. Amit S. Kale wrote: This driver's 4-packet deep TX queue is too sensible to the "careless" callers ignoring its state (like netpoll in trapped mode), so add "queue full" check at the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, otherwise the queue will get st

Re: [Kgdb-bugreport] [PATCH] 8139too: harden against TX ring overflow

2007-04-05 Thread Amit S. Kale
On Friday 06 April 2007 07:18, Herbert Xu wrote: > Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > > This driver's 4-packet deep TX queue is too sensible to the "careless" > > callers ignoring its state (like netpoll in trapped mode), so add "queue > > full" check at the start of the hard_start_xmit()