Re: [Intel-wired-lan] [net-next] igb: add function to set I210 transmit mode

2016-08-14 Thread John Fastabend
On 16-08-13 09:11 AM, Richard Cochran wrote: > On Sat, Aug 13, 2016 at 08:27:38AM -0700, Alexander Duyck wrote: >> I really don' think this patch is going to work. If you are going to >> implement something like this and have a hope to get it accepted into >> the Linux kernel you need to come up w

Re: [Intel-wired-lan] [net-next] igb: add function to set I210 transmit mode

2016-08-14 Thread John Fastabend
On 16-08-13 08:27 AM, Alexander Duyck wrote: > On Tue, Aug 9, 2016 at 11:48 PM, Gangfeng wrote: >> From: Gangfeng Huang >> >> I210 supports two transmit modes, legacy and Qav. The transmit mode is >> configured in TQAVCTRL.QavMode register. Before this patch igb driver >> only support legacy mode

Re: [Intel-wired-lan] [net-next] igb: add function to set I210 transmit mode

2016-08-13 Thread Richard Cochran
On Sat, Aug 13, 2016 at 08:27:38AM -0700, Alexander Duyck wrote: > I really don' think this patch is going to work. If you are going to > implement something like this and have a hope to get it accepted into > the Linux kernel you need to come up with a solution that will work > fore more than thi

Re: [Intel-wired-lan] [net-next] igb: add function to set I210 transmit mode

2016-08-13 Thread Alexander Duyck
On Tue, Aug 9, 2016 at 11:48 PM, Gangfeng wrote: > From: Gangfeng Huang > > I210 supports two transmit modes, legacy and Qav. The transmit mode is > configured in TQAVCTRL.QavMode register. Before this patch igb driver > only support legacy mode. This patch makes it possible to configure the > tr