Re: [Intel-wired-lan] [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-23 Thread Cong Wang
On Thu, Apr 23, 2015 at 12:45 PM, Alexander Duyck wrote: > On 04/23/2015 12:30 PM, Cong Wang wrote: >> >> (Off-topic...) >> >> On Wed, Apr 22, 2015 at 4:23 PM, Cong Wang wrote: >>> >>> The code looks correct to me now, except it is suspicious skb->len >>> is not updated after skb_copy_to_linear_d

Re: [Intel-wired-lan] [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-23 Thread Alexander Duyck
On 04/23/2015 12:30 PM, Cong Wang wrote: (Off-topic...) On Wed, Apr 22, 2015 at 4:23 PM, Cong Wang wrote: The code looks correct to me now, except it is suspicious skb->len is not updated after skb_copy_to_linear_data() while skb->tail is advanced already. I need to think more before submittin