Re: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-20 Thread Björn Töpel
On 2020-08-20 18:51, Maciej Fijalkowski wrote: On Thu, Aug 20, 2020 at 05:13:16PM +0200, Björn Töpel wrote: On Tue, 18 Aug 2020 at 16:04, Björn Töpel wrote: On Fri, 17 Jul 2020 at 08:24, Li RongQing wrote: This fixes ice/i40e/ixgbe/ixgbevf_rx_buffer_flip in copy mode xdp that can lead to d

Re: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-20 Thread Maciej Fijalkowski
On Thu, Aug 20, 2020 at 05:13:16PM +0200, Björn Töpel wrote: > On Tue, 18 Aug 2020 at 16:04, Björn Töpel wrote: > > > > On Fri, 17 Jul 2020 at 08:24, Li RongQing wrote: > > > > > > This fixes ice/i40e/ixgbe/ixgbevf_rx_buffer_flip in > > > copy mode xdp that can lead to data corruption. > > > > >

Re: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-20 Thread Björn Töpel
On Tue, 18 Aug 2020 at 16:04, Björn Töpel wrote: > > On Fri, 17 Jul 2020 at 08:24, Li RongQing wrote: > > > > This fixes ice/i40e/ixgbe/ixgbevf_rx_buffer_flip in > > copy mode xdp that can lead to data corruption. > > > > I split two patches, since i40e/xgbe/ixgbevf supports xsk > > receiving fro

Re: 答复: 答复: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-19 Thread Björn Töpel
On 2020-08-19 10:31, Björn Töpel wrote: [...] But please, try to reproduce with a newer kernel. Also, you are *sure* that you're touching stale data? Have you tried running with CONFIG_DEBUG_PAGEALLOC and CONFIG_PAGE_POISONING? Björn

Re: 答复: 答复: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-19 Thread Björn Töpel
] intel/xdp fixes for fliping rx buffer On 2020-08-19 03:37, Li,Rongqing wrote: [...] > Hi: > > Thanks for your explanation. > > But we can reproduce this bug > > We use ebpf to redirect only-Vxlan packets to non-zerocopy AF_XDP, First we see panic on tcp stack, in

答复: 答复: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-19 Thread Li,Rongqing
> -邮件原件- > 发件人: Björn Töpel [mailto:bjorn.to...@intel.com] > 发送时间: 2020年8月19日 14:45 > 收件人: Li,Rongqing ; Björn Töpel > > 抄送: Netdev ; intel-wired-lan > ; Karlsson, Magnus > ; bpf ; Maciej Fijalkowski > ; Piotr ; Maciej > > 主题: Re: 答复: [Intel-wired-lan

Re: 答复: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-19 Thread Björn Töpel
On 2020-08-19 03:37, Li,Rongqing wrote: [...] > Hi: > > Thanks for your explanation. > > But we can reproduce this bug > > We use ebpf to redirect only-Vxlan packets to non-zerocopy AF_XDP, First we see panic on tcp stack, in tcp_collapse: BUG_ON(offset < 0); it is very hard to reproduce. > > T

答复: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-18 Thread Li,Rongqing
> -邮件原件- > 发件人: Björn Töpel [mailto:bjorn.to...@gmail.com] > 发送时间: 2020年8月18日 22:05 > 收件人: Li,Rongqing > 抄送: Netdev ; intel-wired-lan > ; Karlsson, Magnus > ; Björn Töpel ; bpf > ; Maciej Fijalkowski ; > Piotr ; Maciej > 主题: Re: [Intel-wired-lan] [PATCH 0/

Re: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer

2020-08-18 Thread Björn Töpel
On Fri, 17 Jul 2020 at 08:24, Li RongQing wrote: > > This fixes ice/i40e/ixgbe/ixgbevf_rx_buffer_flip in > copy mode xdp that can lead to data corruption. > > I split two patches, since i40e/xgbe/ixgbevf supports xsk > receiving from 4.18, put their fixes in a patch > Li, sorry for the looong lat