Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-13 Thread Saeed Mahameed
On Wed, 2019-02-13 at 13:04 +0100, Ian Kumlien wrote: > One last update on this, 4.20.8 compiled with the same compiler works > - I still suspect that it was fixed by: > net/mlx5e: Force CHECKSUM_UNNECESSARY for short ethernet frames > > Anyway, we can forget about it now ;) cool, nice to know.

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-13 Thread Ian Kumlien
One last update on this, 4.20.8 compiled with the same compiler works - I still suspect that it was fixed by: net/mlx5e: Force CHECKSUM_UNNECESSARY for short ethernet frames Anyway, we can forget about it now ;) On Sat, Feb 9, 2019 at 4:54 PM Ian Kumlien wrote: > > On Fri, Feb 8, 2019 at 5:29 PM

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-09 Thread Ian Kumlien
On Fri, Feb 8, 2019 at 5:29 PM Ian Kumlien wrote > On Thu, Feb 7, 2019 at 11:01 PM Ian Kumlien wrote: > > On Thu, Feb 7, 2019 at 7:43 PM Saeed Mahameed > > wrote: > > > On Thu, Feb 7, 2019 at 2:17 AM Ian Kumlien wrote: > > > > On Thu, Feb 7, 2019 at 2:01 AM Saeed Mahameed > > > > wrote: > >

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-08 Thread Ian Kumlien
On Thu, Feb 7, 2019 at 11:01 PM Ian Kumlien wrote: > On Thu, Feb 7, 2019 at 7:43 PM Saeed Mahameed > wrote: > > On Thu, Feb 7, 2019 at 2:17 AM Ian Kumlien wrote: > > > On Thu, Feb 7, 2019 at 2:01 AM Saeed Mahameed > > > wrote: > > > > On Wed, Feb 6, 2019 at 3:00 PM Ian Kumlien > > > > wrote

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-07 Thread Ian Kumlien
On Thu, Feb 7, 2019 at 7:43 PM Saeed Mahameed wrote: > > On Thu, Feb 7, 2019 at 2:17 AM Ian Kumlien wrote: > > > > On Thu, Feb 7, 2019 at 2:01 AM Saeed Mahameed > > wrote: > > > On Wed, Feb 6, 2019 at 3:00 PM Ian Kumlien wrote: > > > > It changes directly after the first hw checksum failure, I

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-07 Thread Marcelo Ricardo Leitner
On Wed, Feb 06, 2019 at 11:41:28PM +0100, Ian Kumlien wrote: > On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking > > > things > > > > It doesn't break anything, packet

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-07 Thread Saeed Mahameed
On Thu, Feb 7, 2019 at 2:17 AM Ian Kumlien wrote: > > On Thu, Feb 7, 2019 at 2:01 AM Saeed Mahameed > wrote: > > On Wed, Feb 6, 2019 at 3:00 PM Ian Kumlien wrote: > > > It changes directly after the first hw checksum failure, I don't know why > > > =/ > > > > weird, Maybe a real check-summing

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-07 Thread Ian Kumlien
On Thu, Feb 7, 2019 at 2:01 AM Saeed Mahameed wrote: > On Wed, Feb 6, 2019 at 3:00 PM Ian Kumlien wrote: > > It changes directly after the first hw checksum failure, I don't know why =/ > > weird, Maybe a real check-summing issue/corruption on the PCI ?! Actually, it seems to have been introduce

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Saeed Mahameed
On Wed, Feb 6, 2019 at 3:00 PM Ian Kumlien wrote: > > On Wed, Feb 6, 2019 at 11:49 PM Cong Wang wrote: > > > > On Wed, Feb 6, 2019 at 2:41 PM Ian Kumlien wrote: > > > > > > On Wed, Feb 6, 2019 at 11:38 PM Cong Wang > > > wrote: > > > > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien > > > > wrote

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:49 PM Cong Wang wrote: > > On Wed, Feb 6, 2019 at 2:41 PM Ian Kumlien wrote: > > > > On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > > > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Cong Wang
On Wed, Feb 6, 2019 at 2:41 PM Ian Kumlien wrote: > > On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking > > > things > > > > It doesn't break anything, packets are _n

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things > > It doesn't break anything, packets are _not_ dropped, only that the > warning itself is noisy. Not my experien

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Cong Wang
On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things It doesn't break anything, packets are _not_ dropped, only that the warning itself is noisy.

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:22 PM David Miller wrote: > > From: Ian Kumlien > Date: Wed, 6 Feb 2019 23:12:53 +0100 > > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things > > Its... there: > > https://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread David Miller
From: Ian Kumlien Date: Wed, 6 Feb 2019 23:12:53 +0100 > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things Its... there: https://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=&archive=

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:03 PM David Miller wrote: > From: Saeed Mahameed > Date: Wed, 6 Feb 2019 17:18:55 + > > On Wed, 2019-02-06 at 17:16 +0100, Ian Kumlien wrote: > >> Hi, > >> > >> I'm hitting an issue that i think is fixed by the following patch, > >> i haven't verified it yet - but i

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread David Miller
From: Saeed Mahameed Date: Wed, 6 Feb 2019 17:18:55 + > On Wed, 2019-02-06 at 17:16 +0100, Ian Kumlien wrote: >> Hi, >> >> I'm hitting an issue that i think is fixed by the following patch, >> i haven't verified it yet - but it looks like it should go on the >> stable queue(?) >> >> (And ye

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Saeed Mahameed
On Wed, 2019-02-06 at 17:16 +0100, Ian Kumlien wrote: > Hi, > > I'm hitting an issue that i think is fixed by the following patch, > i haven't verified it yet - but it looks like it should go on the > stable queue(?) > > (And yes, I did look, and couldn't find it ;)) > Yes, i couldn't find it n

[ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
Hi, I'm hitting an issue that i think is fixed by the following patch, i haven't verified it yet - but it looks like it should go on the stable queue(?) (And yes, I did look, and couldn't find it ;)) commit e8c8b53ccaff568fef4c13a6ccaf08bf241aa01a Author: Cong Wang Date: Mon Dec 3 22:14:04 20