From: Brian Haley <[EMAIL PROTECTED]>
Date: Wed, 03 Oct 2007 10:44:17 -0400
> When the ICMPv6 Target address is multicast, Linux processes the
> redirect instead of dropping it. The problem is in this code in
> ndisc_redirect_rcv():
>
> if (ipv6_addr_equal(dest, target)) {
>
When the ICMPv6 Target address is multicast, Linux processes the
redirect instead of dropping it. The problem is in this code in
ndisc_redirect_rcv():
if (ipv6_addr_equal(dest, target)) {
on_link = 1;
} else if (!(ipv6_addr_type(target) & IPV6_ADDR_LINKLOCAL)) {
Brian,
I don't think a few instructions is a performance issue in the
redirect
paths (it'd be pretty broken if you're getting or generating lots of
them), but I
know there are lots of other checks similar to that that will break with
new
attributes, so doing that as a general clean-up se
Hi David,
David Stevens wrote:
ipv6_addr_type() returns a mask, so checking for equality will
fail to
match if any other (irrelevant) attributes are set. How about using
bitwise
operators for that?
ipv6_addr_type() does return a mask, but there's a lot of code that just
checks for
Brian,
ipv6_addr_type() returns a mask, so checking for equality will
fail to
match if any other (irrelevant) attributes are set. How about using
bitwise
operators for that? Also, the error message is no longer descriptive of
the
failure if it's a link-local multicast, but you could mak
When the ICMPv6 Target address is multicast, Linux processes the
redirect instead of dropping it. The problem is in this code in
ndisc_redirect_rcv():
if (ipv6_addr_equal(dest, target)) {
on_link = 1;
} else if (!(ipv6_addr_type(target) & IPV6_ADDR_LINKLOCAL)) {
Hi,
YOSHIFUJI Hideaki / 吉藤英明 wrote:
>>> I think it'd also be better if you add the check to be:
>>>
>>> if (ipv6_addr_type(target) &
>>> (IPV6_ADDR_LINKLOCAL|IPV6_ADDR_UNICAST))
>>>
>>> or something along those lines, rather than reproducing ipv6_addr_type()
>>> code
>>> separate
Hello.
In article <[EMAIL PROTECTED]> (at Sat, 29 Sep 2007 10:04:48 +0900 (JST)),
YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says:
> In article <[EMAIL PROTECTED]> (at Fri, 28 Sep 2007 17:50:38 -0700), David
> Stevens <[EMAIL PROTECTED]> says:
>
> > Brian,
> > A multicast address sho
Hi Yoshifuji,
YOSHIFUJI Hideaki / wrote:
Dave, Brian,
Let me double check this patch.
Regards,
--yoshfuji
In article <[EMAIL PROTECTED]> (at Fri, 28 Sep 2007 17:50:38 -0700), David Stevens
<[EMAIL PROTECTED]> says:
Brian,
A multicast address should never be the target of a ne
Dave, Brian,
Let me double check this patch.
Regards,
--yoshfuji
In article <[EMAIL PROTECTED]> (at Fri, 28 Sep 2007 17:50:38 -0700), David
Stevens <[EMAIL PROTECTED]> says:
> Brian,
> A multicast address should never be the target of a neighbor
> discovery request; the sender should
Brian,
A multicast address should never be the target of a neighbor
discovery request; the sender should use the mapping function for all
multicasts. So, I'm not sure that your example can ever happen, and it
certainly is ok to send ICMPv6 errors to multicast addresses in general.
But I don
When the ICMPv6 Target address is multicast, Linux processes the
redirect instead of dropping it. The problem is in this code in
ndisc_redirect_rcv():
if (ipv6_addr_equal(dest, target)) {
on_link = 1;
} else if (!(ipv6_addr_type(target) & IPV6_ADDR_LINKLOCAL)) {
12 matches
Mail list logo
