Re: Resend: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread jamal
On Tue, 2007-16-10 at 13:47 +0200, Laszlo Attila Toth wrote: > Hm, the main problem (for me) is that it requires more then one value > per net device and it should be limited. But if I say it is 5 for > instance, anyone can say it is not enough for him. Yes, those pesky humans, you give them an

Re: Resend: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread Laszlo Attila Toth
jamal írta: On Tue, 2007-16-10 at 13:05 +0200, Laszlo Attila Toth wrote: That sounds great but for what whould you like to use? It may help me for the implementation. For example i may want to add a tc rule to a group of interfaces. tc BNF roughly looks like: tc Where targe is := It may

Re: Resend: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread jamal
On Tue, 2007-16-10 at 13:05 +0200, Laszlo Attila Toth wrote: > That sounds great but for what whould you like to use? It may help me > for the implementation. For example i may want to add a tc rule to a group of interfaces. tc BNF roughly looks like: tc Where targe is := It may be useful t

Re: Resend: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread Laszlo Attila Toth
jamal írta: On Tue, 2007-16-10 at 11:03 +0200, Laszlo Attila Toth wrote: Interfaces can be grouped and each group has an unique positive integer ID. It can be set via ip link. Feature request: Can you also implement a get operation. Perhaps something that returns from the kernel a list of ifin

Re: Resend: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread jamal
On Tue, 2007-16-10 at 11:03 +0200, Laszlo Attila Toth wrote: > Interfaces can be grouped and each group has an unique positive integer ID. > It can be set via ip link. Feature request: Can you also implement a get operation. Perhaps something that returns from the kernel a list of ifindices when o

Re: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread Laszlo Attila Toth
Patrick McHardy írta: Laszlo Attila Toth wrote: diff --git a/man/man8/ip.8 b/man/man8/ip.8 index c74440a..8e6a9a3 100644 --- a/man/man8/ip.8 +++ b/man/man8/ip.8 @@ -511,6 +511,11 @@ already configured. @@ -1835,3 +1840,6 @@ was written by Alexey N. Kuznetsov and added in Linux 2.2. .SH AUTHO

Re: Resend: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread Patrick McHardy
Laszlo Attila Toth wrote: +static int set_group(const char *dev, int ifgroup) +{ + struct { + struct nlmsghdr n; + struct ifinfomsgifi; + charbuf[256]; + } req; + struct rtnl_handle rth; + +

Resend: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread Laszlo Attila Toth
Interfaces can be grouped and each group has an unique positive integer ID. It can be set via ip link. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/if_link.h |2 + include/rt_names.h |2 + ip/ipaddress.c |4 +++ ip/iplink.c | 49 +

Re: [IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread Patrick McHardy
Laszlo Attila Toth wrote: diff --git a/man/man8/ip.8 b/man/man8/ip.8 index c74440a..8e6a9a3 100644 --- a/man/man8/ip.8 +++ b/man/man8/ip.8 @@ -511,6 +511,11 @@ already configured. @@ -1835,3 +1840,6 @@ was written by Alexey N. Kuznetsov and added in Linux 2.2. .SH AUTHOR Original Manpage by

[IPROUTE2 PATCH] Interface group as new ip link option

2007-10-16 Thread Laszlo Attila Toth
Interfaces can be grouped and each group has an unique positive integer ID. It can be set via ip link. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED](none)> --- include/linux/if_link.h |2 + include/rt_names.h |2 + ip/ipaddress.c |4 +++ ip/iplink.c |