On Tue, Mar 28, 2006 at 01:13:11AM -0800, David S. Miller wrote:
>
> Ok, this seems reasonable, applied.
Thanks.
> BTW, can you sanity check your patches with something like:
>
> git apply --check --whitespace=error-all diff
>
> This patch here had a bunch of trailing whitespace I had
> t
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 27 Mar 2006 21:17:59 +1100
> Basically this patch moves the generic tunnel protocol stuff out of
> xfrm4_tunnel/xfrm6_tunnel and moves it into the new files of tunnel4.c
> and tunnel6 respectively.
Ok, this seems reasonable, applied.
BTW, can you s
On Mon, Mar 27, 2006 at 12:01:41PM +0100, Hugo Santos wrote:
>
>One small issue with the patch is tunnel6_rcv's return of 0 when no
> handler handles the packet which will increase IPSTATS_MIB_INDELIVERS.
> I guess -1 should be returned on error. I was checking ip_input and the
> expected b
Hi Herbert,
I have a couple of comments, please see below.
> The reason for this is that the problem that Hugo uncovered is only
> the tip of the iceberg. The real problem is that when we removed the
> dependency of ipip on xfrm4_tunnel we didn't really consider the module
> case at all.
>
>
Hi Dave:
I've finally finished this stuff.
Basically this patch moves the generic tunnel protocol stuff out of
xfrm4_tunnel/xfrm6_tunnel and moves it into the new files of tunnel4.c
and tunnel6 respectively.
The reason for this is that the problem that Hugo uncovered is only
the tip of the icebe
