Re: [Bug 6936] BUG: warning at net/core/dev.c:1171/skb_checksum_help()

2006-08-17 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 16 Aug 2006 11:29:00 +1000 > On Tue, Aug 15, 2006 at 11:29:59AM -0700, [EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=6936 > > It's actually a bug in the bridging code :) > > [BRIDGE]: Disable SG/GSO if TX checksum is off

Re: [Bug 6936] BUG: warning at net/core/dev.c:1171/skb_checksum_help()

2006-08-16 Thread Herbert Xu
On Wed, Aug 16, 2006 at 11:06:31AM -0700, Stephen Hemminger wrote: > > agree. I assume this came in with the new GSO for 2.6.18 or do we need > to fix 2.6.17 as well. I think 2.6.17 should be fine because it would only happen there if the underlying device itself had an inconsistent configuration

Re: [Bug 6936] BUG: warning at net/core/dev.c:1171/skb_checksum_help()

2006-08-16 Thread Stephen Hemminger
On Wed, 16 Aug 2006 11:29:00 +1000 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Tue, Aug 15, 2006 at 11:29:59AM -0700, [EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=6936 > > It's actually a bug in the bridging code :) > > [BRIDGE]: Disable SG/GSO if TX checksum is off >

Re: [Bug 6936] BUG: warning at net/core/dev.c:1171/skb_checksum_help()

2006-08-15 Thread Herbert Xu
On Tue, Aug 15, 2006 at 11:29:59AM -0700, [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=6936 It's actually a bug in the bridging code :) [BRIDGE]: Disable SG/GSO if TX checksum is off When the bridge recomputes features, it does not maintain the constraint that SG/GSO mus