Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-22 Thread Toshiaki Makita
On 2019/01/22 6:11, Zahari Doychev wrote: > On Fri, Jan 18, 2019 at 11:29:52AM +0900, Toshiaki Makita wrote: >> On 2019/01/18 4:19, Cong Wang wrote: >>> On Thu, Jan 17, 2019 at 12:59 AM Toshiaki Makita >>> wrote: On 2019/01/17 17:17, Zahari Doychev wrote: > On Tue, Jan 15, 2019 at 03:11:2

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-21 Thread Zahari Doychev
On Fri, Jan 18, 2019 at 11:29:52AM +0900, Toshiaki Makita wrote: > On 2019/01/18 4:19, Cong Wang wrote: > > On Thu, Jan 17, 2019 at 12:59 AM Toshiaki Makita > > wrote: > >> On 2019/01/17 17:17, Zahari Doychev wrote: > >>> On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: > On 2

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-17 Thread Toshiaki Makita
On 2019/01/18 4:19, Cong Wang wrote: > On Thu, Jan 17, 2019 at 12:59 AM Toshiaki Makita > wrote: >> On 2019/01/17 17:17, Zahari Doychev wrote: >>> On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: On 2019/01/13 22:59, Zahari Doychev wrote: > Use the skb->mac_len instead of

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-17 Thread Cong Wang
On Thu, Jan 17, 2019 at 12:59 AM Toshiaki Makita wrote: > > On 2019/01/17 17:17, Zahari Doychev wrote: > > On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: > >> On 2019/01/13 22:59, Zahari Doychev wrote: > >>> Use the skb->mac_len instead of using the ETH_HLEN when pushing the skb

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-17 Thread Toshiaki Makita
On 2019/01/17 17:17, Zahari Doychev wrote: > On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: >> On 2019/01/13 22:59, Zahari Doychev wrote: >>> Use the skb->mac_len instead of using the ETH_HLEN when pushing the skb >>> data pointer. This fixes sending incorrect packets when more th

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-16 Thread Zahari Doychev
On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: > On 2019/01/13 22:59, Zahari Doychev wrote: > > Use the skb->mac_len instead of using the ETH_HLEN when pushing the skb > > data pointer. This fixes sending incorrect packets when more than one > > vlan tags are pushed by tc-vlan and

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-14 Thread Toshiaki Makita
On 2019/01/13 22:59, Zahari Doychev wrote: > Use the skb->mac_len instead of using the ETH_HLEN when pushing the skb > data pointer. This fixes sending incorrect packets when more than one > vlan tags are pushed by tc-vlan and the mac header length is bigger than > ETH_HLEN. In this way the vlan ta