Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

2016-08-15 Thread Masami Hiramatsu
On Mon, 15 Aug 2016 23:44:05 +0200 Arend Van Spriel wrote: > > > On 15-8-2016 13:52, Rafał Miłecki wrote: > > On 15 August 2016 at 12:57, Kalle Valo wrote: > >> Rafał Miłecki writes: > >> > Signed-off-by: Masami Hiramatsu > >>> > >>> Fixes: a63b09872c1d ("brcmfmac: delete interface dire

Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

2016-08-15 Thread Arend Van Spriel
On 15-8-2016 13:52, Rafał Miłecki wrote: > On 15 August 2016 at 12:57, Kalle Valo wrote: >> Rafał Miłecki writes: >> Signed-off-by: Masami Hiramatsu >>> >>> Fixes: a63b09872c1d ("brcmfmac: delete interface directly in code that sent >>> fw request") >>> Acked-by: Rafał Miłecki >>> >>> K

Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

2016-08-15 Thread Rafał Miłecki
On 15 August 2016 at 12:57, Kalle Valo wrote: > Rafał Miłecki writes: > >>> Signed-off-by: Masami Hiramatsu >> >> Fixes: a63b09872c1d ("brcmfmac: delete interface directly in code that sent >> fw request") >> Acked-by: Rafał Miłecki >> >> Kalle: I'm acking this as bugfix for 4.8 release. > > O

Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

2016-08-15 Thread Kalle Valo
Rafał Miłecki writes: >> Signed-off-by: Masami Hiramatsu > > Fixes: a63b09872c1d ("brcmfmac: delete interface directly in code that sent > fw request") > Acked-by: Rafał Miłecki > > Kalle: I'm acking this as bugfix for 4.8 release. Ok. I'll wait few days for more comments before I apply this.

Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

2016-08-15 Thread Rafał Miłecki
On 08/15/2016 11:40 AM, Masami Hiramatsu wrote: Check rtnl_lock is locked in brcmf_p2p_ifp_removed() by passing rtnl_locked flag. Actually the caller brcmf_del_if() checks whether the rtnl_lock is locked, but doesn't pass it to brcmf_p2p_ifp_removed(). Without this fix, wpa_supplicant goes softl

[BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

2016-08-15 Thread Masami Hiramatsu
Check rtnl_lock is locked in brcmf_p2p_ifp_removed() by passing rtnl_locked flag. Actually the caller brcmf_del_if() checks whether the rtnl_lock is locked, but doesn't pass it to brcmf_p2p_ifp_removed(). Without this fix, wpa_supplicant goes softlockup with rtnl_lock holding (this means all other