Re: [Acx100-devel] [PATCH] acx: make firmware statistics parsing more intelligent

2006-02-08 Thread Andreas Mohr
Hi, On Sat, Feb 04, 2006 at 01:31:16PM +0200, Denis Vlasenko wrote: > On Friday 03 February 2006 12:58, Andreas Mohr wrote: > > - use "% 8" modulo instead of more complicated "% 5" calculation > > Why? There will be HZ=100 and HZ=250 boxes, 8ms doesn't fit well. > 10ms is ok, 5ms or 2.5ms is more

Re: [Acx100-devel] [PATCH] acx: make firmware statistics parsing more intelligent

2006-02-04 Thread Denis Vlasenko
On Friday 03 February 2006 12:58, Andreas Mohr wrote: > this patch does: > - implement much more flexible firmware statistics parsing > (for /proc/driver/acx_wlanX_diag) > This has the nice effect that we now get output for both the older > TNETW1100 USB and TNETW1450. > Since firmware stat

Re: [Acx100-devel] [PATCH] acx: make firmware statistics parsing more intelligent

2006-02-03 Thread Andreas Mohr
Hi, On Fri, Feb 03, 2006 at 03:28:29PM +0200, Denis Vlasenko wrote: > On Friday 03 February 2006 14:39, Denis Vlasenko wrote: > > Well, gcc obviously failed to realize that "% 16" == "& 15". > > I'll file a bug. > > -ENOTABUG. It's incorrect for signed integers, > and gcc uses idiv insn instead.

Re: [Acx100-devel] [PATCH] acx: make firmware statistics parsing more intelligent

2006-02-03 Thread Denis Vlasenko
On Friday 03 February 2006 14:39, Denis Vlasenko wrote: > Well, gcc obviously failed to realize that "% 16" == "& 15". > I'll file a bug. -ENOTABUG. It's incorrect for signed integers, and gcc uses idiv insn instead. -- vda - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [Acx100-devel] [PATCH] acx: make firmware statistics parsing more intelligent

2006-02-03 Thread Denis Vlasenko
On Friday 03 February 2006 12:58, Andreas Mohr wrote: > -   adev->tx_head = (head + 1) % TX_CNT; > +   /* slower: adev->tx_head = (head + 1) % TX_CNT; */ > +   adev->tx_head = head + 1; > +   if (adev->tx_head >= TX_CNT) > +   adev->tx_head = 0; struct a { int tx_h