Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-26 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Wed, 24 Oct 2007 13:43:14 -0700 > So, I stand corrected, and sorry about the histrionics. Since > these are arguably ICMP errors, and since errors is the only > thing being MIB-counted in DCCP and SCTP, then it now looks > ok to me as-is, and also ok t

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread Vlad Yasevich
David Stevens wrote: > My bad -- I see what it's doing, and it looks ok after all. > > I thought I saw an INMSGS (but didn't). These are ICMP errors that > went through icmp_rcv() and were counted correctly before getting > to the protocol error handlers. These are failures due mostly to not > ha

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread Vlad Yasevich
David Stevens wrote: > My bad -- I see what it's doing, and it looks ok after all. > jinx, crossed in flight. ;) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread Vlad Yasevich
David Stevens wrote: > I took a look at the DCCP references, and I think they're just > incrementing the wrong MIB variable -- e.g., it's incrementing > ICMP_MIB_INERRORS when the skb length is less than the > header indicates. That's not an ICMP_MIB_INERRORS error, > that's an IPSTATS_MIB_INHDRERR

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread David Stevens
My bad -- I see what it's doing, and it looks ok after all. I thought I saw an INMSGS (but didn't). These are ICMP errors that went through icmp_rcv() and were counted correctly before getting to the protocol error handlers. These are failures due mostly to not having enough, or the right protoco

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread Vlad Yasevich
David Stevens wrote: > I took a look at the DCCP references, and I think they're just > incrementing the wrong MIB variable -- e.g., it's incrementing > ICMP_MIB_INERRORS when the skb length is less than the > header indicates. That's not an ICMP_MIB_INERRORS error, > that's an IPSTATS_MIB_INHDRERR

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread David Stevens
I took a look at the DCCP references, and I think they're just incrementing the wrong MIB variable -- e.g., it's incrementing ICMP_MIB_INERRORS when the skb length is less than the header indicates. That's not an ICMP_MIB_INERRORS error, that's an IPSTATS_MIB_INHDRERRORS error. ICMP_MIB_INERRORS is

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread David Stevens
[EMAIL PROTECTED] wrote on 10/24/2007 12:14:37 PM: > On Wed, Oct 24, 2007 at 12:07:45PM -0700, David Stevens wrote: > > [EMAIL PROTECTED] wrote on 10/24/2007 09:24:10 AM: > > > > > This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics). > > > > > > Signed-off-by: Adrian Bunk <[EMAIL PRO

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread Adrian Bunk
On Wed, Oct 24, 2007 at 12:07:45PM -0700, David Stevens wrote: > [EMAIL PROTECTED] wrote on 10/24/2007 09:24:10 AM: > > > This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics). > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- > > 4ce74657ac0b1bdcb4c7bc359d05643f8cc4a0

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread David Stevens
[EMAIL PROTECTED] wrote on 10/24/2007 09:24:10 AM: > This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics). > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > 4ce74657ac0b1bdcb4c7bc359d05643f8cc4a08b > diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c > index 272c69e..233de06 1

[2.6 patch] unexport icmpmsg_statistics

2007-10-24 Thread Adrian Bunk
This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 4ce74657ac0b1bdcb4c7bc359d05643f8cc4a08b diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 272c69e..233de06 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -1104,5 +1104,4