Re: [2.6 patch] do not select NET_CLS

2005-11-23 Thread Sam Ravnborg
On Wed, Nov 23, 2005 at 06:13:32PM -0800, Randy.Dunlap wrote: > > So -q means "quick" ? >From make help: -q, --question Run no commands; exit status says if up to date > I wouldn't mind seeing a -quiet (even less quiet than V=0), > not even printing the CC, AS, LD, etc. commands -- just let the >

Re: [2.6 patch] do not select NET_CLS

2005-11-23 Thread Randy.Dunlap
On Wed, 23 Nov 2005 06:57:35 +0100 Sam Ravnborg wrote: > On Tue, Nov 22, 2005 at 03:00:41PM -0800, David S. Miller wrote: > > From: Sam Ravnborg <[EMAIL PROTECTED]> > > Date: Tue, 22 Nov 2005 23:49:14 +0100 > > > > > On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: > > > > > > >

Re: [2.6 patch] do not select NET_CLS

2005-11-23 Thread Thomas Graf
* David S. Miller <[EMAIL PROTECTED]> 2005-11-22 14:37 > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Mon, 21 Nov 2005 17:16:18 +0100 > > > Adrian Bunk wrote: > > > This patch therefore changes NET_CLS back to the 2.6.14 status quo of > > > being an user-visible option. > > > > I disagree w

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread Sam Ravnborg
On Tue, Nov 22, 2005 at 03:00:41PM -0800, David S. Miller wrote: > From: Sam Ravnborg <[EMAIL PROTECTED]> > Date: Tue, 22 Nov 2005 23:49:14 +0100 > > > On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: > > > > > > One thing we can do to prevent human > > > mistakes, is to make the

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread Adrian Bunk
On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: >... > Changing config options of any kind can result in the main kernel > image needing to be rebuilt. One thing we can do to prevent human > mistakes, is to make the "make modules" pass do a quick "is vmlinux > uptodate?" check, an

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread David S. Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Tue, 22 Nov 2005 23:49:14 +0100 > On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: > > > > One thing we can do to prevent human > > mistakes, is to make the "make modules" pass do a quick "is vmlinux > > uptodate?" check, and if not pri

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread Sam Ravnborg
On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: > > One thing we can do to prevent human > mistakes, is to make the "make modules" pass do a quick "is vmlinux > uptodate?" check, and if not print out an error message explaining the > situation and aborting the "make modules" attem

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 21 Nov 2005 17:16:18 +0100 > Adrian Bunk wrote: > > This patch therefore changes NET_CLS back to the 2.6.14 status quo of > > being an user-visible option. > > I disagree with this patch. NET_CLS enables the infrastructure support > for classi

Re: [2.6 patch] do not select NET_CLS

2005-11-21 Thread Patrick McHardy
Adrian Bunk wrote: 2.6.15-rc changes NET_CLS to being automatically select'ed when needed. This patch confuses users since NET_CLS is a bool, and compiling an additional module that select's NET_CLS causes unresolved symbols since it's not user-visible that adding a module changes the kernel i

[2.6 patch] do not select NET_CLS

2005-11-21 Thread Adrian Bunk
>... > But there's a change in 2.6.15-rc1 that makes this issue much worse: > It is no longer user-visible. > > tristate's select'ing bool's that do not change parts of the (modular) > driver but compile additional code into the kernel are simply wrong. The patch below (should apply against 2.6.