Re: [2.6 patch] always export sysctl_{r,w}mem_max

2007-11-06 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Fri, 26 Oct 2007 18:04:22 -0600 > So if this is really something we want to stop doing we should > be able to take a few extra moments remove the code from the > two problem drivers, and remove the exports. I've killed the references in dlm and rr

Re: [2.6 patch] always export sysctl_{r,w}mem_max

2007-10-26 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > From: Rick Jones <[EMAIL PROTECTED]> > Date: Fri, 26 Oct 2007 16:31:47 -0700 > >> Eric W. Biederman wrote: >> > Adrian Bunk <[EMAIL PROTECTED]> writes: >> > >> > >> >>This patch fixes the following build error with CONFIG_SYSCTL=n: >> >> >> >><-- snip

Re: [2.6 patch] always export sysctl_{r,w}mem_max

2007-10-26 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 16:46:36 -0700 > David Miller wrote: > > If DLM really wants minimum, it can use SO_SNDBUFFORCE and > > SO_RCVBUFFORCE socket options and use whatever limits it > > likes. > > > > But even this is questionable. > > Drift... > > Is that

Re: [2.6 patch] always export sysctl_{r,w}mem_max

2007-10-26 Thread Rick Jones
David Miller wrote: If DLM really wants minimum, it can use SO_SNDBUFFORCE and SO_RCVBUFFORCE socket options and use whatever limits it likes. But even this is questionable. Drift... Is that something netperf should be using though? Right now it uses the regular SO_[SND|RCV]BUF calls and is

Re: [2.6 patch] always export sysctl_{r,w}mem_max

2007-10-26 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 16:31:47 -0700 > Eric W. Biederman wrote: > > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > > > >>This patch fixes the following build error with CONFIG_SYSCTL=n: > >> > >><-- snip --> > >> > >>... > >>ERROR: "sysctl_rmem_max" [fs/dlm

Re: [2.6 patch] always export sysctl_{r,w}mem_max

2007-10-26 Thread Rick Jones
Eric W. Biederman wrote: Adrian Bunk <[EMAIL PROTECTED]> writes: This patch fixes the following build error with CONFIG_SYSCTL=n: <-- snip --> ... ERROR: "sysctl_rmem_max" [fs/dlm/dlm.ko] undefined! ERROR: "sysctl_wmem_max" [drivers/net/rrunner.ko] undefined! ERROR: "sysctl_rmem_max" [driv

Re: [2.6 patch] always export sysctl_{r,w}mem_max

2007-10-26 Thread Eric W. Biederman
Adrian Bunk <[EMAIL PROTECTED]> writes: > This patch fixes the following build error with CONFIG_SYSCTL=n: > > <-- snip --> > > ... > ERROR: "sysctl_rmem_max" [fs/dlm/dlm.ko] undefined! > ERROR: "sysctl_wmem_max" [drivers/net/rrunner.ko] undefined! > ERROR: "sysctl_rmem_max" [drivers/net/rrunner

[2.6 patch] always export sysctl_{r,w}mem_max

2007-10-26 Thread Adrian Bunk
This patch fixes the following build error with CONFIG_SYSCTL=n: <-- snip --> ... ERROR: "sysctl_rmem_max" [fs/dlm/dlm.ko] undefined! ERROR: "sysctl_wmem_max" [drivers/net/rrunner.ko] undefined! ERROR: "sysctl_rmem_max" [drivers/net/rrunner.ko] undefined! make[2]: *** [__modpost] Error 1 <--