Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-28 Thread Paul Rolland
Hello Jesse, > spddplx += (mii_reg & 0x100) > -? FULL_DUPLEX : > -HALF_DUPLEX; > +? DUPLEX_FULL : > +

Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-27 Thread Jesse Brandeburg
From: Paul Rolland <[EMAIL PROTECTED]> Hello, This patch is based on Linux 2.4.32, and I've verified the same problem exists on 2.6.15.4. Working on a machine with a 2.4.32 kernel, I was surprised to see the driver complaining when setting the speed to 100FD using mii-tool, but accepting the s

Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-27 Thread Jesse Brandeburg
On 2/26/06, Paul Rolland <[EMAIL PROTECTED]> wrote: > Hello, > > > Ok, great, I was just wondering since I would have made one if you had > > no plans to do so. > > Well, I was just waiting to make sure it was interesting for someone ;) > > Here is it, verified with tab and not spaces... but attach

Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-26 Thread Paul Rolland
Hello, > Ok, great, I was just wondering since I would have made one if you had > no plans to do so. Well, I was just waiting to make sure it was interesting for someone ;) Here is it, verified with tab and not spaces... but attached as my mailer is likely to cripple anything I try to inline...

Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-26 Thread Jesper Juhl
On 2/26/06, Paul Rolland <[EMAIL PROTECTED]> wrote: > Hello, > > > are you planning a 2.6 patch as well ? > > > I'm preparing it, and I'll be carefull with Tab/space ;) > Ok, great, I was just wondering since I would have made one if you had no plans to do so. -- Jesper Juhl <[EMAIL PROTECTED]> Do

Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-26 Thread Paul Rolland
Hello, > are you planning a 2.6 patch as well ? > I'm preparing it, and I'll be carefull with Tab/space ;) Paul - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-26 Thread Jesper Juhl
On 2/25/06, Paul Rolland <[EMAIL PROTECTED]> wrote: > Hello, > > This patch is based on Linux 2.4.32, and I've verified the same problem > exists on 2.6.15.4. are you planning a 2.6 patch as well ? -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.

Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-26 Thread Paul Rolland
> it's mangled, tabs have been turned into whitespaces. I fixed > it so please > use the appended one. Sorry about that, thanks for the fix. Paul - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger

Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-26 Thread Willy TARREAU
Hello Paul, On Sat, Feb 25, 2006 at 11:08:49AM +0100, Paul Rolland wrote: > Hello, > > This patch is based on Linux 2.4.32, and I've verified the same problem > exists on 2.6.15.4. it's mangled, tabs have been turned into whitespaces. I fixed it so please use the appended one. > Working on a ma

[2.4.32 - 2.6.15.4] e1000 - Fix mii interface

2006-02-25 Thread Paul Rolland
Hello, This patch is based on Linux 2.4.32, and I've verified the same problem exists on 2.6.15.4. Working on a machine with a 2.4.32 kernel, I was surprised to see the driver complaining when setting the speed to 100FD using mii-tool, but accepting the setting with ethtool. Digging into the code,