Re: [2/3] [NET] ppp: Remove unnecessary pskb_may_pull

2006-06-09 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 9 Jun 2006 17:43:44 +1000 > [NET] ppp: Remove unnecessary pskb_may_pull Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

[2/3] [NET] ppp: Remove unnecessary pskb_may_pull

2006-06-09 Thread Herbert Xu
Hi: [NET] ppp: Remove unnecessary pskb_may_pull In ppp_receive_nonmp_frame, we call pskb_may_pull(skb, skb->len) if the tailroom is >= 124. This is pointless because this pskb_may_pull is only needed if the skb is non-linear. However, if it is non-linear then the tailroom would be zero. So it