Re: [2/2] [IPV6]: Consolidate common SNMP code

2007-04-24 Thread Herbert Xu
On Tue, Apr 24, 2007 at 10:12:39PM -0700, David Miller wrote: > > This breaks the build with IPV6 modular: > > LD .tmp_vmlinux1 > net/built-in.o: In function `snmp6_seq_show': > proc.c:(.text+0x68244): undefined reference to `ipv6_statistics' Sorry, got carried away with testing with /pro

Re: [2/2] [IPV6]: Consolidate common SNMP code

2007-04-24 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 24 Apr 2007 22:12:39 -0700 (PDT) > This breaks the build with IPV6 modular: > > LD .tmp_vmlinux1 > net/built-in.o: In function `snmp6_seq_show': > proc.c:(.text+0x68244): undefined reference to `ipv6_statistics' > proc.c:(.text+0x68250): un

Re: [2/2] [IPV6]: Consolidate common SNMP code

2007-04-24 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 24 Apr 2007 21:54:29 -0700 (PDT) > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Wed, 25 Apr 2007 13:21:03 +0900 (JST) > > > In article <[EMAIL PROTECTED]> (at Wed, 25 Apr 2007 14:06:37 +1000), > > Herbert Xu <[EMAIL PROTECTED]> says

Re: [2/2] [IPV6]: Consolidate common SNMP code

2007-04-24 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 25 Apr 2007 13:21:03 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Wed, 25 Apr 2007 14:06:37 +1000), Herbert > Xu <[EMAIL PROTECTED]> says: > > > Hi: > > > > [IPV6]: Consolidate common SNMP code > > > > This patch moves the non-p

Re: [2/2] [IPV6]: Consolidate common SNMP code

2007-04-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 25 Apr 2007 14:06:37 +1000), Herbert Xu <[EMAIL PROTECTED]> says: > Hi: > > [IPV6]: Consolidate common SNMP code > > This patch moves the non-proc SNMP code into addrconf.c and reuses > IPv4 SNMP code where applicable. : > Signed-off-by: Herbert Xu <[EMAI

[2/2] [IPV6]: Consolidate common SNMP code

2007-04-24 Thread Herbert Xu
Hi: [IPV6]: Consolidate common SNMP code This patch moves the non-proc SNMP code into addrconf.c and reuses IPv4 SNMP code where applicable. As a result we can skip proc.o if /proc is disabled. Note that I've made a number of functions static since they're only used by addrconf.c for now. If t