On Tue, Jul 04, 2006 at 12:45:27PM +1000, herbert wrote:
>
> That's what I meant. I meant ethtool helper functions that
> clear and set both TSO/TSO6 flags at the same time.
I think I was a bit ambiguous here. To expand on my argument, what
I'm saying is that we can't just change the existing e
On Mon, Jul 03, 2006 at 07:44:06PM -0700, David Miller wrote:
>
> > I think we need some new ethtool helper functions that sets/clears both
> > TSO/TSO6.
>
> Do you really want to semantically seperate TSO and TSO6?
>
> I would think that real users who want to disable TSO, wish
> to do so unilat
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Sat, 1 Jul 2006 13:39:39 +1000
> On Fri, Jun 30, 2006 at 07:44:49PM -0400, Ananda Raju wrote:
> >
> > I tested the patch, and TSO over ipv6 is working fine. But TSO disable
> > not working for IPv6.
> >
> > I tried the from tree /pub/scm/linux/kernel/g
On Fri, Jun 30, 2006 at 07:44:49PM -0400, Ananda Raju wrote:
>
> I tested the patch, and TSO over ipv6 is working fine. But TSO disable
> not working for IPv6.
>
> I tried the from tree /pub/scm/linux/kernel/git/davem/net-2.6
I think we need some new ethtool helper functions that sets/clears bo
Sure, we will do that.
-Original Message-
From: Michael Chan [mailto:[EMAIL PROTECTED]
Sent: Friday, June 30, 2006 5:08 PM
To: Ananda Raju
Cc: David Miller; [EMAIL PROTECTED]; netdev@vger.kernel.org
Subject: RE: [1/4] [IPV6]: Remove redundant length check on input
On Fri, 2006-06-30 at
On Fri, 2006-06-30 at 19:55 -0400, Ananda Raju wrote:
> True, I am referring to "ethtool -K ethX tso off"
> ethtool_op_set_tso() won't clear NETIF_F_TSO6 for ethtool -K ethX tso
> off
>
Instead of using ethtool_op_set_tso() in your ethtool_ops structure, you
can use a private function to set or cl
EMAIL PROTECTED]; netdev@vger.kernel.org
Subject: RE: [1/4] [IPV6]: Remove redundant length check on input
On Fri, 2006-06-30 at 19:44 -0400, Ananda Raju wrote:
> Hi,
>
> I tested the patch, and TSO over ipv6 is working fine. But TSO disable
> not working for IPv6.
>
You need to clear
On Fri, 2006-06-30 at 19:44 -0400, Ananda Raju wrote:
> Hi,
>
> I tested the patch, and TSO over ipv6 is working fine. But TSO disable
> not working for IPv6.
>
You need to clear NETIF_F_TSO6 in dev->features to disable ipv6 TSO.
-
To unsubscribe from this list: send the line "unsubscribe netd
PROTECTED]
Cc: Ananda Raju; netdev@vger.kernel.org
Subject: Re: [1/4] [IPV6]: Remove redundant length check on input
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Fri, 30 Jun 2006 15:42:09 +1000
> I've added GSO for TCPv6 and updated Ananda's patch. Please note that
> the following
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Fri, 30 Jun 2006 15:42:09 +1000
> I've added GSO for TCPv6 and updated Ananda's patch. Please note that
> the following patches have only been compile-tested.
I applied this and pushed it to Linus, let's cross our fingers :)
-
To unsubscribe from this l
In article <[EMAIL PROTECTED]> (at Fri, 30 Jun 2006 15:42:09 +1000), Herbert Xu
<[EMAIL PROTECTED]> says:
> [IPV6]: Remove redundant length check on input
>
> We don't need to check skb->len when we're just about to call
> pskb_may_pull since that checks it for us.
>
> Signed-off-by: Herbert Xu
Hi Dave:
I've added GSO for TCPv6 and updated Ananda's patch. Please note that
the following patches have only been compile-tested.
[IPV6]: Remove redundant length check on input
We don't need to check skb->len when we're just about to call
pskb_may_pull since that checks it for us.
Signed-off
12 matches
Mail list logo
