Re: [RFC PATCH v3 03/13] af_vsock: implement SEQPACKET rx loop

2021-01-25 Thread stsp
25.01.2021 14:12, Arseny Krasnov пишет: This adds receive loop for SEQPACKET. It looks like receive loop for SEQPACKET,     ^^^ You meant "STREAM"?

Re: [RFC PATCH v2 00/13] virtio/vsock: introduce SOCK_SEQPACKET support.

2021-01-15 Thread stsp
15.01.2021 08:35, Arseny Krasnov пишет: This patchset impelements support of SOCK_SEQPACKET for virtio transport. As SOCK_SEQPACKET guarantees to save record boundaries, so to do it, new packet operation was added: it marks start of record (with record length in header), such pack

Re: [PATCH 4/5] af_vsock: add socket ops for SOCK_SEQPACKET.

2021-01-03 Thread stsp
03.01.2021 23:04, Arseny Krasnov пишет: From: Arseniy Krasnov --- net/vmw_vsock/af_vsock.c | 107 +-- 1 file changed, 91 insertions(+), 16 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 7ff00449a9a2..30caad9815f7 10064

Re: [PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.

2021-01-03 Thread stsp
03.01.2021 22:57, Arseny Krasnov пишет: This extends rx loop for SOCK_SEQPACKET packets and implements callback which user calls to copy data to its buffer. Signed-off-by: Arseny Krasnov --- include/linux/virtio_vsock.h| 7 + include/net/af_vsock.h |

Re: [PATCH 0/5] virtio/vsock: introduce SOCK_SEQPACKET support.

2021-01-03 Thread stsp
Hi Arseny, thanks for your work on this! I did a small review in a hope it helps. Also it may be cool to have the driver feature for that (so that the host can see if its supported). But I guess this was already said by Michael. :) 03.01.2021 22:54, Arseny Krasnov пишет: As SOCK_SEQPACK

Re: [PATCH 3/5] af_vsock: send/receive loops for SOCK_SEQPACKET.

2021-01-03 Thread stsp
Hi Arseny! 03.01.2021 23:03, Arseny Krasnov пишет: From: Arseniy Krasnov For send, this patch adds: 1) Send of record begin marker with record length. 2) Return error if send of whole record is failed. For receive, this patch adds another loop, it looks like stream loop, but: