Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-20 Thread rosenp
Sorry for the noise. After more testing I've found out that the cause was that I had BBR enabled on my laptop. Switching back to CUBIC fixed the issue. In other words, this patch is detrimental. ~67mbps - gro off ~87mbps - gro on On Fri, 2017-09-15 at 23:04 -0700, Florian Fainelli wrote: > On Se

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread rosenp
I have not. Unfortunately I own no gigabit hardware to test this on. The MIPS CPU runs at 300MHz on my unit. On Fri, 2017-09-15 at 17:34 -0700, Eric Dumazet wrote: > On Fri, 2017-09-15 at 17:23 -0700, Rosen Penev wrote: > > On a linksys E1200v1 (actually a crossflashed E1000v2), the > > offloading

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread rosenp
netif_receive_skb seems to have the same effect as "ethtool -K eth0 gro off". On Fri, 2017-09-15 at 17:18 -0700, Eric Dumazet wrote: > On Fri, 2017-09-15 at 17:10 -0700, ros...@gmail.com wrote: > > Ok fair enough. Will only disable GRO in the driver. > > Well, do not even try. > > NETIF_F_SOFT_F

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread rosenp
Ok fair enough. Will only disable GRO in the driver. Tests were done using "ethtool -K eth0 gro off" and on. On Fri, 2017-09-15 at 17:03 -0700, Eric Dumazet wrote: > On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote: > > On September 15, 2017 3:22:18 PM PDT, Rosen Penev > > > > wrote: >

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread rosenp
you're absolutely correct. will send an updated version shortly. On Fri, 2017-09-15 at 16:14 -0700, David Miller wrote: > From: Rosen Penev > Date: Fri, 15 Sep 2017 15:22:18 -0700 > > > On a linksys E1200v1 (actually a crossflashed E1000v2), the > offloading features give no measurable benefit t