Re: [PATCH net-next v2 2/2] net: ethernet: mediatek: support custom GMAC label

2021-04-20 Thread Rob Herring
icker for the device connector for a human to id. I can't really tell if that's the case here. I don't see how 'gmacX' vs. 'ethX' maps to DSA master vs. slave. I don't think this should be handled within a specific driver either. If we're going to have a way to name things, then fix it in alloc_etherdev(). It can also be argued that device naming for userspace is a userspace (udev) problem. Rob

Re: [PATCH v5 net-next 10/10] dt-bindings: net: korina: Add DT bindings for IDT 79RC3243x SoCs

2021-04-16 Thread Rob Herring
t; > > + - reg > > > + - reg-names > > > + - interrupts > > > + - interrupt-names > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + > > > +ethernet@6 { &g

Re: [PATCH v5 net-next 10/10] dt-bindings: net: korina: Add DT bindings for IDT 79RC3243x SoCs

2021-04-16 Thread Rob Herring
On Fri, Apr 16, 2021 at 10:52:06AM +0200, Thomas Bogendoerfer wrote: > Add device tree bindings for ethernet controller integrated into > IDT 79RC3243x SoCs. > > Signed-off-by: Thomas Bogendoerfer > --- > .../bindings/net/idt,3243x-emac.yaml | 74 +++ > 1 file changed, 7

Re: [PATCH net-next v4 2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices

2021-04-16 Thread Rob Herring
gt;dev.of_node); drivers/net/ethernet/xilinx/xilinx_emaclite.c: mac_address = of_get_mac_address(ofdev->dev.of_node); drivers/net/wireless/ralink/rt2x00/rt2x00dev.c: mac_addr = of_get_mac_address(rt2x00dev->dev->of_node); drivers/staging/octeon/ethernet.c: mac = of_get_mac_address(priv->of_node); drivers/staging/wfx/main.c: macaddr = of_get_mac_address(wdev->dev->of_node); net/ethernet/eth.c: addr = of_get_mac_address(dev->of_node); Then this will find most of the rest: git grep -W 'of_get_mac_address([a-z]*)'| grep -E '(node|np)' Rob

Re: [PATCH net-next 1/3] dt-bindings: net: add nvmem-mac-address-offset property

2021-04-15 Thread Rob Herring
address stored. Thus we need to have a way to provide an offset per > > network device. > > We need to see what Rob thinks of this. There was recently a patchset > to support swapping the byte order of the MAC address in a NVMEM. Rob > said the NVMEM provider should have the pr

Re: [PATCH v2 1/2] dt-bindings: net: can: Document transceiver implementation as phy

2021-04-15 Thread Rob Herring
vicetree/bindings/net/can/bosch,m_can.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring

Re: [PATCH v2 0/2] brcmfmac: support parse country code map from DT

2021-04-15 Thread Rob Herring
Improve commit log with Arend's explanation on why this data could >be put in device tree. > - Use pattern to define mapping string as suggested by Rob. > - Use brcmf_err() instead of dev_warn() and print error code. > - Use sscanf() to validate mapping string. > - Use brcm

Re: [PATCH v2 1/2] dt-bindings: bcm4329-fmac: add optional brcm,ccode-map

2021-04-15 Thread Rob Herring
On Thu, 15 Apr 2021 18:47:27 +0800, Shawn Guo wrote: > Add optional brcm,ccode-map property to support translation from ISO3166 > country code to brcmfmac firmware country code and revision. > > The country revision is needed because the RF parameters that provide > regulatory compliance are tweak

Re: [PATCH v2 net-next 5/5] dt-bindings: net: dsa: Document dsa,tag-protocol property

2021-04-15 Thread Rob Herring
On Thu, Apr 15, 2021 at 11:26:10AM +0200, Tobias Waldekranz wrote: > The 'dsa,tag-protocol' is used to force a switch tree to use a > particular tag protocol, typically because the Ethernet controller > that it is connected to is not compatible with the default one. > > Signed-off-by: Tobias Walde

XFRM programming with VRF enslaved interfaces

2021-04-15 Thread Rob Dover
uld have obviously changed the behaviour I'm seeing (feel free to correct me if I've missed something!). Thanks for your help, Rob Dover

Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy

2021-04-14 Thread Rob Herring
On Wed, Apr 14, 2021 at 1:49 AM Aswath Govindraju wrote: > > Hi Rob, > > On 12/04/21 11:21 pm, Rob Herring wrote: > > On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote: > >> From: Faiz Abbas > >> > >> Some transceivers need a

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-13 Thread Rob Herring
On Tue, Apr 13, 2021 at 2:41 AM Marc Kleine-Budde wrote: > > On 12.04.2021 12:49:56, Rob Herring wrote: > > On Mon, Apr 12, 2021 at 12:19:30PM +0200, Marc Kleine-Budde wrote: > > > On 4/9/21 3:40 PM, Aswath Govindraju wrote: > > > > Add binding documentation

Re: [PATCH net-next 1/4] dt-bindings: net: qcom,ipa: add some compatible strings

2021-04-12 Thread Rob Herring
On Fri, Apr 09, 2021 at 03:40:21PM -0500, Alex Elder wrote: > Add existing supported platform "qcom,sc7180-ipa" to the set of IPA > compatible strings. Also add newly-supported "qcom,sdx55-ipa", > "qcom,sc7280-ipa". > > Signed-off-by: Alex Elder > --- > Documentation/devicetree/bindings/net/qco

Re: [RFC PATCH 2/3] dt-bindings: net: xilinx_axienet: Introduce dmaengine binding support

2021-04-12 Thread Rob Herring
On Fri, Apr 09, 2021 at 11:43:21PM +0530, Radhey Shyam Pandey wrote: > The axiethernet driver will now use dmaengine framework to communicate > with dma controller IP instead of built-in dma programming sequence. > > To request dma transmit and receive channels the axiethernet driver uses > generi

Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy

2021-04-12 Thread Rob Herring
On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote: > From: Faiz Abbas > > Some transceivers need a configuration step (for example, pulling the > standby or enable lines) for them to start sending messages. The > transceiver can be implemented as a phy with the configuration done

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-12 Thread Rob Herring
On Mon, Apr 12, 2021 at 12:19:30PM +0200, Marc Kleine-Budde wrote: > On 4/9/21 3:40 PM, Aswath Govindraju wrote: > > Add binding documentation for TI TCAN104x CAN transceivers. > > > > Signed-off-by: Aswath Govindraju > > --- > > .../bindings/phy/ti,tcan104x-can.yaml | 56 +++

Re: [RFC PATCH 1/3] dt-bindings: net: xilinx_axienet: convert bindings document to yaml

2021-04-12 Thread Rob Herring
On Fri, 09 Apr 2021 23:43:20 +0530, Radhey Shyam Pandey wrote: > Convert the bindings document for Xilinx AXI Ethernet Subsystem > from txt to yaml. No changes to existing binding description. > > Signed-off-by: Radhey Shyam Pandey > --- > Pending: Fix below remaining dt_binding_check warning: >

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-09 Thread Rob Herring
On Thu, Apr 08, 2021 at 07:30:21PM +0800, Shawn Guo wrote: > Add optional brcm,ccode-map property to support translation from ISO3166 > country code to brcmfmac firmware country code and revision. > > Signed-off-by: Shawn Guo > --- > .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 7

Re: [PATCH net-next 1/3] dt-bindings: net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Rob Herring
nvmem-cell-names: > const: mac-address > > + nvmem_macaddr_swap: > +$ref: /schemas/types.yaml#/definitions/flag > +description: > + swap bytes order for the 6 bytes of MAC address So 'nvmem-mac-address' needs to be swapped or it's swapped before writing? In any case, this belongs in the nvmem provider. Rob

Re: [PATCH 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-06 Thread Rob Herring
On Mon, Apr 5, 2021 at 11:47 AM Michael Walle wrote: > > of_get_mac_address() already supports fetching the MAC address by an > nvmem provider. But until now, it was just working for platform devices. > Esp. it was not working for DSA ports and PCI devices. It gets more > common that PCI devices h

Re: [PATCH net-next 3/3] dt-bindings: net: dsa: Document dsa,tag-protocol property

2021-03-27 Thread Rob Herring
On Fri, Mar 26, 2021 at 11:56:48AM +0100, Tobias Waldekranz wrote: > The 'dsa,tag-protocol' is used to force a switch tree to use a > particular tag protocol, typically because the Ethernet controller > that it is connected to is not compatible with the default one. > > Signed-off-by: Tobias Walde

Re: [PATCHv1 1/6] dt-bindings: net: ethernet-phy: Fix the parsing of ethernet-phy compatible string

2021-03-25 Thread Rob Herring
"ethernet-phy-ieee802.3-c45" > > Cc: Rob Herring > Signed-off-by: Anand Moon > --- > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_bindin

Re: [PATCH net-next v3 v3 1/2] dt-bindings: net: xilinx_axienet: Document additional clocks

2021-03-25 Thread Rob Herring
On Wed, Mar 24, 2021 at 11:19 AM Robert Hancock wrote: > > On Wed, 2021-03-24 at 11:08 -0600, Rob Herring wrote: > > On Fri, Mar 12, 2021 at 01:52:13PM -0600, Robert Hancock wrote: > > > Update DT bindings to describe all of the clocks that the axienet > > > driver w

Re: [PATCH net-next 1/2] dt-bindings: ethernet-controller: create a type for PHY interface modes

2021-03-24 Thread Rob Herring
otherwise we would need to define the same list at > two different places). > > Moreover Rob Herring says that we cannot reuse the values of a property; > we need to $ref a type. > > Move the definition of possible PHY interface modes from the > `phy-connection-type` property t

Re: [PATCH net-next v3 v3 1/2] dt-bindings: net: xilinx_axienet: Document additional clocks

2021-03-24 Thread Rob Herring
On Fri, Mar 12, 2021 at 01:52:13PM -0600, Robert Hancock wrote: > Update DT bindings to describe all of the clocks that the axienet > driver will now be able to make use of. > > Signed-off-by: Robert Hancock > --- > .../bindings/net/xilinx_axienet.txt | 25 ++- > 1 file

Re: [PATCH 1/5] dt-bindings: soc: qcom: wcnss: Add firmware-name property

2021-03-24 Thread Rob Herring
d-off-by: Bjorn Andersson > --- > Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.txt | 7 +++ > 1 file changed, 7 insertions(+) > Acked-by: Rob Herring

Re: [PATCH v2 00/10] Rid W=1 warnings from OF

2021-03-24 Thread Rob Herring
On Tue, Mar 23, 2021 at 2:36 AM Lee Jones wrote: > > On Mon, 22 Mar 2021, Rob Herring wrote: > > > On Thu, Mar 18, 2021 at 4:40 AM Lee Jones wrote: > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which

Re: [PATCH v5 02/24] dt-bindings: introduce silabs,wfx.yaml

2021-03-23 Thread Rob Herring
changed, 133 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml > Reviewed-by: Rob Herring

Re: [PATCH v2 00/10] Rid W=1 warnings from OF

2021-03-22 Thread Rob Herring
'prop' not described in 'of_remove_property' ../drivers/of/base.c:1855: warning: Excess function parameter 'prob' description in 'of_remove_property' BTW, there some more which I guess W=1 doesn't find: /home/rob/proj/git/linux-dt/Documentation/driver-api/dev

Re: [PATCH 1/2] dt-bindings: dp83867: Add binding for LED mode configuration

2021-03-19 Thread Rob Herring
On Fri, 19 Mar 2021 16:57:09 +0100, Michael Tretter wrote: > The DP83867 supports four configurable LED pins. Describe the > multiplexing of functions to the LEDs via device tree. > > Signed-off-by: Michael Tretter > --- > .../devicetree/bindings/net/ti,dp83867.yaml | 24 +++ >

[PATCH] dt-bindings: Drop type references on common properties

2021-03-16 Thread Rob Herring
t.org Cc: linux-...@vger.kernel.org Signed-off-by: Rob Herring --- .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 5 + Documentation/devicetree/bindings/arm/cpus.yaml | 2 -- .../bindings/display/allwinner,sun4i-a10-tcon.yaml | 1 - .../devicetree/bindings

Re: [PATCH v1 7/7] dt-bindings: net: qcom-ipa: Document qcom,msm8998-ipa compatible

2021-03-05 Thread Rob Herring
On Thu, Feb 11, 2021 at 06:50:15PM +0100, AngeloGioacchino Del Regno wrote: > MSM8998 support has been added: document the new compatible. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [PATCH v1 6/7] dt-bindings: net: qcom-ipa: Document qcom,sc7180-ipa compatible

2021-03-05 Thread Rob Herring
On Thu, Feb 11, 2021 at 06:50:14PM +0100, AngeloGioacchino Del Regno wrote: > The driver supports SC7180, but the binding was not documented. > Just add it. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +- > 1 file changed,

Re: [Freedreno] [PATCH 16/17] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-04 Thread Rob Clark
On Thu, Mar 4, 2021 at 7:48 AM Robin Murphy wrote: > > On 2021-03-01 08:42, Christoph Hellwig wrote: > > Signed-off-by: Christoph Hellwig > > Moreso than the previous patch, where the feature is at least relatively > generic (note that there's a bunch of in-flight development around > DOMAIN_ATTR

[PATCH v2 2/2] driver core: platform: Drop of_device_node_put() wrapper

2021-02-11 Thread Rob Herring
cki" Cc: Frank Rowand Signed-off-by: Rob Herring --- v2: - Fix build --- drivers/base/platform.c | 2 +- include/linux/of_device.h | 7 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 95fd1549f87d..9d5171e5f967 10064

[PATCH v2 1/2] of: Remove of_dev_{get,put}()

2021-02-11 Thread Rob Herring
rg Cc: linux-arm-ker...@lists.infradead.org Cc: linux-...@vger.kernel.org Cc: co...@systeme.lip6.fr Signed-off-by: Rob Herring --- v2: - Fix build --- arch/powerpc/platforms/pseries/ibmebus.c | 4 ++-- drivers/net/ethernet/ibm/emac/core.c | 15 --- drivers/of/device.c

[PATCH v2 0/2] of: of_device.h cleanups

2021-02-11 Thread Rob Herring
This is a couple of cleanups for of_device.h. They fell out from my attempt at decoupling of_device.h and of_platform.h which is a mess and I haven't finished, but there's no reason to wait on these. Rob Rob Herring (2): of: Remove of_dev_{get,put}() driver core: plat

[PATCH 2/2] driver core: platform: Drop of_device_node_put() wrapper

2021-02-11 Thread Rob Herring
cki" Cc: Frank Rowand Signed-off-by: Rob Herring --- drivers/base/platform.c | 2 +- include/linux/of_device.h | 7 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 95fd1549f87d..c31bc9e92dd1 100644 --- a/drivers/b

[PATCH 1/2] of: Remove of_dev_{get,put}()

2021-02-11 Thread Rob Herring
rg Cc: linux-arm-ker...@lists.infradead.org Cc: linux-...@vger.kernel.org Cc: co...@systeme.lip6.fr Signed-off-by: Rob Herring --- arch/powerpc/platforms/pseries/ibmebus.c | 4 ++-- drivers/net/ethernet/ibm/emac/core.c | 15 --- drivers/of/device.c | 21 - d

[PATCH 0/2] of: of_device.h cleanups

2021-02-11 Thread Rob Herring
This is a couple of cleanups for of_device.h. They fell out from my attempt at decoupling of_device.h and of_platform.h which is a mess and I haven't finished, but there's no reason to wait on these. Rob Rob Herring (2): of: Remove of_dev_{get,put}() driver core: plat

Re: [PATCH v2 net-next 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x

2021-02-10 Thread Rob Herring
On Wed, Feb 10, 2021 at 01:55:21PM +0100, Robert Marko wrote: > Add DT bindings for Qualcomm QCA807x PHYs. > > Signed-off-by: Robert Marko > Cc: Luka Perkov > --- > Changes in v2: > * Drop LED properties > * Directly define PSGMII/QSGMII SerDes driver values > > .../devicetree/bindings/net/qco

Re: [PATCH v12 net-next 01/15] doc: marvell: add CM3 address space and PPv2.3 description

2021-02-10 Thread Rob Herring
txt | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Acked-by: Rob Herring

Re: [PATCH 02/16] dt-bindings: net: Add Baikal-T1 GMAC bindings

2021-02-09 Thread Rob Herring
ed to have a > better understanding of what the interface looks like. > > Signed-off-by: Serge Semin > > --- > > Rob, please note I couldn't declare the axi-config object properties > constraints > without specifying the properties type and description. If I remove

Re: [PATCH 01/16] dt-bindings: net: dwmac: Add DW GMAC GPIOs properties

2021-02-09 Thread Rob Herring
tal number of GPIOs the MAC supports. The property shall include both > + the GPI and GPO ports width. > +minimum: 1 > +maximum: 32 Does the driver actually need this? I'd omit it if just to validate consumers are in range. Are GPI and GPO counts independent? If so, this isn't really sufficient. Rob

Re: [PATCH] dt-bindings: can: rcar_canfd: Group tuples in pin control properties

2021-02-09 Thread Rob Herring
On Thu, 04 Feb 2021 13:59:37 +0100, Geert Uytterhoeven wrote: > To improve human readability and enable automatic validation, the tuples > in "pinctrl-*" properties should be grouped using angle brackets. > > Signed-off-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/net/can/rca

Re: [PATCH v2 07/24] dt-bindings: net: dwmac: Detach Generic DW MAC bindings

2021-02-09 Thread Rob Herring
> +# two strings: one with IP-core name plus the IP version, another as just > +# the IP-core name. > +select: > + properties: > +compatible: > + oneOf: > +- items: > +- pattern: "^snps,dw(xg)+mac(-[0-9]+\\.[0-9]+a?)?$" Use ''

Re: [PATCH V2 net-next 1/2] dt-bindings: net: document BCM4908 Ethernet controller

2021-02-09 Thread Rob Herring
On Sun, Feb 07, 2021 at 11:26:31PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > BCM4908 is a family of SoCs with integrated Ethernet controller. > > Signed-off-by: Rafał Miłecki > --- > .../bindings/net/brcm,bcm4908enet.yaml| 45 +++ > 1 file changed, 45 insert

Re: [PATCH v2 04/24] dt-bindings: net: dwmac: Refactor snps,*-config properties

2021-02-09 Thread Rob Herring
: > +- snps,route-avcp > +- required: > +- snps,route-ptp > +- required: > +- snps,route-dcbcp > + - required: > +- snps,route-up > +- required: > +- snps,route-multi-broad This 'not: ..." could be: properties: snps,route-avcp: false snps,route-ptp: false snps,route-dcbcp: false snps,route-up: false snps,route-multi-broad: false Not sure which one is better. Using required everywhere or more concise... (Really, 'route' should have taken a value and the schema would be greatly simplified. Oh well.) > + > +additionalProperties: false > + > +# Choose one of the RX scheduling algorithms > +not: > + required: > +- snps,rx-sched-sp > +- snps,rx-sched-wsp I guess this is the problematic one. The rest should be hidden behind conditionals (a common loophole in meta-schema checks). You could do that here: allOf: - not: ... But why not just make one of the 2 properties required? You're already changing things. Rob

Re: [PATCH v2 03/24] dt-bindings: net: dwmac: Fix the TSO property declaration

2021-02-09 Thread Rob Herring
" > property isn't parsed by the Allwinner SunX GMAC glue driver, but only > by the generic platform DT-parser. > > Changelog v2: > - Use correct syntax of the JSON pointers, so the later would begin > with a '/' after the '#'. > --- > .../dev

Re: [PATCH RESEND] dt-bindings: ethernet-controller: fix fixed-link specification

2021-02-09 Thread Rob Herring
On Mon, 01 Feb 2021 10:02:20 +, Russell King wrote: > The original fixed-link.txt allowed a pause property for fixed link. > This has been missed in the conversion to yaml format. > > Fixes: 9d3de3c58347 ("dt-bindings: net: Add YAML schemas for the generic > Ethernet options") > Signed-off-by

Re: [PATCH net-next 1/8] dt-bindings: net: dsa: dt bindings for microchip lan937x

2021-02-09 Thread Rob Herring
On Thu, Jan 28, 2021 at 12:11:05PM +0530, Prasanna Vengateshan wrote: > Documentation in .yaml format and updates to the MAINTAINERS > Also 'make dt_binding_check' is passed > > Signed-off-by: Prasanna Vengateshan > --- > .../bindings/net/dsa/microchip,lan937x.yaml | 115 ++ >

Re: [PATCH net-next v2 1/2] dt-bindings: net: dsa: add MT7530 GPIO controller binding

2021-01-25 Thread Rob Herring
On Mon, 25 Jan 2021 12:43:21 +0800, DENG Qingfang wrote: > Add device tree binding to support MT7530 GPIO controller. > > Signed-off-by: DENG Qingfang > --- > Changes v1 -> v2: > No changes. > > Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 ++ > 1 file changed, 6 insertion

Re: [PATCH net-next 1/2] dt: ar803x: document SmartEEE properties

2021-01-15 Thread Rob Herring
y: Russell King > --- > .../devicetree/bindings/net/qca,ar803x.yaml | 16 > 1 file changed, 16 insertions(+) > Reviewed-by: Rob Herring

Re: [RFC PATCH v3 1/8] dt-bindings: net: sparx5: Add sparx5-switch bindings

2021-01-15 Thread Rob Herring
On Fri, Jan 15, 2021 at 02:53:32PM +0100, Steen Hegelund wrote: > Document the Sparx5 switch device driver bindings > > Signed-off-by: Steen Hegelund > Signed-off-by: Lars Povlsen > --- > .../bindings/net/microchip,sparx5-switch.yaml | 211 ++ > 1 file changed, 211 insertions(+)

Re: [RFC PATCH v3 1/8] dt-bindings: net: sparx5: Add sparx5-switch bindings

2021-01-15 Thread Rob Herring
On Fri, 15 Jan 2021 14:53:32 +0100, Steen Hegelund wrote: > Document the Sparx5 switch device driver bindings > > Signed-off-by: Steen Hegelund > Signed-off-by: Lars Povlsen > --- > .../bindings/net/microchip,sparx5-switch.yaml | 211 ++ > 1 file changed, 211 insertions(+) > cr

Re: [PATCH net-next 1/2] dt-bindings: net: dsa: add MT7530 GPIO controller binding

2021-01-14 Thread Rob Herring
On Mon, 11 Jan 2021 13:44:27 +0800, DENG Qingfang wrote: > Add device tree binding to support MT7530 GPIO controller. > > Signed-off-by: DENG Qingfang > --- > Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 ++ > 1 file changed, 6 insertions(+) > Acked-by: Rob Herring

Re: [PATCH net-next 2/4] dt-bindings: net: remove modem-remoteproc property

2021-01-12 Thread Rob Herring
On Tue, Jan 12, 2021 at 01:28:29PM -0600, Alex Elder wrote: > The IPA driver uses the remoteproc SSR notifier now, rather than the > temporary IPA notification system used initially. As a result it no > longer needs a property identifying the modem subsystem DT node. > > Use GIC_SPI rather than 0

Re: [PATCH net-next 2/4] dt-bindings: net: remove modem-remoteproc property

2021-01-12 Thread Rob Herring
On Tue, 12 Jan 2021 13:28:29 -0600, Alex Elder wrote: > The IPA driver uses the remoteproc SSR notifier now, rather than the > temporary IPA notification system used initially. As a result it no > longer needs a property identifying the modem subsystem DT node. > > Use GIC_SPI rather than 0 in th

Re: [PATCH 1/2] dt-bindings: net: bluetooth: Add rtl8723ds-bluetooth

2021-01-11 Thread Rob Herring
tions(-) > Acked-by: Rob Herring

Re: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks

2021-01-11 Thread Rob Herring
e changed, 10 insertions(+), 1 deletion(-) > Acked-by: Rob Herring

Re: [PATCH 1/5] dt-bindings: net: renesas,etheravb: Add r8a779a0 support

2021-01-07 Thread Rob Herring
umentation/devicetree/bindings/net/renesas,etheravb.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: [PATCH v5 10/11] dt-bindings: usb: convert mediatek, mtu3.txt to YAML schema

2021-01-07 Thread Rob Herring
On Fri, 25 Dec 2020 15:52:57 +0800, Chunfeng Yun wrote: > Convert mediatek,mtu3.txt to YAML schema mediatek,mtu3.yaml > > Signed-off-by: Chunfeng Yun > --- > v5: changes suggested by Rob > 1. remove unnecessary maxItems > 2. define all phys supported > > v4: &

Re: [PATCH v5 09/11] dt-bindings: usb: convert mediatek, mtk-xhci.txt to YAML schema

2021-01-07 Thread Rob Herring
On Fri, 25 Dec 2020 15:52:56 +0800, Chunfeng Yun wrote: > Convert mediatek,mtk-xhci.txt to YAML schema mediatek,mtk-xhci.yaml > > Signed-off-by: Chunfeng Yun > --- > v5: changes suggested by Rob > 1. refer to usb-xhci.yaml instead of usb-hcd.yaml > 2. remove unnecessar

Re: [PATCH v5 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema

2021-01-07 Thread Rob Herring
On Fri, 25 Dec 2020 15:52:48 +0800, Chunfeng Yun wrote: > Convert usb-device.txt to YAML schema usb-device.yaml > > Signed-off-by: Chunfeng Yun > --- > v5: changes suggested by Rob: > 1. limit the pattern length > 2. remove properties description for hard wired USB de

Re: [PATCH v4 02/24] dt-bindings: introduce silabs,wfx.yaml

2021-01-07 Thread Rob Herring
On Wed, Dec 23, 2020 at 04:39:03PM +0100, Jerome Pouiller wrote: > From: Jérôme Pouiller Commit message? checkpatch.pl reports trailing whitespace errors. > > Signed-off-by: Jérôme Pouiller > --- > .../bindings/net/wireless/silabs,wfx.yaml | 133 ++ > 1 file changed, 133

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Rob Herring
On Tue, Jan 05, 2021 at 02:04:14PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > > DT properties which can have multiple entries need to specify what the > > entries are and define how many entries there can be. In the case of &g

[PATCH] dt-bindings: Add missing array size constraints

2021-01-04 Thread Rob Herring
han Cameron Cc: Dmitry Torokhov Cc: Thomas Gleixner Cc: Marc Zyngier Cc: Mauro Carvalho Chehab Cc: Chen-Yu Tsai Cc: Ulf Hansson Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Sebastian Reichel Cc: Ohad Ben-Cohen Cc: Bjorn Andersson Cc: Greg Kroah-Hartman Signed-off-by: Rob Herri

Re: [PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x

2021-01-03 Thread Rob Herring
On Wed, Dec 23, 2020 at 01:56:33AM +0100, Andrew Lunn wrote: > > + gpio-controller: true > > + "#gpio-cells": > > +const: 2 > > + > > + qcom,single-led-1000: > > +description: | > > + If present, then dedicated 1000 Mbit will light up for 1000Base-T. > > + This is a workround f

[PATCH] dt-bindings: net: qcom,ipa: Drop unnecessary type ref on 'memory-region'

2020-12-21 Thread Rob Herring
'memory-region' is a common property, so it doesn't need a type ref here. Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Alex Elder Cc: netdev@vger.kernel.org Signed-off-by: Rob Herring --- I'll take this via the DT tree. Documentation/devicetree/bindings/n

Re: [RFC PATCH v2 1/8] dt-bindings: net: sparx5: Add sparx5-switch bindings

2020-12-21 Thread Rob Herring
On Thu, Dec 17, 2020 at 08:51:27AM +0100, Steen Hegelund wrote: > Document the Sparx5 switch device driver bindings > > Signed-off-by: Steen Hegelund > Signed-off-by: Lars Povlsen > --- > .../bindings/net/microchip,sparx5-switch.yaml | 178 ++ > 1 file changed, 178 insertions(+)

Re: [PATCH v4 10/11] dt-bindings: usb: convert mediatek,mtu3.txt to YAML schema

2020-12-21 Thread Rob Herring
On Wed, Dec 16, 2020 at 05:30:11PM +0800, Chunfeng Yun wrote: > Convert mediatek,mtu3.txt to YAML schema mediatek,mtu3.yaml > > Signed-off-by: Chunfeng Yun > --- > v4: > 1. refer to usb-drd.yaml insstead of usb/generic.txt > the following ones suggested by Rob: > 2

Re: [PATCH v4 09/11] dt-bindings: usb: convert mediatek,mtk-xhci.txt to YAML schema

2020-12-21 Thread Rob Herring
tation in "mediatek,syscon-wakeup" items > 3. remove reference to usb-hcd.yaml > > v3: > 1. fix yamllint warning > 2. remove pinctrl* properties supported by default suggested by Rob > 3. drop unused labels > 4. modify description of mediatek,syscon-wakeup

Re: [PATCH v4 07/11] dt-bindings: phy: convert MIPI DSI PHY binding to YAML schema

2020-12-21 Thread Rob Herring
by Chun-Kuang > 2. use keyword multipleOf suggested by Rob > 3. fix typo of 'MIPI' in title > > v3: new patch > --- > .../display/mediatek/mediatek,dsi.txt | 18 +--- > .../bindings/phy/mediatek,dsi-phy.yaml| 85 +++ > 2 files

Re: [PATCH v4 02/11] dt-bindings: net: btusb: change reference file name

2020-12-21 Thread Rob Herring
et/btusb.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring

Re: [PATCH v4 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema

2020-12-21 Thread Rob Herring
gt; [v6,00/19] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema > > v3: > 1. remove $nodenmae and items key word for compatilbe; > 2. add additionalProperties; > > The followings are suggested by Rob: > 3. merge the following patch > [v2,1/4] dt-

[PATCH] dt-bindings: Fix JSON pointers

2020-12-17 Thread Rob Herring
ter Roeck Cc: Jonathan Cameron Cc: Lars-Peter Clausen Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Pavel Machek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Andrew Lunn Cc: Florian Fainelli Cc: Sebastian Reichel Cc: Greg Kroah-Hartman Cc: Mark Brown Cc: netdev@v

Re: [PATCH 07/25] dt-bindings: net: dwmac: Detach Generic DW MAC bindings

2020-12-15 Thread Rob Herring
On Mon, Dec 14, 2020 at 12:15:57PM +0300, Serge Semin wrote: > Currently the snps,dwmac.yaml DT bindings file is used for both DT nodes > describing generic DW MAC devices and as DT schema with common properties > to be evaluated against a vendor-specific DW MAC IP-cores. Due to such > dual-purpose

Re: [PATCH 05/25] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk description

2020-12-15 Thread Rob Herring
SR. But > if "pclk" is also specified in the list of the device clocks, then it will > be perceived as the separate CSR clock. > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > October 2013, p. 564. > > Signed-off-by: Serge Semin > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH 06/25] dt-bindings: net: dwmac: Add Tx/Rx clock sources

2020-12-15 Thread Rob Herring
On Mon, Dec 14, 2020 at 12:15:56PM +0300, Serge Semin wrote: > Generic DW *MAC can be connected to an external Tramit and Receive clock s/Tramit/Transmit/ > generators. Add the corresponding clocks description and clock-names to > the generic bindings schema so new DW *MAC-based bindings wouldn't

Re: [PATCH 06/25] dt-bindings: net: dwmac: Add Tx/Rx clock sources

2020-12-15 Thread Rob Herring
gt; its own names of the same clocks. > > Signed-off-by: Serge Semin > --- > .../devicetree/bindings/net/snps,dwmac.yaml| 14 ++ > 1 file changed, 14 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH 03/25] dt-bindings: net: dwmac: Fix the TSO property declaration

2020-12-15 Thread Rob Herring
On Mon, Dec 14, 2020 at 12:15:53PM +0300, Serge Semin wrote: > Indeed the STMMAC driver doesn't take the vendor-specific compatible > string into account to parse the "snps,tso" boolean property. It just > makes sure the node is compatible with DW MAC 4.x, 5.x and DW xGMAC > IP-cores. Fix the condi

Re: [PATCH 02/25] dt-bindings: net: dwmac: Extend number of PBL values

2020-12-15 Thread Rob Herring
aml | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH 01/25] dt-bindings: net: dwmac: Validate PBL for all IP-cores

2020-12-15 Thread Rob Herring
1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > October 2013, p. 380. > > Signed-off-by: Serge Semin > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 69 +++ > 1 file changed, 26 insertions(+), 43 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH 04/25] dt-bindings: net: dwmac: Refactor snps,*-config properties

2020-12-15 Thread Rob Herring
On Tue, Dec 15, 2020 at 2:54 AM Serge Semin wrote: > > Hello Rob, > > On Mon, Dec 14, 2020 at 08:30:06AM -0600, Rob Herring wrote: > > On Mon, Dec 14, 2020 at 12:15:54PM +0300, Serge Semin wrote: > > > Currently the "snps,axi-config", "snps,mtl-rx-config&

Re: [PATCH RFC v2 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

2020-12-15 Thread Rob Herring
On Sun, Dec 13, 2020 at 05:59:05PM +0100, Martin Blumenstingl wrote: > Hi Rob, > > On Mon, Dec 7, 2020 at 8:17 PM Rob Herring wrote: > > > > On Sun, Nov 15, 2020 at 07:52:06PM +0100, Martin Blumenstingl wrote: > > > Amlogic Meson G12A, G12B and SM1 SoCs have a more

Re: [net-next PATCH v12 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-12-14 Thread Rob Herring
On Fri, 11 Dec 2020 22:46:04 +1000, Pavana Sharma wrote: > Add 5gbase-r PHY interface mode. > > Signed-off-by: Pavana Sharma > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: [PATCH 04/25] dt-bindings: net: dwmac: Refactor snps,*-config properties

2020-12-14 Thread Rob Herring
On Mon, Dec 14, 2020 at 12:15:54PM +0300, Serge Semin wrote: > Currently the "snps,axi-config", "snps,mtl-rx-config" and > "snps,mtl-tx-config" properties are declared as a single phandle reference > to a node with corresponding parameters defined. That's not good for > several reasons. First of al

Re: [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
eixner > Cc: Karthikeyan Mitran > Cc: Hou Zhiqiang > Cc: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > --- > drivers/pci/controller/mobiveil/pcie-mobiveil-host.c |8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring

Re: [patch 18/30] PCI: xilinx-nwl: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
leixner > Cc: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Bjorn Helgaas > Cc: Michal Simek > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > --- > drivers/pci/controller/pcie-xilinx-nwl.c |8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring

Re: [PATCH net-next v3 3/3] dt-bindings: net: dsa: add bindings for xrs700x switches

2020-12-09 Thread Rob Herring
On Mon, Dec 07, 2020 at 04:03:55PM -0600, George McCollister wrote: > Add documentation and an example for Arrow SpeedChips XRS7000 Series > single chip Ethernet switches. > > Signed-off-by: George McCollister > Reviewed-by: Florian Fainelli > --- > .../devicetree/bindings/net/dsa/arrow,xrs700x

Re: [PATCH v2 2/2] dt-bindings: net: dsa: lantiq, lantiq-gswip: add example for xRX330

2020-12-09 Thread Rob Herring
On Sun, Dec 06, 2020 at 02:27:13PM +0100, Aleksander Jan Bajkowski wrote: > Add compatible string and example for xRX300 and xRX330. > > Signed-off-by: Aleksander Jan Bajkowski > --- > .../bindings/net/dsa/lantiq-gswip.txt | 110 +- > 1 file changed, 109 insertions(+), 1

Re: [PATCH net-next v5 2/9] dt-bindings: net: dsa: microchip,ksz: add interrupt property

2020-12-09 Thread Rob Herring
On Thu, 03 Dec 2020 11:21:10 +0100, Christian Eggers wrote: > The devices have an optional interrupt line. > > Signed-off-by: Christian Eggers > --- > .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH] dt-bindings::Add compatible strings

2020-12-09 Thread Rob Herring
Applied with subject fixed. 'git log --oneline ' will give you an idea of what the subject should look like. Rob

Re: [PATCH v3 10/11] dt-bindings: usb: convert mediatek,mtu3.txt to YAML schema

2020-12-07 Thread Rob Herring
On Wed, Nov 18, 2020 at 04:21:25PM +0800, Chunfeng Yun wrote: > Convert mediatek,mtu3.txt to YAML schema mediatek,mtu3.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. fix yamllint warning > 2. remove pinctrl* properties > 3. remove unnecessary '|' > 4. drop unused labels in example

Re: [PATCH v3 09/11] dt-bindings: usb: convert mediatek,mtk-xhci.txt to YAML schema

2020-12-07 Thread Rob Herring
On Wed, Nov 18, 2020 at 04:21:24PM +0800, Chunfeng Yun wrote: > Convert mediatek,mtk-xhci.txt to YAML schema mediatek,mtk-xhci.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. fix yamllint warning > 2. remove pinctrl* properties supported by default suggested by R

Re: [PATCH v3 07/11] dt-bindings: phy: convert MIP DSI PHY binding to YAML schema

2020-12-07 Thread Rob Herring
On Wed, Nov 18, 2020 at 04:21:22PM +0800, Chunfeng Yun wrote: > Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml > > Cc: Chun-Kuang Hu > Signed-off-by: Chunfeng Yun > --- > v3: new patch > --- > .../display/mediatek/mediatek,dsi.txt | 18 +--- > .../bindings/phy/mediate

Re: [PATCH v3 04/11] dt-bindings: phy: convert phy-mtk-tphy.txt to YAML schema

2020-12-07 Thread Rob Herring
On Wed, 18 Nov 2020 16:21:19 +0800, Chunfeng Yun wrote: > Convert phy-mtk-tphy.txt to YAML schema mediatek,tphy.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. fix dt_binding_check error in example after add mtu3.yaml > Changes suggested by Rob: > 2. fix

Re: [PATCH v3 03/11] dt-bindings: phy: convert phy-mtk-xsphy.txt to YAML schema

2020-12-07 Thread Rob Herring
On Wed, 18 Nov 2020 16:21:18 +0800, Chunfeng Yun wrote: > Convert phy-mtk-xsphy.txt to YAML schema mediatek,xsphy.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. remove type for property with standard unit suffix suggested by Rob > 2. remove '|' for

Re: [PATCH RFC v2 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

2020-12-07 Thread Rob Herring
On Sun, Nov 15, 2020 at 07:52:06PM +0100, Martin Blumenstingl wrote: > Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX > delay register which allows picoseconds precision. Deprecate the old > "amlogic,rx-delay-ns" in favour of a new "amlogic,rgmii-rx-delay-ps" > property. > > F

Re: [PATCH v9 1/4] dt-bindings: phy: Add sparx5-serdes bindings

2020-12-07 Thread Rob Herring
On Mon, 07 Dec 2020 13:13:42 +0100, Steen Hegelund wrote: > Document the Sparx5 ethernet serdes phy driver bindings. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > --- > .../bindings/phy/microchip,sparx5-serdes.yaml | 100 ++ > 1 file changed, 100 insertions(+

  1   2   3   4   5   6   7   8   >