iproute2: Issue with link type link/generic for NETROM links

that link/netrom will be displayed but I'm wondering if it's going to cause non-obvious breakage or would be acceptable? Thanks, Ralf Signed-off-by: Ralf Baechle lib/ll_types.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ll_types.c b/lib/ll_types.c inde

Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to an address

Hi all, thanks a lot! I can confirm that this fixes my test script. Kind regards, Ralf On 03.01.19 03:57, David Ahern wrote: > From: David Ahern > > IPv6 does not consider if the socket is bound to a device when binding > to an address. The result is that a socket can be bound

Re: Cannot bind to IPv6 address in VRF

ough the > cracks over the last 3 years. > > I will send a patch. Most likely will not happen until tomorrow. Thanks for the quick reply! Good to know I can stop searching the problem elsewhere. :) Kind regards, Ralf

Cannot bind to IPv6 address in VRF

seems like setting `SO_BINDTODEVICE` on the IPv6 socket is just ignored entirely. This is using a Debian stable backports kernel: > $ uname -a > Linux gw1.saar.freifunk.net 4.18.0-0.bpo.3-amd64 #1 SMP Debian > 4.18.20-2~bpo9+1 (2018-12-08) x86_64 GNU/Linux Any help debugging this would be appreciated. Kind regards, Ralf

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

| 2 +- > sound/oss/sys_timer.c | 2 +- > sound/oss/uart6850.c | 2 +- > 47 files changed, 54 insertions(+), 54 deletions(-) Acked-by: Ralf Baechle Thanks, Ralf

Re: [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

uses mod_timer(), > never add_timer(), so the preset expires value is ignored). Set both > sets of arguments to zero. > > Cc: Ralf Baechle > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Cc: Geert Uytterhoeven > Cc: linux-m...@linux-mips.org > Cc: linux-watch...@

[PATCH] sni_82596: Add Thomas' email address to driver.

--- Reviewing Christoph's DMA patch I noticed Thomas' email address was missing from the entire driver file. drivers/net/ethernet/i825xx/sni_82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/sni_82596.c b/drivers/net/ethernet/i825xx/sni_82596

Re: [PATCH 3/4] i825xx: switch to switch to dma_alloc_attrs

On Sat, Aug 26, 2017 at 09:21:24AM +0200, Christoph Hellwig wrote: Adding Thomas Bogendoerfer , the author of sni_82596.c to cc. > This way we can always pass DMA_ATTR_NON_CONSISTENT, the SNI mips version > will simply ignore the flag. > > Signed-off-by: Christoph Hellwig > --- > drivers/net/e

Re: [PATCH 1/4] sgiseeq: switch to dma_alloc_attrs

On Sat, Aug 26, 2017 at 09:21:22AM +0200, Christoph Hellwig wrote: Looks good, Acked-by: Ralf Baechle Ralf

Re: [PATCH v2 0/5] MIPS: Implement eBPF JIT.

he JIT. Then the eBPF JIT implementation. > > I am CCing netdev@ and the BPF maintainers for their comments, but > would expect Ralf to merge via the MIPS tree if and when it all looks > good. Thanks, applied after fixing a minor conflict in arch/mips/Kconfig. Ralf

Re: [PATCH v2 0/5] MIPS: BPF: JIT fixes and improvements.

t mention it. > > My expectation is that Ralf would merge it via the MIPS tree, as it is fully > contained within arch/mips/* Thanks, applied. Ralf

[PATCH] NET: Fix /proc/net/arp for AX.25

"*" in buf for a NULL address argument. Finally the HW address field is left aligned in a 17 character field (the length of an ethernet HW address in the usual hex notation) for readability. Signed-off-by: Ralf Baechle --- net/ipv4/arp.c | 12 ++-- 1 file changed, 6 insert

[PATCH] NET: mkiss/6pack: Fix SIOCSIFENCAP ioctl

spattach utility was passing 4 for the mode, so the mode check added for 6pack is a bit more lenient allow the values 0 and 4 to be set. That way we retain the option to set different encapsulation modes for future extensions. Signed-off-by: Ralf Baechle drivers/net/hamradio/6pack.c | 1

[PATCH] NET: mkiss: Fix panic

or dev->hard_header_len and dev->addr_len are set to the same values as in my mkiss patch. [r...@linux-mips.org: Massages original submission to conform to the usual standards for patch submissions.] Signed-off-by: Thomas Osterried Signed-off-by: Ralf Baechle --- drivers/net/hamradio/mkiss.c | 4

[PATCH iproute2] ip: HSR: Fix cut and paste error

Fixes: 5c0aec93a516 ("ip: Add HSR support") Signed-off-by: Ralf Baechle --- I found this by coincidence when reading the HSR code. ip/iplink_hsr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink_hsr.c b/ip/iplink_hsr.c index cb744eb..696b2c9 10064

Re: [PATCH net-next 20/27] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI

I assume you want to merge this together with the rest of you series, so Acked-by: Ralf Baechle Cheers, Ralf On Tue, Dec 13, 2016 at 01:12:39AM +0100, Michał Mirosław wrote: > Date: Tue, 13 Dec 2016 01:12:39 +0100 (CET) > From: Michał Mirosław > To: netdev@vger.kernel.org &

Re: [PATCH] rose: correct integer overflow check

f ROSE devices through netlink plus the necessary changes to iproute2 to go along with that. Ralf

Re: use-after-free in sixpack_close

On Thu, Dec 17, 2015 at 04:05:32PM -0500, David Miller wrote: > This should fix it, the only thing I'm unsure of is if we should perhaps > also use del_timer_sync() here. Anyone? I think so. Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 2/2] mkiss: Fix use after free in sixpack_close().

On Thu, Dec 17, 2015 at 04:05:49PM -0500, David Miller wrote: > Subject: [PATCH 2/2] mkiss: Fix use after free in sixpack_close(). Make that subject "... mkiss_close()." Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH net-next v3 04/17] tx4939: use __ethtool_get_ksettings

On Mon, Nov 30, 2015 at 02:05:42PM -0800, David Decotigny wrote: Acked-by: Ralf Baechle Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

munity. Alban has posted a v2 [1] already but I take it that your Reviewed-by: applies to the v2 patch as well? Ralf [1] https://patchwork.linux-mips.org/patch/10828/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

[PATCH net-tools] Fix stale references to axattach

Rename all references to axattach to kissattach. Axattach has been renamed early to kissattach early in the history of the ax25-utils package which itself has been superseeded by libax25, ax25-tools and ax25-apps but stale references have remained. Signed-off-by: Ralf Baechle --- TODO

[PATCH v2] NET: AX.25: Stop heartbeat timer on disconnect.

From: Richard Stearn This may result in a kernel panic. The bug has always existed but somehow we've run out of luck now and it bites. Signed-off-by: Richard Stearn Cc: sta...@vger.kernel.org # all branches Signed-off-by: Ralf Baechle --- v2: Correctly attribute the patch to Ri

[PATCH] NET: AX.25: Stop heartbeat timer on disconnect.

This may result in a kernel panic. The bug has always existed but somehow we've run out of luck now and it bites. Signed-off-by: Richard Stearn Cc: sta...@vger.kernel.org # all branches Signed-off-by: Ralf Baechle --- net/ax25/ax25_subr.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] NET: hamradio: Fix IP over bpq encapsulation.

ned-off-by: Ralf Baechle Cc: # 4.1 --- drivers/net/hamradio/bpqether.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c index 63ff08a..5b54b18 100644 --- a/drivers/net/hamradio/bpqether.c +++ b/drivers/net/hamradio/bpqether.c @@ -48

Re: Bpqether broken in 4.1

dev->features = NETIF_F_LLTX; /* Allow recursion */ > > #if defined(CONFIG_AX25) || defined(CONFIG_AX25_MODULE) > dev->header_ops = &ax25_header_ops; Thanks, that restored bpqether to work. I will cook up a patch to fix all other AX.25 drivers. Thanks! Ralf -- To

Bpqether broken in 4.1

150117] [] ? early_idt_handler_array+0x120/0x120 [ 33.150117] [] x86_64_start_reservations+0x2a/0x2c [ 33.150117] [] x86_64_start_kernel+0x145/0x168 [ 33.150117] ---[ end trace ff4df9d904cced48 ]--- Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in th

Re: [PATCH 1/2] ax25: Stop using sock->sk_protinfo.

because currently there is the possibility for an ax25_cb to be created by an incoming connection request even without a socket. Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH] NET: ROSE: Don't dereference NULL neighbour pointer.

A ROSE socket doesn't necessarily always have a neighbour pointer so check if the neighbour pointer is valid before dereferencing it. Signed-off-by: Ralf Baechle Tested-by: Bernard Pidoux Cc: sta...@vger.kernel.org #2.6.11+ diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index 8a

Re: [PATCH] ssb: fix handling of ssb_pmu_get_alp_clock()

On Sun, Jun 07, 2015 at 09:02:23AM +0200, Michael Büsch wrote: > Signed-off-by: Michael Buesch > > Can some MIPS people take this, please? Will do, as usual. Unfortunately this missed my last pull request so it's going to Linus by the end of the week. Ralf -- To unsubscribe

Re: [PATCH] net: rose: Use mod_timer

ible to proof that always the same values for data and function are being used. These initializations could then be used elsewhere and the code could then indeed be switched to mod_timer. Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [UPDATED PATCH] SGISEEQ: use cached memory access to make driver work on IP28

On Wed, Dec 19, 2007 at 01:42:36PM +0100, Thomas Bogendoerfer wrote: > - Use inline functions for dma_sync_* instead of macros > - added Kconfig change to make selection for similair SGI boxes easier > > Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> Acked-by: Ra

Re: Inconsistent lock state and possible irq lock inversion dependency detected in ax25.ko

fix for the deadlock due to taking rose_node_list_lock twice: Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Part of Bernard's patch is undoing d85838c55d836c33077344fab424f200f2827d84, this one should probably reverted separately. Ralf -- To unsubscribe from this list: send the line &q

Re: [UPDATED PATCH] SGISEEQ: use cached memory access to make driver work on IP28

On Tue, Dec 04, 2007 at 03:14:46PM -0500, Jeff Garzik wrote: >> Changes to last version: >> - Use inline functions for dma_sync_* instead of macros (suggested by Ralf) >> - added Kconfig change to make selection for similair SGI boxes easier > > Has Ralf ACK'd th

Re: [PATCH] SGISEEQ: use cached memory access to make driver work on IP28

as there no reason for DMA_SYNC_DESC_CPU and DMA_SYNC_DESC_DEV being macros so why not using inlines. Acked-by: Ralf Baechle <[EMAIL PROTECTED]> Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

rt" + depends on ARM || MIPS select CRC32 select MII help If writesb() is not an official API then maybe the answer should have been to either add that API to other architectures or fix the driver. I guess this incident means I need to go through all Kconfig* files

Re: [PATCH] Fix/Rewrite of the mipsnet driver

mipsnet.h which was just copied into mipsnet.c. Or toothing pains of a driver on its way to sanity. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix/Rewrite of the mipsnet driver

ifiers are now less verbose. > - Removed dead and/or unnecessarily complex code. > - Code formatting fixes. > > Tested on Qemu's mipssim emulation, with this patch it can boot a > Debian NFSroot. The patch does no longer apply to a recent tree, can you respin it? Ralf - To

Re: [PATCH] Remove always-true tests in irq handlers

c | 5 + Acked-by: Ralf Baechle <[EMAIL PROTECTED]> Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[MIPS] MIPSnet: Delete all the useless debugging printks.

Plus minor formatting fixes. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> --- drivers/net/mipsnet.c | 44 1 file changed, 4 insertions(+), 40 deletions(-) diff --git a/drivers/net/mipsnet.c b/drivers/net/mipsnet.c index 37707a0..aafc3ce

[NET] TC35815: Fix build

evious definition of 'lp' was here Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index a679f43..8038f28 100644 --- a/drivers/net/tc35815.c +++ b/drivers/net/tc35815.c @@ -1461,7 +1461,6 @@ static irqreturn_t tc35

[NET] SAA9730: Fix build

Fix build breakage by the recent statistics cleanup in cset 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/saa9730.c b/drivers/net/saa9730.c index 14361e8..c65199d 100644 --- a/drivers/net/saa9730.c +++ b/drivers/net/saa

[NET] Jazzsonic: Fix warning about unused variable.

Caused by "[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()" aka 0795af5729b18218767fab27c44b1384f72dc9ad. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/jazzsonic.c b/drivers/net/jazzsonic.c index d3825c8..5c154fe 100644 --- a/drivers/net/j

[NET] MIPSsim: General cleanup

General cleanups mostly as suggested by checkpatch plus getting rid of homebrew version of offsetof(). Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> --- drivers/net/mipsnet.c | 63 ++--- drivers/net/mipsnet.h

Re: [PATCH] sb1250-mac: Driver model & phylib update

er v2.6.23-rc8-mm1)..v2.6.23-rc8-mm1 | diffstat | tail -1 6049 files changed, 573635 insertions(+), 207630 deletions(-) [EMAIL PROTECTED] linux-queue]$ We're all a little too productive ;-) Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

tween lmo and kernel.org. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][MIPS][7/7] AR7: ethernet

n this case; the packed structure is dereferenced by a pointer so no way for gcc to know the alignment. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][MIPS][7/7] AR7: ethernet

_ADDR) { > + if (external_switch) > + phy_id = 0; > + else { > + printk(KERN_ERR "cpmac: no PHY present\n"); > + return -ENODEV; > + } > + } > + > + dev = alloc_ether

Re: [NET] Nuke SET_NETDEV_DEVICE macro

On Wed, Sep 12, 2007 at 05:27:13PM +0100, Ralf Baechle wrote: > It's been a useless no-op for long enough in 2.6 so I figured it's time to > remove it. The number of people that could object because they're > maintaining unified 2.4 and 2.6 drivers is probably rather sm

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

est, Andrew, a while ago. It builds, runs, passes > checkpatch.pl and sparse. No semantic changes. One step closer to sanity for this driver. So it's got my ACK. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMA

Re: [PATCH 1/2] remove asm/bitops.h includes

> Cc: Adrian Bunk <[EMAIL PROTECTED]> > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> For the MIPS and hamradio bits: Acked-by: Ralf Baechle <[EMAIL PROTECTED]> Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMA

[NET] sgiseeq: replace use of dma_cache_wback_inv

The sgiseeq driver is one of the few remaining users of the ancient cache banging DMA API. Replaced with the modern days DMA API. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index 0fb74cb..eb67b02 100644 --- a/drivers/net/sgi

Re: [PATCH 8/9] define global BIT macro

On Sat, Aug 18, 2007 at 11:44:12AM +0200, Jiri Slaby wrote: > define global BIT macro > > move all local BIT defines to the new globally define macro. > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Acked-by: Ralf Baechle <[EMAIL PROTECTED]> for the MACE ethernet

[NET] sgiseeq: Fix return type of sgiseeq_remove

The driver remove method needs to return an int not void. This was just never noticed because usually this driver is not being built as a module. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index 384b468..0fb74cb 100644

[METH] Don't use GFP_DMA for zone allocation.

IP32 doesn't even have a ZONE_DMA so no point in using GFP_DMA in any IP32-specific device driver. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/meth.c b/drivers/net/meth.c index 92b403b..32bed6b 100644 --- a/drivers/net/meth.c +++ b/drivers/net/meth.c @@ -4

Re: [PATCH 13/24] make atomic_read() behave consistently on mips

On Thu, Aug 09, 2007 at 10:00:04AM -0400, Chris Snook wrote: > Purify volatile use for atomic[64]_t on mips. > > Signed-off-by: Chris Snook <[EMAIL PROTECTED]> Acked-by: Ralf Baechle <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev

[NET] IOC3: Switch hw checksumming to ethtool configurable.

Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> --- I've previously sent out this patch a long time ago. At that time I was told NETIF_F_IP_CSUM wouldn't make any sense without NETIF_F_SG. IOC3's S/G abilities are very limited; it can do upto three segments of which the

[IOC3] Switch to pci refcounting safe APIs

Build fixes: Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Index: upstream-linus/drivers/net/ioc3-eth.c === --- upstream-linus.orig/drivers/net/ioc3-eth.c +++ upstream-linus/drivers/net/ioc3-eth.c @@ -352,13 +352,12 @@ static u

Re: [NET] au1000_eth: Fix warnings.

for > dma_alloc_noncoherent(), so you got lucky. Yep, the way this driver is being used (32-bit only) it happens to just work. > Still, I'd say this is for-2.6.22. Yep. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

[NET] au1000_eth: Fix warnings.

laration of function 'dma_free_noncoherent' Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c index c39ab80..c27cfce 100644 --- a/drivers/net/au1000_eth.c +++ b/drivers/net/au1000_eth.c @@ -34,7 +34,7 @@ * * */ - +#include

[NET] meth driver renovation

The meth ethernet driver for the SGI IP32 aka O2 is so far still an old style driver which does not use the device driver model. This is now causing issues with some udev based gadgetry in debian-stable. Fixed by converting the meth driver to a platform device. Signed-off-by: Ralf Baechle

Re: [NET] meth driver renovation

m_driver_register(&meth_driver); > > } > > > > platform_driver_unregister(&meth_driver); Indeed. Will send new patch in separate email. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [NET] meth driver renovation

On Wed, May 23, 2007 at 09:43:30AM +0100, Ralf Baechle wrote: > The meth ethernet driver for the SGI IP32 aka O2 is so far still an old > style driver which does not use the device driver model. This is now > causing issues with some udev based gadgetry in debian-stable. Fixed by >

[NET] meth driver renovation

The meth ethernet driver for the SGI IP32 aka O2 is so far still an old style driver which does not use the device driver model. This is now causing issues with some udev based gadgetry in debian-stable. Fixed by converting the meth driver to a platform device. Signed-off-by: Ralf Baechle

Re: [PATCH 4/5] ne: MIPS: Use platform_driver for ne on RBTX49XX

river. > * Make the ne driver selectable on these boards regardless of CONFIG_ISA > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> Acked-by: Ralf Baechle <[EMAIL PROTECTED]> Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in t

[NET] SAA9730: Fix large pile of warnings

f 'outl' makes integer from pointer without a cast drivers/net/saa9730.c:729: warning: passing argument 2 of 'outl' makes integer from pointer without a cast drivers/net/saa9730.c: In function 'lan_saa9730_write': drivers/net/saa9730.c:848: warning: passing argument 2 of &

Re: [PATCH] Netpoll support for Sibyte MAC

On Mon, Mar 19, 2007 at 03:43:11PM -0700, Deepak Saxena wrote: > +#ifdef CONFIG_SBMAC_COALESCE Not your patch's fault but ... CONFIG_SBMAC_COALESCE is being defined in sb1250-mac.c but the CONFIG_* namespace is reserved for kconfig. Ralf - To unsubscribe from this list: send

[NET] AX.25 Kconfig and docs updates and fixes

e just help. o Rewrite the commented out piece of old Linux 2.4 configuration language to Kconfig for consistency. o Fixup dependencies. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/Documentation/networking/ax25.txt b/Documentation/networking/ax25.txt index 37c25b0.

[PATCH 3/3] Convert to use modern wait queue API

Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/ax25/af_ax25.c | 77 +++- net/netrom/af_netrom.c | 93 - net/rose/af_rose.c | 54 +--- 3 files changed, 109 inse

[PATCH 2/3] Socket locking is a great invention.

Especially if you actually try to do it ;-) Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/rose/af_rose.c | 78 + 1 file changed, 50 insertions(+), 28 deletions(-) Index: linux-net/net/rose/af_

[PATCH 0/3] AX.25, NETROM and ROSE fixes and cleanups

Patches 1/3 and 2/3 are fixes for 2.6.21 and -stable. 3/3 is a cleanup even though it seems to partly paper over a connection establishment issue on extremly fast networks such as loopback I'm still chasing. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev&qu

[PATCH 1/3] Remove ourselves from waitqueue when receiving a signal

Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/rose/af_rose.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-net/net/rose/af_rose.c === --- linux-net.orig/net/rose/af_rose.c +++ linux-net/net/rose/af_rose.c @@

[NET] 3c59x: Fix several modpost warnings

ake vortex_eisa_probe an __init function. o Make vortex_eisa_remove a __devexit function. o Wrap vortex_eisa_driver reference to vortex_eisa_remove with __devexit_p(). Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> drivers/net/3c59x.c | 28 +--- 1

[NET] ibmtr: Drain rich supply of modpost warnings.

to .init.text:ibmtr_probe1 from .text between 'ibmtr_probe_card' (at offset 0x560) and 'ibmtr_reset_timer' WARNING: drivers/net/tokenring/ibmtr.o - Section mismatch: reference to .init.text:ibmtr_probe1 from .text between 'ibmtr_probe_card' (at offset 0x564)

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

ere > GFP_DMA32 is normally cached, because the private area will get read > ahead into cache when the netdev is touched. GFP_* flags have no influence on caching or prefetching. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

On Tue, Mar 06, 2007 at 07:39:21PM -0800, Michael K. Edwards wrote: > On 3/6/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: > >This small change btw. delivers about ~ 3% extra performance on a very > >slow test system. > > Has this change been tested / benchmarked unde

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

the >CPU only data in the private struct are now cached This small change btw. delivers about ~ 3% extra performance on a very slow test system. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo

[NET] netxen: fix warnings

; drivers/net/netxen/netxen_nic_hw.c:250: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'dma_addr_t' u64 is unsigned long so the cast to u64 will result in a warning on the printf arguments for 64-bit builds. So cast to unsi

Re: [patch 2/2] div64_64: common code

On Tue, Mar 06, 2007 at 02:42:28AM -0800, [EMAIL PROTECTED] wrote: > Implement div64_64(): 64-bit by 64-bit division. Needed by networking (at > least). Your patch only implements div64_64() for 32-bit MIPS. Below patch adds the trivial 64-bit bits. Ralf Signed-off-by: Ralf Baechle &

[NET] Fix PCnet32 performance bug on non-coherent architecutres

z CPU this patch increases network bandwidth by about 12%. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c index 36f9d98..4d94ba7 100644 --- a/drivers/net/pcnet32.c +++ b/drivers/net/pcnet32.c @@ -1234,14 +1234,14 @@ static void

Re: [PATCH] Fix broken RBTX4927 support in ne.c

On Thu, Mar 01, 2007 at 01:22:23AM +0900, Atsushi Nemoto wrote: > There are some ifdefs for RBTX4927, but need some more bits. Acked-by: Ralf Baechle <[EMAIL PROTECTED]> Longer term I think NE2000 will need to support platform_devices. It's been used too widely in too creati

[NET] Add support for Seeq 8003 on Challenge S Mezz board.

From: Ladislav Michl <[EMAIL PROTECTED]> Thanks to Jö Fahlke for donating hardware. Signed-off-by: Ladislav Michl <[EMAIL PROTECTED]> Forward porting of Ladis' 2.4 patch. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/sgiseeq.c b/drivers/net/

[PATCH] jmr3927: do not call tc35815_killall().

No need to stop tc35815 before resetting the board. This fixes the build of tc35815 as a module. This also means there is no caller of tc35815_killall left, so remove that function also. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/arch/mips/jmr3927/rbhma3100/setup.c

[RFC][NET] Alignment in mv643xx_eth

The driver contains this little piece of candy: #if defined(CONFIG_DMA_NONCOHERENT) || defined(CONFIG_NOT_COHERENT_CACHE) #define ETH_DMA_ALIGN L1_CACHE_BYTES #else #define ETH_DMA_ALIGN 8 #endif Any reason why we're not using dma_get_cache_alignment() instead?

Re: possible bug in net/tc35815.c in linux-2.6.19

own patch for this (and one other bug), and checked it in. > > Really, though, someone in MIPS-land should give this driver some loving > care. It is filled with bugs and 2.4-era anachronisms. Took a look at it. It's sort of a non-bug because the driver cannot be compiled as module

[NET] sgiseeq: Don't include unnecessary headerfiles.

Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index a833e7f..52ed522 100644 --- a/drivers/net/sgiseeq.c +++ b/drivers/net/sgiseeq.c @@ -12,26 +12,15 @@ #include #include #include -#include -#include -#include -#i

Re: [PATCH] Eliminate user-selectable CONFIG_MV643XX_ETH_[012]

; > drivers/net/Kconfig | 21 - > > 5 files changed, 15 insertions(+), 77 deletions(-) > > ACK. > > I'll let Paul, Ralf or Andrew push this one upstream. Okay, will do that. Ralf - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] Eliminate user-selectable CONFIG_MV643XX_ETH_[012]

ter this patch, these config > variables are only used in arch/ppc, so also move them from > drivers/net/Kconfig to arch/ppc/Kconfig. > > Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> Acked-by: Ralf Baechle <[EMAIL PROTECTED]> Ralf - To unsubscribe from this list: send t

[IOC3] Fix link autonegotiation timer.

Start link negotiation in the open method. Previously it was started on driver initialialization and shutdown on close so an ifdown would have results in closing negotiation for good. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/ioc3-eth.c b/drivers/net/ioc3

[NET] Convert meth to netdev_priv

And while at it loose plenty of useless casts. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/meth.c b/drivers/net/meth.c index d38b7c7..7e69ca6 100644 --- a/drivers/net/meth.c +++ b/drivers/net/meth.c @@ -170,7 +170,7 @@ static int mdio_probe(struct meth_private

[HAMRADIO] Replace local random function with random32()

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c index 153b6dc..84aa211 100644 --- a/drivers/net/hamradio/baycom_epp.c +++ b/drivers/net/hamradio/baycom_ep

Re: [PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag

] sysctl: Remove sys_sysctl support from drivers/char/rtc.c Subject: [PATCH 55/59] sysctl: Remove insert_at_head from register_sysctl Acked-by: Ralf Baechle <[EMAIL PROTECTED]> Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: Using 802.11x wireless usb device on MIPS platform

ell, for one thing because 802.11 is complex. The Linux wireless support has gone through several generations; some of the wireless work was for one or the other reason never integrated in the kernel.org kernel. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev&qu

[AX.25 5/7] Fix unchecked ax25_linkfail_register uses

ax25_linkfail_register uses kmalloc and the callers were ignoring the error value. Rewrite to let the caller deal with the allocation. This allows the use of static allocation of kmalloc use entirely. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> include/net/ax25.h | 10 +++

[AX.25 3/7] Fix unchecked ax25_listen_register uses

Fix ax25_listen_register to return something that's a sane error code, then all callers to use it. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/ax25/ax25_iface.c |7 --- net/netrom/nr_dev.c | 24 ++-- net/rose/af_rose.c|3 ++- 3 files

[AX.25 6/7] Fix unchecked rose_add_loopback_node uses

Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/rose/rose_dev.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) Index: linux-net/net/rose/rose_dev.c === --- linux-net.orig/net/rose/rose

[AX.25 2/7] Fix unchecked ax25_protocol_register uses.

Replace ax25_protocol_register by ax25_register_pid which assumes the caller has done the memory allocation. This allows replacing the kmalloc allocations entirely by static allocations. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> include/net/ax25.h |9 - ne

[AX.25 1/7] Mark all kmalloc users __must_check

The recent fix 0506d4068bad834aab1141b5dc5e748eb175c6b3 made obvious that error values were not being propagated through the AX.25 stack. To help with that this patch marks all kmalloc users in the AX.25, NETROM and ROSE stacks as __must_check. Signed-off-by: Ralf Baechle <[EMAIL PROTEC

[AX.25 7/7] Fix unchecked rose_add_loopback_neigh uses

rose_add_loopback_neigh uses kmalloc and the callers were ignoring the error value. Rewrite to let the caller deal with the allocation. This allows the use of static allocation of kmalloc use entirely. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> include/net/rose.h |4 ++-

[AX.25 4/7] Fix unchecked nr_add_node uses

Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/netrom/nr_route.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Index: linux-net/net/netrom/nr_route.c === --- linux-net.orig/net/netrom/nr_route.c +++

  1   2   >