Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-27 Thread punit vara
On Tue, Oct 27, 2015 at 1:42 PM, Kalle Valo wrote: > punit vara writes: > >> Will my other patches which are already correct be added to wireless >> tree ? or I have to resend everything ? > > Yes, please resend the whole patchset. I don't apply patches > individ

[RESEND PATCH 03/10] net: wireless: rtwifi: Remove duplicated arguments to |

2015-10-27 Thread Punit Vara
Remove uncessary repeated arguments COMP_EFUSE, COMP_REGD, COMP_CHAN with OR(|) This is patch to the debug.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/rtlwifi/debug.c | 6 +++--- 1

[RESEND PATCH 01/10] net: wireless: ath: Remove unnecessary semicolon

2015-10-27 Thread Punit Vara
This patch is to the htt_rx.c that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[RESEND PATCH 04/10] net: wireless: brcm80211: Remove duplicated arguments to |

2015-10-27 Thread Punit Vara
Remove uncessary repeated arguments with OR(|) This is patch to the brcmsmac/channel.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/channel.c | 1 - 1 file changed, 1 dele

[RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result()

2015-10-27 Thread Punit Vara
This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara --- drivers/net/wireless/ath/carl9170

[RESEND PATCH 05/10] net: wireless: simplify return flow for zd1201_setconfig16

2015-10-27 Thread Punit Vara
This patch is to the zd1201.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified and declaration on line 1658 can be dropped Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/zd1201.c | 6

[RESEND PATCH 08/10] net: wireless: brcm80211: Remove unneeded variable which return 0

2015-10-27 Thread Punit Vara
This is patch to the brcmsmac/main.c that removes unnecessary variable which was declared to return zero. This patch fixes up warning reported by coccicheck: -Unneeded variable: "err". Return "0" on line 3788 Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211

[RESEND PATCH 10/10] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-27 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath5k/eeprom.c | 4 ++-

[RESEND PATCH 09/10] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0

2015-10-27 Thread Punit Vara
This patch is to the brcmsmac/stf.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret_code". Return "0" on line 328 Remove unneccesary variable ret_code created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/stf

[RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-27 Thread Punit Vara
This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret Signed-off-by: Punit Va

[RESEND PATCH 02/10] net: wireless: ath: Remove unnecessary semicolon

2015-10-27 Thread Punit Vara
This patch is to the ath10k/wmi.h that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v6 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-26 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- Remove empty line suggested by Sergei drivers/net/wireles

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-26 Thread punit vara
On Fri, Oct 23, 2015 at 12:26 AM, Sergei Shtylyov wrote: > On 10/22/2015 09:47 PM, Punit Vara wrote: > >> Remove black line suggested by Sergei > > >Such kind of comments should be under the --- tear line. > >> >> This patch is to the ath5k/eepr

[PATCH v6 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-23 Thread Punit Vara
This warning is reported by coccicheck: Signed-off-by: Punit Vara --- drivers/net/wireless/ath/wcn36xx/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 900e72a..94bcc08 100644

Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread punit vara
On Fri, Oct 23, 2015 at 12:05 AM, Sergei Shtylyov wrote: > Hello. > > On 10/22/2015 09:26 PM, Punit Vara wrote: > >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccicheck: >> >> -Unneeded variable: "ret". Return "0&

[PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Punit Vara
Remove empty line suggested by Sergei This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireles

[PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Punit Vara
Remove black line suggested by Sergei This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireles

[PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Also removed empty line suggested by Sergei Signed-off-by: Punit Vara --- drivers/ne

Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread punit vara
On Thu, Oct 22, 2015 at 3:16 AM, Sergei Shtylyov wrote: > On 10/21/2015 05:55 PM, Punit Vara wrote: > >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccicheck: >> >> Unneeded variable: "ret". Return "0" on line 980 &g

Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks

2015-10-22 Thread punit vara
On Thu, Oct 22, 2015 at 3:13 AM, Sergei Shtylyov wrote: > Hello. > > On 10/21/2015 05:55 PM, Punit Vara wrote: > >> This patch is to the ath10k/pci.h file that fixes following warning > > >pci.c, you mean? > > >> reported by coccicheck: >> &

[PATCH v2 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++--

[PATCH v2 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread Punit Vara
remove int ret suggested by Jiri Slaby This patch is to the at76c50x-usb.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers

[PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

2015-10-21 Thread Punit Vara
Remove int ret suggested by kbuild test robot This patch is to the wlcore/acx.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara

Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread punit vara
On Wed, Oct 21, 2015 at 8:30 PM, Jiri Slaby wrote: > On 10/21/2015, 04:55 PM, Punit Vara wrote: >> @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void) >> static int at76_remap(struct usb_device *udev) >> { >> int ret; >> - ret = usb_contr

[PATCH 03/15] net: wireless: ath: Remove unnecessary semicolon

2015-10-21 Thread Punit Vara
This patch is to the ath10k/wmi.h that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 02/15] net: wireless: ath: Remove unnecessary semicolon

2015-10-21 Thread Punit Vara
This patch is to the htt_rx.c that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 04/15] net: wireless: ipw2x00: use | instead of + for summing bitmasks

2015-10-21 Thread Punit Vara
This patch is to the libipw_rx.c file that fixes following warning reported by coccicheck: WARNING: sum of probable bitmasks, consider | I have replaced + with OR operator | for summing bitmasks Signed-off-by: Punit Vara --- drivers/net/wireless/ipw2x00/libipw_rx.c | 4 ++-- 1 file changed, 2

[PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks

2015-10-21 Thread Punit Vara
This patch is to the ath10k/pci.h file that fixes following warning reported by coccicheck: WARNING: sum of probable bitmasks, consider | I have replaced + with OR operator | for summing bitmasks Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/pci.c | 10 +- 1 file

[PATCH 09/15] net: wireless: simplify return flow for zd1201_setconfig16

2015-10-21 Thread Punit Vara
This patch is to the zd1201.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified and declaration on line 1658 can be dropped Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/zd1201.c | 6

[PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread Punit Vara
This patch is to the at76c50x-usb.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/at76c50x-usb.c | 5 + 1

[PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-21 Thread Punit Vara
This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret Signed-off-by: Punit Va

[PATCH 06/15] net: wireless: rtwifi: Remove duplicated arguments to |

2015-10-21 Thread Punit Vara
Remove uncessary repeated arguments COMP_EFUSE, COMP_REGD, COMP_CHAN with OR(|) This is patch to the debug.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/rtlwifi/debug.c | 6 +++--- 1

[PATCH 12/15] net: wireless: brcm80211: Remove unneeded variable which return 0

2015-10-21 Thread Punit Vara
This is patch to the brcmsmac/main.c that removes unnecessary variable which was declared to return zero. This patch fixes up warning reported by coccicheck: -Unneeded variable: "err". Return "0" on line 3788 Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211

[PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite_result()

2015-10-21 Thread Punit Vara
This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara --- drivers/net/wireless/ath/carl9170

[PATCH 13/15] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0

2015-10-21 Thread Punit Vara
This patch is to the brcmsmac/stf.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret_code". Return "0" on line 328 Remove unneccesary variable ret_code created to return zero. Siged-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/stf

[PATCH 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-21 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath5k/eeprom.c | 4 ++-

[PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-21 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/wcn36xx/main.c | 3 +-- 1 file

[PATCH 00/15] Fix warnings reported by coccicheck

2015-10-21 Thread Punit Vara
Fix various warning reported by coccicheck: make coccicheck M=drivers/net/wireless Punit Vara (15): net: wireless: ath: use | instead of + for summing bitmasks net: wireless: ath: Remove unnecessary semicolon net: wireless: ath: Remove unnecessary semicolon net: wireless: ipw2x00: use

[PATCH 07/15] net: wireless: brcm80211: Remove duplicated arguments to |

2015-10-21 Thread Punit Vara
Remove uncessary repeated arguments with OR(|) This is patch to the brcmsmac/channel.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/channel.c | 1 - 1 file changed, 1 dele

[PATCH 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

2015-10-21 Thread Punit Vara
This patch is to the wlcore/acx.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/ti/wlcore/acx.c | 6 +- 1

[PATCH] man2: adjtimex.2 : add info about Clock source

2015-08-30 Thread Punit Vara
: Punit Vara --- man2/adjtimex.2 | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/man2/adjtimex.2 b/man2/adjtimex.2 index 04b53b1..77b4e30 100644 --- a/man2/adjtimex.2 +++ b/man2/adjtimex.2 @@ -276,8 +276,28 @@ Mode (0 = Phase Locked Loop, 1 = Frequency