[PATCH net-next v5] GTP: add support for flow based tunneling API

2021-01-09 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- v4-v5: - coding style changes v3-v4: - add check for

[PATCH net-next v4] GTP: add support for flow based tunneling API

2021-01-05 Thread Pravin B Shelar
Following patch add support for LWT flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- v3-v4: - add check for non-zero dst port v2-v3

[PATCH net-next v4] GTP: add support for flow based tunneling API

2020-12-14 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- v3-v4: - add check for non-zero dst port v2-v3

[PATCH net-next v3] GTP: add support for flow based tunneling API

2020-12-13 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- v2-v3: - Fixed coding style - changed IFLA_GTP_FD1

[PATCH net-next v2] GTP: add support for flow based tunneling API

2020-12-11 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- Fixed according to comments from Jonas Bonn

[PATCH net-next] GTP: add support for flow based tunneling API

2020-12-10 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- drivers/net/gtp.c | 541

[PATCH] MAINTAINERS: Update my email address.

2018-01-02 Thread Pravin B Shelar
-or1k-* OPENVSWITCH -M: Pravin Shelar +M: Pravin B Shelar L: netdev@vger.kernel.org L: d...@openvswitch.org W: http://openvswitch.org -- 2.7.4

[PATCH stable 4.1] openvswitch: gre: filter gre packets

2017-01-08 Thread Pravin B Shelar
] RIP [] __skb_pull.part.7+0x4/0x6 [openvswitch] [68245.520082] ---[ end trace 383bac9f3e676970 ]--- Fixes: aa310701e7 ("openvswitch: Add gre tunnel support.") Reported-by: Uri Foox CC: Joe Stringer Signed-off-by: Pravin B Shelar --- Newer OVS GRE vport uses LWT interface which does not

[PATCH net] openvswitch: upcall: Fix vlan handling.

2016-12-26 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- net/openvswitch/datapath.c | 1 - net/openvswitch/flow.c | 54 +++--- 2 files changed, 27 insertions(+), 28 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 2d4c4d3..9c62b63 10

[PATCH net-next v3 3/4] geneve: Remove redundant socket checks.

2016-11-21 Thread Pravin B Shelar
Geneve already has check for device socket in route lookup function. So no need to check it in xmit function. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index

[PATCH net-next v3 2/4] geneve: Merge ipv4 and ipv6 geneve_build_skb()

2016-11-21 Thread Pravin B Shelar
There are minimal difference in building Geneve header between ipv4 and ipv6 geneve tunnels. Following patch refactors code to unify it. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 100 ++- 1 file changed, 26 insertions(+), 74

[PATCH net-next v3 1/4] geneve: Unify LWT and netdev handling.

2016-11-21 Thread Pravin B Shelar
cases. Removes duplicate code, single code path can handle either type of geneve devices. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 612 ++- 1 file changed, 263 insertions(+), 349 deletions(-) diff --git a/drivers/net/geneve.c b

[PATCH net-next v3 4/4] geneve: Optimize geneve device lookup.

2016-11-21 Thread Pravin B Shelar
Rather than comparing 64-bit tunnel-id, compare tunnel vni which is 24-bit id. This also save conversion from vni to tunnel id on each tunnel packet receive. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff

[PATCH net-next v3 0/4] geneve: Use LWT more effectively.

2016-11-21 Thread Pravin B Shelar
Following patch series make use of geneve LWT code path for geneve netdev type of device. This allows us to simplify geneve module without changing any functionality. v2-v3: Rebase against latest net-next. v1-v2: Fix warning reported by kbuild test robot. Pravin B Shelar (4): geneve: Unify

[PATCH net-next v2 1/4] geneve: Unify LWT and netdev handling.

2016-11-18 Thread Pravin B Shelar
cases. Removes duplicate code, single code path can handle either type of geneve devices. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 612 ++- 1 file changed, 263 insertions(+), 349 deletions(-) diff --git a/drivers/net/geneve.c b

[PATCH net-next v2 0/4] geneve: Use LWT more effectively.

2016-11-18 Thread Pravin B Shelar
Following patch series make use of geneve LWT code path for geneve netdev type of device. This allows us to simplify geneve module. v1-v2: Fix warning reported by kbuild test robot. Pravin B Shelar (4): geneve: Unify LWT and netdev handling. geneve: Merge ipv4 and ipv6 geneve_build_skb

[PATCH net-next v2 2/4] geneve: Merge ipv4 and ipv6 geneve_build_skb()

2016-11-18 Thread Pravin B Shelar
There are minimal difference in building Geneve header between ipv4 and ipv6 geneve tunnels. Following patch refactors code to unify it. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 100 ++- 1 file changed, 26 insertions(+), 74

[PATCH net-next v2 3/4] geneve: Remove redundant socket checks.

2016-11-18 Thread Pravin B Shelar
Geneve already has check for device socket in route lookup function. So no need to check it in xmit function. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index

[PATCH net-next v2 4/4] geneve: Optimize geneve device lookup.

2016-11-18 Thread Pravin B Shelar
Rather than comparing 64-bit tunnel-id, compare tunnel vni which is 24-bit id. This also save conversion from vni to tunnel id on each tunnel packet receive. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff

[PATCH net-next 2/4] geneve: Merge ipv4 and ipv6 geneve_build_skb()

2016-11-17 Thread Pravin B Shelar
There are minimal difference in building Geneve header between ipv4 and ipv6 geneve tunnels. Following patch refactors code to unify it. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 100 ++- 1 file changed, 26 insertions(+), 74

[PATCH net-next 0/4] geneve: Use LWT more effectively.

2016-11-17 Thread Pravin B Shelar
Following patch series make use of geneve LWT code path for geneve netdev type of device. This allows us to simplify geneve module. Pravin B Shelar (4): geneve: Unify LWT and netdev handling. geneve: Merge ipv4 and ipv6 geneve_build_skb() geneve: Remove redundant socket checks. geneve

[PATCH net-next 1/4] geneve: Unify LWT and netdev handling.

2016-11-17 Thread Pravin B Shelar
cases. Removes duplicate code, single code path can handle either type of geneve devices. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 611 ++- 1 file changed, 262 insertions(+), 349 deletions(-) diff --git a/drivers/net/geneve.c b

[PATCH net-next 4/4] geneve: Optimize geneve device lookup.

2016-11-17 Thread Pravin B Shelar
Rather than comparing 64-bit tunnel-id, compare tunnel vni which is 24-bit id. This also save conversion from vni to tunnel id on each tunnel packet receive. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff

[PATCH net-next 3/4] geneve: Remove redundant socket checks.

2016-11-17 Thread Pravin B Shelar
Geneve already has check for device socket in route lookup function. So no need to check it in xmit function. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index

[PATCH net-next v3 2/7] vxlan: avoid checking socket multiple times.

2016-11-13 Thread Pravin B Shelar
Check the vxlan socket in vxlan6_getroute(). Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 756d826..9adeff9 100644 --- a/drivers/net/vxlan.c +++ b/drivers

[PATCH net-next v3 3/7] vxlan: simplify exception handling

2016-11-13 Thread Pravin B Shelar
. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 46 +++--- 1 file changed, 19 insertions(+), 27 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 9adeff9..8bb58f6 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c

[PATCH net-next v3 1/7] vxlan: avoid vlan processing in vxlan device.

2016-11-13 Thread Pravin B Shelar
VxLan device does not have special handling for vlan taging on egress. Therefore it does not make sense to expose vlan offloading feature. This patch does not change vxlan functinality. Signed-off-by: Pravin B Shelar Acked-by: Jiri Benc --- drivers/net/vxlan.c | 9 + include/linux

[PATCH net-next v3 7/7] vxlan: remove unsed vxlan_dev_dst_port()

2016-11-13 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- include/net/vxlan.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 308adc4..49a5920 100644 --- a/include/net/vxlan.h +++ b/include/net/vxlan.h @@ -281,16 +281,6 @@ struct vxlan_dev { struct

[PATCH net-next v3 0/7] vxlan: xmit improvements.

2016-11-13 Thread Pravin B Shelar
support is not enabled. Pravin B Shelar (7): vxlan: avoid vlan processing in vxlan device. vxlan: avoid checking socket multiple times. vxlan: simplify exception handling vxlan: improve vxlan route lookup checks. vxlan: simplify RTF_LOCAL handling. vxlan: simplify vxlan xmit vxlan: remove

[PATCH net-next v3 6/7] vxlan: simplify vxlan xmit

2016-11-13 Thread Pravin B Shelar
Existing vxlan xmit function handles two distinct cases. 1. vxlan net device 2. vxlan lwt device. By seperating initialization these two cases the egress path looks better. Signed-off-by: Pravin B Shelar Acked-by: Jiri Benc --- drivers/net/vxlan.c | 78

[PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

2016-11-13 Thread Pravin B Shelar
B Shelar --- drivers/net/vxlan.c | 77 ++--- 1 file changed, 38 insertions(+), 39 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 8bb58f6..aabb918 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1789,7

[PATCH net-next v3 5/7] vxlan: simplify RTF_LOCAL handling.

2016-11-13 Thread Pravin B Shelar
Avoid code duplicate code for handling RTF_LOCAL routes. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 85 - 1 file changed, 51 insertions(+), 34 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index aabb918

[PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-05 Thread Pravin B Shelar
B Shelar --- drivers/net/vxlan.c | 71 + 1 file changed, 34 insertions(+), 37 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index bd17ab5..f106178 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1795,7

[PATCH net-next v2 7/7] vxlan: remove unsed vxlan_dev_dst_port()

2016-11-05 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- include/net/vxlan.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 308adc4..49a5920 100644 --- a/include/net/vxlan.h +++ b/include/net/vxlan.h @@ -281,16 +281,6 @@ struct vxlan_dev { struct

[PATCH net-next v2 5/7] vxlan: simplify RTF_LOCAL handling.

2016-11-05 Thread Pravin B Shelar
Avoid code duplicate code for handling RTF_LOCAL routes. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 85 +++-- 1 file changed, 50 insertions(+), 35 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index f106178

[PATCH net-next v2 2/7] vxlan: simplify exception handling

2016-11-05 Thread Pravin B Shelar
. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 756d826..a1e707f 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1789,7

[PATCH net-next v2 6/7] vxlan: simplify vxlan xmit

2016-11-05 Thread Pravin B Shelar
Existing vxlan xmit function handles two distinct cases. 1. vxlan net device 2. vxlan lwt device. By seperating initilization these two cases the egress path looks better. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 79 - 1 file

[PATCH net-next v2 1/7] vxlan: avoid vlan processing in vxlan device.

2016-11-05 Thread Pravin B Shelar
VxLan device does not have special handling for vlan taging on egress. Therefore it does not make sense to expose vlan offloading feature. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 9 + include/linux/if_vlan.h | 16 2 files changed, 1 insertion

[PATCH net-next v2 3/7] vxlan: avoid checking socket multiple times.

2016-11-05 Thread Pravin B Shelar
Check the vxlan socket in vxlan6_getroute(). Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index a1e707f..bd17ab5 100644 --- a/drivers/net/vxlan.c +++ b/drivers

[PATCH net-next v2 0/7] vxlan: General improvements.

2016-11-05 Thread Pravin B Shelar
Following patch series improves vxlan fast path, removes duplicate code and simplifies vxlan xmit code path. v1-v2: Fix compilation error when IPv6 support is not enabled. Pravin B Shelar (7): vxlan: avoid vlan processing in vxlan device. vxlan: simplify exception handling vxlan: avoid

[PATCH net-next 7/7] vxlan: remove unsed vxlan_dev_dst_port()

2016-11-04 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- include/net/vxlan.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 308adc4..49a5920 100644 --- a/include/net/vxlan.h +++ b/include/net/vxlan.h @@ -281,16 +281,6 @@ struct vxlan_dev { struct

[PATCH net-next 6/7] vxlan: simplify vxlan xmit

2016-11-04 Thread Pravin B Shelar
Existing vxlan xmit function handles two distinct cases. 1. vxlan net device 2. vxlan lwt device. By seperating initilization these two cases the egress path looks better. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 79 - 1 file

[PATCH net-next 2/7] vxlan: simplify exception handling

2016-11-04 Thread Pravin B Shelar
. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 756d826..a1e707f 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1789,7

[PATCH net-next 5/7] vxlan: simplify RTF_LOCAL handling.

2016-11-04 Thread Pravin B Shelar
Avoid code duplicate code for handling RTF_LOCAL routes. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 78 + 1 file changed, 43 insertions(+), 35 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 15319f1

[PATCH net-next 0/7] vxlan: General improvements.

2016-11-04 Thread Pravin B Shelar
Following patch series improves vxlan fast path, removes duplicate code and simplifies vxlan xmit code path. Pravin B Shelar (7): vxlan: avoid vlan processing in vxlan device. vxlan: simplify exception handling vxlan: avoid checking socket multiple times. vxlan: improve vxlan route lookup

[PATCH net-next 3/7] vxlan: avoid checking socket multiple times.

2016-11-04 Thread Pravin B Shelar
Check the vxlan socket in vxlan6_getroute(). Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index a1e707f..6435d6a 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net

[PATCH net-next 1/7] vxlan: avoid vlan processing in vxlan device.

2016-11-04 Thread Pravin B Shelar
VxLan device does not have special handling for vlan taging on egress. Therefore it does not make sense to expose vlan offloading feature. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 9 + include/linux/if_vlan.h | 16 2 files changed, 1 insertion

[PATCH net-next 4/7] vxlan: improve vxlan route lookup checks.

2016-11-04 Thread Pravin B Shelar
B Shelar --- drivers/net/vxlan.c | 71 + 1 file changed, 34 insertions(+), 37 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 6435d6a..15319f1 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1793,7

[PATCH net-next] genetlink: Fix generic netlink family unregister

2016-10-28 Thread Pravin B Shelar
76505a814dd68770 ]--- Fixes: 2ae0f17df1c ("genetlink: use idr to track families"). Reported-by: Jarno Rajahalme CC: Johannes Berg Signed-off-by: Pravin B Shelar --- net/netlink/genetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/genetlink.c b/n

[PATCH v2 net 1/2] vxlan: avoid using stale vxlan socket.

2016-10-28 Thread Pravin B Shelar
When vxlan device is closed vxlan socket is freed. This operation can race with vxlan-xmit function which dereferences vxlan socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 80

[PATCH v2 net 2/2] geneve: avoid using stale geneve socket.

2016-10-28 Thread Pravin B Shelar
This patch is similar to earlier vxlan patch. Geneve device close operation frees geneve socket. This operation can race with geneve-xmit function which dereferences geneve socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar Acked-by: John W

[PATCH net 1/2] vxlan: avoid using stale vxlan socket.

2016-10-27 Thread Pravin B Shelar
When vxlan device is closed vxlan socket is freed. This operation can race with vxlan-xmit function which dereferences vxlan socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 80

[PATCH net 2/2] geneve: avoid using stale geneve socket.

2016-10-27 Thread Pravin B Shelar
This patch is similar to earlier vxlan patch. Geneve device close operation frees geneve socket. This operation can race with geneve-xmit function which dereferences geneve socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar --- drivers/net

[PATCH net-next 2/2] openvswitch: avoid resetting flow key while installing new flow.

2016-09-19 Thread Pravin B Shelar
since commit commit db74a3335e0f6 ("openvswitch: use percpu flow stats") flow alloc resets flow-key. So there is no need to reset the flow-key again if OVS is using newly allocated flow-key. Signed-off-by: Pravin B Shelar --- net/openvswitch/datapath.c | 8 net/openvswi

[PATCH net-next 1/2] openvswitch: Fix Frame-size larger than 1024 bytes warning.

2016-09-19 Thread Pravin B Shelar
024 bytes [-Wframe-larger-than=] Signed-off-by: Pravin B Shelar --- net/openvswitch/datapath.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 0536ab3..474e7a6 100644 --- a/net/openvswitch/datapat

[PATCH net 1/2] net: vxlan: lwt: Use source ip address during route lookup.

2016-08-06 Thread Pravin B Shelar
vxlan: Flow based tunneling"). Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index da4e3d6..b812234 100644 --- a/drivers/net/vxlan.c +++ b/d

[PATCH net 2/2] net: vxlan: lwt: Fix vxlan local traffic.

2016-08-06 Thread Pravin B Shelar
. Reported-by: Jakub Libosvar Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index b812234..c0dda6f 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2022

[PATCH net-next v3] ip_tunnel: Move stats update to iptunnel_xmit()

2015-12-24 Thread Pravin B Shelar
By moving stats update into iptunnel_xmit(), we can simplify iptunnel_xmit() usage. With this change there is no need to call another function (iptunnel_xmit_stats()) to update stats in tunnel xmit code path. Signed-off-by: Pravin B Shelar --- v2-v3: - Fixed ip6tunnel_xmit() v1-v2: - keep

[PATCH net-next v2] ip_tunnel: Move stats update to iptunnel_xmit()

2015-12-23 Thread Pravin B Shelar
By moving stats update into iptunnel_xmit(), we can simplify iptunnel_xmit() usage. With this change there is no need to call another function (iptunnel_xmit_stats()) to update stats in tunnel xmit code path. Signed-off-by: Pravin B Shelar --- v1-v2: - keep iptunnel_xmit_stats() stats update

[PATCH net-next] ip_tunnel: Move stats update to iptunnel_xmit()

2015-12-21 Thread Pravin B Shelar
By moving stats update into iptunnel_xmit(), we can simplify iptunnel_xmit() usage. With this change there is no need to call another function (iptunnel_xmit_stats()) to update stats in tunnel xmit code path. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 17

[PATCH] ipip: ioctl: Remove superfluous IP-TTL handling.

2015-12-17 Thread Pravin B Shelar
IP-TTL case is already handled in ip_tunnel_ioctl() API. Signed-off-by: Pravin B Shelar --- net/ipv4/ipip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index 1f06729..4044da6 100644 --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c @@ -252,9 +252,6

[PATCH net-next] ip_tunnel: Move stats update to iptunnel_xmit()

2015-12-08 Thread Pravin B Shelar
By moving stats update into iptunnel_xmit(), we can simplify iptunnel_xmit() usage. With this change there is no need to call another function (iptunnel_xmit_stats()) to update stats in tunnel xmit code path. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 18

[PATCH net] geneve: Fix IPv6 xmit stats update.

2015-12-07 Thread Pravin B Shelar
Call to iptunnel_xmit_stats() is not required after udp-tunnel6-xmit. By calling iptunnel_xmit_stats() results in incorrect device stats. Following patch drops this call. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff

[PATCH net v3] openvswitch: Fix egress tunnel info.

2015-10-22 Thread Pravin B Shelar
ovs-tnl-vport devices. So after adding such device operation we can remove similar operation from ovs-vport. Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device"). Signed-off-by: Pravin B Shelar -- v2-v3: - Remove unused tun_info v1-v2: - changed ndo operati

[PATCH net v2] openvswitch: Fix egress tunnel info.

2015-10-22 Thread Pravin B Shelar
ovs-tnl-vport devices. So after adding such device operation we can remove similar operation from ovs-vport. Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device"). Signed-off-by: Pravin B Shelar --- v1-v2: - changed ndo operation name to ndo_fill_metadata_dst() - Fix ge

[PATCH net-next] openvswitch: Use dev_queue_xmit for vport send.

2015-10-20 Thread Pravin B Shelar
With use of lwtunnel, we can directly call dev_queue_xmit() rather than calling netdev vport send operation. Following change make tunnel vport code bit cleaner. Signed-off-by: Pravin B Shelar --- net/openvswitch/vport-geneve.c |2 +- net/openvswitch/vport-gre.c |2

[PATCH net-next] openvswitch: Fix incorrect type use.

2015-10-20 Thread Pravin B Shelar
("openvswitch: netlink attributes for IPv6 tunneling") Signed-off-by: Pravin B Shelar --- net/openvswitch/flow_netlink.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index 6799c8d..80e1f09 100644

[PATCH net] openvswitch: Fix egress tunnel info.

2015-10-05 Thread Pravin B Shelar
ovs-tnl-vport devices. After adding the device operation There is no need for similar ovs-vport operation. So the vport API is removed. Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device"). Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c

[PATCH net] openvswitch: Fix ovs_vport_get_stats()

2015-10-02 Thread Pravin B Shelar
/0x200 [] netlink_sendmsg+0x308/0x364 [] sock_sendmsg+0x14/0x2c [] SyS_sendto+0xbc/0xf0 Code: aa1603e1 f94037a4 aa1303e2 aa1703e0 (f9400465) Reported-by: Tomasz Sawicki Fixes: 8c876639c98 ("openvswitch: Remove vport stats.") Signed-off-by: Pravin B Shelar --- net/openvswitc

[PATCH net] skbuff: Fix skb checksum partial check.

2015-09-28 Thread Pravin B Shelar
ted. Negative value of checksum offset start means there is no need to checksum. Fixes: 6ae459bda ("skbuff: Fix skb checksum flag on skb pull") Reported-by: Andrew Vagin Signed-off-by: Pravin B Shelar --- This and 6ae459bda patches needs to be backported to stable. --- include/linux/sk

[PATCH net v2] skbuff: Fix skb checksum flag on skb pull

2015-09-22 Thread Pravin B Shelar
[] __do_softirq+0xa8/0x210 [] call_softirq+0x1c/0x30 [] do_softirq+0x65/0xa0 [] irq_exit+0x8e/0xb0 [] do_IRQ+0x63/0xe0 [] common_interrupt+0x6e/0x6e Reported-by: Anupam Chanda Signed-off-by: Pravin B Shelar --- v1-v2: Set skb to CHECKSUM_NONE rather than CHECKSUM_UNNECESSARY. --- include/linux/skbuff.h

[PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-20 Thread Pravin B Shelar
[] __do_softirq+0xa8/0x210 [] call_softirq+0x1c/0x30 [] do_softirq+0x65/0xa0 [] irq_exit+0x8e/0xb0 [] do_IRQ+0x63/0xe0 [] common_interrupt+0x6e/0x6e Reported-by: Anupam Chanda Signed-off-by: Pravin B Shelar --- net/core/dev.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net

[PATCH net-next] tun_dst: Remove opts_size

2015-08-31 Thread Pravin B Shelar
opts_size is only written and never read. Following patch removes this unused variable. Signed-off-by: Pravin B Shelar --- include/net/dst_metadata.h |1 - net/core/dst.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/net/dst_metadata.h b

[PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Pravin B Shelar
308] [] call_softirq+0x1c/0x30 [ 13.852308] [] do_softirq+0x65/0xa0 [ 13.852308] [] irq_exit+0x8e/0xb0 [ 13.852308] [] do_IRQ+0x63/0xe0 [ 13.852308] [] common_interrupt+0x6e/0x6e [ 13.852308] [ 13.852308] [] ? system_call_fastpath+0x16/0x1b Reported-by: Anupam Chanda Signed-off-by: Pravin B She

[PATCH net-next] ip-tunnel: Use API to access tunnel metadata options.

2015-08-30 Thread Pravin B Shelar
Currently tun-info options pointer is used in few cases to pass options around. But tunnel options can be accessed using ip_tunnel_info_opts() API without using the pointer. Following patch removes the redundant pointer and consistently make use of API. Signed-off-by: Pravin B Shelar

[PATCH net-next 0/4] openvswitch: Cleanup post vport conversion.

2015-08-29 Thread Pravin B Shelar
After converting all vport to netdev implmentations there is no need for some of vport functionalify. Pravin B Shelar (4): openvswitch: Remove vport get_name() openvswitch: Remove egress_tun_info. openvswitch: Remove vport stats. openvswitch: Remove vport-net net/openvswitch/actions.c

[PATCH net-next 1/4] openvswitch: Remove vport get_name()

2015-08-29 Thread Pravin B Shelar
Remove unused get_name() function pointer from vport ops. Signed-off-by: Pravin B Shelar --- net/openvswitch/vport.h |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h index b88b3ee..2f35244 100644 --- a/net

[PATCH net-next 2/4] openvswitch: Remove egress_tun_info.

2015-08-29 Thread Pravin B Shelar
tun info is passed using skb-dst pointer. Now we have converted all vports to netdev based implementation so Now we can remove redundant pointer to tun-info from OVS_CB. Signed-off-by: Pravin B Shelar --- net/openvswitch/actions.c |5 - net/openvswitch/datapath.c |1 - net

[PATCH net-next 4/4] openvswitch: Remove vport-net

2015-08-29 Thread Pravin B Shelar
This structure is not used anymore. Signed-off-by: Pravin B Shelar --- net/openvswitch/datapath.h |2 -- net/openvswitch/flow.c |3 ++- net/openvswitch/vport.h|4 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/net/openvswitch/datapath.h b/net/openvswitch

[PATCH net-next 3/4] openvswitch: Remove vport stats.

2015-08-29 Thread Pravin B Shelar
Since all vport types are now backed by netdev, we can directly use netdev stats. Following patch removes redundant stat from vport. Signed-off-by: Pravin B Shelar --- net/openvswitch/vport-internal_dev.c | 57 -- net/openvswitch/vport-netdev.c | 22 +++ net

[PATCH v5 net-next 4/8] geneve: Make dst-port configurable.

2015-08-26 Thread Pravin B Shelar
Add netlink interface to configure Geneve UDP port number. So that user can configure it for a Gevene device. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c | 25 + include

[PATCH v5 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

2015-08-26 Thread Pravin B Shelar
Introduce function udp_tun_rx_dst() to initialize tunnel dst on receive path. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf --- drivers/net/vxlan.c| 29 ++-- include/net/dst_metadata.h | 61

[PATCH v5 net-next 6/8] openvswitch: Use Geneve device.

2015-08-26 Thread Pravin B Shelar
-by: Pravin B Shelar Reviewed-by: Jesse Gross --- net/openvswitch/Kconfig|2 +- net/openvswitch/vport-geneve.c | 179 +++ 2 files changed, 33 insertions(+), 148 deletions(-) diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig index

[PATCH v5 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-26 Thread Pravin B Shelar
module. Signed-off-by: Pravin B Shelar --- v4-v5: - Fix xnet for collect-md tunnels v3-v4: - Fixed newlink() validation. v2-v3: - Fixed Kconfig dependency. - unified geneve_build_skb() - Fixed geneve_build_skb() error path. --- drivers/net/Kconfig|4 +- drivers/net/geneve.c | 507

[PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-26 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Geneve Consolidation patch get rid of collect_md_tun to simplify tunnel lookup further. Signed-off-by: Pravin B Shelar Reviewed-by

[PATCH v5 net-next 2/8] geneve: Use skb mark and protocol to lookup route.

2015-08-26 Thread Pravin B Shelar
On packet transmit path geneve need to lookup route. Following patch improves route lookup using more parameters. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c |3 +++ 1 files changed, 3 insertions(+), 0

[PATCH v5 net-next 8/8] geneve: Move device hash table to geneve socket.

2015-08-26 Thread Pravin B Shelar
This change simplifies Geneve Tunnel hash table management. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Reviewed-by: John W. Linville --- drivers/net/geneve.c | 43 +-- 1 files changed, 17 insertions(+), 26 deletions(-) diff --git a

[PATCH v5 net-next 1/8] geneve: Initialize ethernet address in device setup.

2015-08-26 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 897e1a3..95e9da0 100644 --- a/drivers

[PATCH v5 net-next 0/8] geneve: Add support for tunnel metadata mode

2015-08-26 Thread Pravin B Shelar
. - Improve geneve device route lookup with more parameters. Pravin B Shelar (8): geneve: Initialize ethernet address in device setup. geneve: Use skb mark and protocol to lookup route. tunnel: introduce udp_tun_rx_dst() geneve: Make dst-port configurable. geneve: Add support to collect tunnel

[PATCH v4 net-next 1/8] geneve: Initialize ethernet address in device setup.

2015-08-26 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 897e1a3..95e9da0 100644 --- a/drivers

[PATCH v4 net-next 4/8] geneve: Make dst-port configurable.

2015-08-26 Thread Pravin B Shelar
Add netlink interface to configure Geneve UDP port number. So that user can configure it for a Gevene device. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c | 25 + include

[PATCH v4 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-26 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Geneve Consolidation patch get rid of collect_md_tun to simplify tunnel lookup further. Signed-off-by: Pravin B Shelar --- v3-v4

[PATCH v4 net-next 2/8] geneve: Use skb mark and protocol to lookup route.

2015-08-26 Thread Pravin B Shelar
On packet transmit path geneve need to lookup route. Following patch improves route lookup using more parameters. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c |3 +++ 1 files changed, 3 insertions(+), 0

[PATCH v4 net-next 6/8] openvswitch: Use Geneve device.

2015-08-26 Thread Pravin B Shelar
-by: Pravin B Shelar Reviewed-by: Jesse Gross --- net/openvswitch/Kconfig|2 +- net/openvswitch/vport-geneve.c | 179 +++ 2 files changed, 33 insertions(+), 148 deletions(-) diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig index

[PATCH v4 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-26 Thread Pravin B Shelar
module. Signed-off-by: Pravin B Shelar --- v3-v4: - Fixed newlink() validation. v2-v3: - Fixed Kconfig dependency. - unified geneve_build_skb() - Fixed geneve_build_skb() error path. --- drivers/net/Kconfig|4 +- drivers/net/geneve.c | 512

[PATCH v4 net-next 0/8] Geneve: Add support for tunnel metadata mode

2015-08-26 Thread Pravin B Shelar
more parameters. Pravin B Shelar (8): geneve: Initialize ethernet address in device setup. geneve: Use skb mark and protocol to lookup route. tunnel: introduce udp_tun_rx_dst() geneve: Make dst-port configurable. geneve: Add support to collect tunnel metadata. openvswitch: Use Geneve

[PATCH v4 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

2015-08-26 Thread Pravin B Shelar
Introduce function udp_tun_rx_dst() to initialize tunnel dst on receive path. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf --- drivers/net/vxlan.c| 29 ++-- include/net/dst_metadata.h | 61

[PATCH v4 net-next 8/8] geneve: Move device hash table to geneve socket.

2015-08-26 Thread Pravin B Shelar
This change simplifies Geneve Tunnel hash table management. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Reviewed-by: John W. Linville --- Rebased on updated patches. --- drivers/net/geneve.c | 43 +-- 1 files changed, 17 insertions(+), 26

[PATCH v3 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

2015-08-24 Thread Pravin B Shelar
Introduce function udp_tun_rx_dst() to initialize tunnel dst on receive path. Signed-off-by: Pravin B Shelar --- Rebased to support ipv6 tun-dst. --- drivers/net/vxlan.c| 29 ++-- include/net/dst_metadata.h | 61 include

[PATCH v3 net-next 6/8] openvswitch: Use Geneve device.

2015-08-24 Thread Pravin B Shelar
-by: Pravin B Shelar Reviewed-by: Jesse Gross --- net/openvswitch/Kconfig|2 +- net/openvswitch/vport-geneve.c | 179 +++ 2 files changed, 33 insertions(+), 148 deletions(-) diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig index

  1   2   >