Re: RFC on writel and writel_relaxed

2018-03-28 Thread okaya
On 2018-03-28 02:14, Linus Torvalds wrote: On Tue, Mar 27, 2018 at 5:24 PM, Sinan Kaya wrote: Basically changing it to dma_buffer->foo = 1;/* WB */ wmb() writel_relaxed(KICK, DMA_KICK_REGISTER);/* UC */ mmiowb() Why? Why not just remove the wmb(), and keep the

Re: [PATCH v4 17/17] net: ena: Eliminate duplicate barriers on weakly-ordered archs

2018-03-25 Thread okaya
On 2018-03-25 08:06, Belgazal, Netanel wrote: I think you should either add a parameter to ena_com_write_sq_doorbell() or add ena_com_write_sq_doorbell_rel(). Right now, you have unused function. That is true. I got rid of ena_com_write_sq_doorbell_rel. On 3/20/18, 4:43 AM, "Sinan Kaya" wr

Re: [PATCH v7 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs

2018-03-23 Thread okaya
On 2018-03-23 19:58, Jeff Kirsher wrote: On Fri, 2018-03-23 at 14:53 -0700, Alexander Duyck wrote: On Fri, Mar 23, 2018 at 11:52 AM, Sinan Kaya wrote: > Code includes wmb() followed by writel() in multiple places. writel() > already has a barrier on some architectures like arm64. > > This ends

Re: [PATCH v4 12/17] net: cxgb4/cxgb4vf: Eliminate duplicate barriers on weakly-ordered archs

2018-03-21 Thread okaya
On 2018-03-21 19:03, Casey Leedom wrote: [[ Appologies for the DUPLICATE email. I forgot to tell my Mail Agent to use Plain Text. -- Casey ]] I feel very uncomfortable with these proposed changes. Our team is right in the middle of trying to tease our way through the various platform i

Re: [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb()

2018-03-21 Thread okaya
On 2018-03-21 17:54, David Miller wrote: From: Jeff Kirsher Date: Wed, 21 Mar 2018 14:48:08 -0700 On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote: Remove ixgbevf_write_tail() in favor of moving writel() close to wmb(). Signed-off-by: Sinan Kaya Reviewed-by: Alexander Duyck --- drivers

Re: [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb()

2018-03-21 Thread okaya
On 2018-03-21 17:48, Jeff Kirsher wrote: On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote: Remove ixgbevf_write_tail() in favor of moving writel() close to wmb(). Signed-off-by: Sinan Kaya Reviewed-by: Alexander Duyck --- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 - driver

Re: [PATCH 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs

2018-03-14 Thread okaya
On 2018-03-14 01:08, Timur Tabi wrote: On 3/13/18 10:20 PM, Sinan Kaya wrote: +/* Assumes caller has executed a write barrier to order memory and device + * requests. + */ static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 value) { - writel(value, ring->tail); +

Re: [PATCH 3/7] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs

2018-03-14 Thread okaya
On 2018-03-14 00:12, Jason Gunthorpe wrote: On Tue, Mar 13, 2018 at 11:20:24PM -0400, Sinan Kaya wrote: Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before execu

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-18 Thread okaya
On 2016-04-18 08:12, Christoph Hellwig wrote: On Sat, Apr 16, 2016 at 06:23:32PM -0400, Sinan Kaya wrote: Current code is assuming that the address returned by dma_alloc_coherent is a logical address. This is not true on ARM/ARM64 systems. Can you explain what you mean with a 'logical address

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-17 Thread okaya
On 2016-04-18 00:00, David Miller wrote: From: Sinan Kaya Date: Sat, 16 Apr 2016 18:23:32 -0400 Current code is assuming that the address returned by dma_alloc_coherent is a logical address. This is not true on ARM/ARM64 systems. This patch replaces dma_alloc_coherent with dma_map_page API. T