sed card. It was introduced by a Jan 10 commit post rc7
(sorry, don't have the details right now - my laptop died yesterday).
A bugzilla has already been opened.
Nigel
This message was sent using IMP, the Internet Messaging
Hi.
On Tue, 2007-06-05 at 00:53 +0200, Pavel Machek wrote:
> On Tue 2007-06-05 08:49:04, Nigel Cunningham wrote:
> > Hi.
> >
> > On Tue, 2007-06-05 at 00:41 +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > > > > > +#endif /* CONFIG_PM
he way I suggested is nicer, IIRC akpm invented it. It keeps
> ifdefs localized around the block that _needs_ to be ifdefed.
The localised point is true. I'll also admit that 'nicer'/'uglier' is a
matter of aesthetics and therefore personal opinion.
I guess that leaves the question, "What's the precedent to follow?" or
"Is there a driver that's already got this new format?".
Regards,
Nigel
signature.asc
Description: This is a digitally signed message part
h(dev);
> > > + }
> > > + }
> > > + return 0;
> > > +}
> > > +
> > #else
> > #define *_resume NULL
> > #define *_suspend NULL
>
> > > +#endif /* CONFIG_PM */
> >
> > > @@ -1689,6 +1775,10 @@ static struct pci_driver uli526x_driver
> > > .id_table = uli526x_pci_tbl,
> > > .probe = uli526x_init_one,
> > > .remove = __devexit_p(uli526x_remove_one),
> > > +#ifdef CONFIG_PM
> > > + .suspend= uli526x_suspend,
> > > + .resume = uli526x_resume,
> > > +#endif
> >
> > ...so that this ifdef is not needed?
>
> OK, why not.
Because it's uglier and #ifdef is the established way of doing things?
Regards,
Nigel
signature.asc
Description: This is a digitally signed message part
