Re: [ovs-dev] [PATCH] openvswitch: perform refragmentation for packets which pass through conntrack

2021-04-12 Thread Marcelo Leitner
On Mon, Apr 12, 2021 at 09:40:40AM -0400, Aaron Conole wrote: > Ilya Maximets writes: > > > On 4/10/21 2:22 PM, Aaron Conole wrote: > >> Ilya Maximets writes: > >> > >>> On 4/8/21 10:41 PM, Aaron Conole wrote: > Joe Stringer writes: > > > Hey Aaron, long time no chat :) > >

Re: [ovs-dev] tc-conntrack: inconsistent behaviour with icmpv6

2021-03-26 Thread Marcelo Leitner
On Tue, Mar 16, 2021 at 05:12:22PM +0200, Louis Peens wrote: > So in the end I think there are two problems - the on you identified with > only checking > the mask in commit 1bcc51ac0731. And then the second bigger one is that the > behaviour > differs depending on whether the recirc upcall is af

Re: [ovs-dev] tc-conntrack: inconsistent behaviour with icmpv6

2021-03-12 Thread Marcelo Leitner
Hi there, On Wed, Mar 10, 2021 at 12:06:52PM +0100, Ilya Maximets wrote: > Hi, Louis. Thanks for your report! > > Marcelo, Paul, could you, please, take a look? Thanks for the ping. +wenxu > > Best regards, Ilya Maximets. > > On 3/10/21 8:51 AM, Louis Peens wrote: > > Hi all > > > > We've r

Re: Yet another approach for implementing connection tracking offload

2019-02-22 Thread Marcelo Leitner
On Mon, Feb 18, 2019 at 07:00:19PM +, Yossi Kuperman wrote: > Hello All, > > Following is a description of yet another possible approach to > implement connection tracking offload. We would like to hear your > opinion. There is the “native” way of implementing such an offload > by mirroring th

Re: [RFC PATCH net-next 1/6 v2] net/sched: Introduce act_ct

2019-02-01 Thread Marcelo Leitner
On Tue, Jan 29, 2019 at 10:02:01AM +0200, Paul Blakey wrote: ... > diff --git a/include/uapi/linux/tc_act/tc_ct.h > b/include/uapi/linux/tc_act/tc_ct.h > new file mode 100644 > index 000..6dbd771 > --- /dev/null > +++ b/include/uapi/linux/tc_act/tc_ct.h > @@ -0,0 +1,29 @@ > +/* SPDX-License-Id

Re: [RFC PATCH net-next 6/6 v2] net/sched: act_ct: Add tc recirc id set/del support

2019-01-29 Thread Marcelo Leitner
On Tue, Jan 29, 2019 at 10:02:06AM +0200, Paul Blakey wrote: > Set or clears (free) the skb tc recirc id extension. > If used with OVS, OVS can clear this recirc id after it reads it. > > Signed-off-by: Paul Blakey > --- > include/net/tc_act/tc_ct.h| 2 ++ > include/uapi/linux/tc_act/tc

Re: [RFC PATCH net-next 3/6 v2] net/sched: cls_flower: Add ematch support

2019-01-29 Thread Marcelo Leitner
On Tue, Jan 29, 2019 at 10:02:03AM +0200, Paul Blakey wrote: > TODO: handle EEXist. > > Signed-off-by: Paul Blakey > --- > include/uapi/linux/pkt_cls.h | 2 ++ > net/sched/cls_flower.c | 22 ++ > 2 files changed, 20 insertions(+), 4 deletions(-) > > diff --git a/inclu

Re: [RFC PATCH net-next 0/6 v2] connection tracking in tc and OVS offload

2019-01-29 Thread Marcelo Leitner
On Tue, Jan 29, 2019 at 09:59:07AM +0200, Paul Blakey wrote: > Hi, > As you may know, we are working on connection tracking for a while, and we > already > had patches for tc that matched our connection tracking offload RFC. > > Marcelo already shared his tc patches for a similar action ct and f

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-29 Thread marcelo . leitner
On Mon, Jan 23, 2017 at 10:58:10AM -0500, David Miller wrote: > If this is "so critical" for end to end communication, why the heck > do you not see __packed sprinkled all over our definitions for IPV4, > IPV6, TCP, UDP, etc. headers? > > Do you know why? Because it's completely unnecessary... B

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-23 Thread marcelo . leitner
On Mon, Jan 23, 2017 at 11:00:47AM -0500, David Miller wrote: > From: "'Marcelo Ricardo Leitner'" > Date: Mon, 23 Jan 2017 10:36:28 -0200 > > > So, no padding. A field just after the other, which is what we want on a > > network header. > > It isn't necessary! > > Show me a case where it is req

Re: [PATCHv4 net-next 3/5] sctp: implement sender-side procedures for SSN/TSN Reset Request Parameter

2017-01-20 Thread marcelo . leitner
On Fri, Jan 20, 2017 at 02:00:34PM -0500, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Fri, 20 Jan 2017 16:25:22 -0200 > > > I talked offline with Xin about this and we cannot do it this way. > > Unfortunatelly we will have to take the long road here, because then > > we may send d

Re: [PATCH][V2] net: sctp: fix array overrun read on sctp_timer_tbl

2017-01-20 Thread marcelo . leitner
On Fri, Jan 20, 2017 at 11:32:09AM -0500, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Fri, 20 Jan 2017 11:58:45 -0200 > > > Not sure I can add the Fixes tag for you here, but: > > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer") > > Acked-by: Marcelo Ricardo Leitner > > FWI

Re: [PATCH net] ibmveth: calculate gso_segs for large packets

2016-12-14 Thread marcelo . leitner
On Tue, Dec 13, 2016 at 06:15:09PM -0600, Thomas Falcon wrote: > Include calculations to compute the number of segments > that comprise an aggregated large packet. > > Signed-off-by: Thomas Falcon Reviewed-by: Marcelo Ricardo Leitner > --- > drivers/net/ethernet/ibm/ibmveth.c | 12 ++

Re: [PATCH net] tcp: warn on bogus MSS and try to amend it

2016-12-02 Thread marcelo . leitner
On Thu, Dec 01, 2016 at 03:29:49PM -0500, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 30 Nov 2016 11:14:32 -0200 > > > There have been some reports lately about TCP connection stalls caused > > by NIC drivers that aren't setting gso_size on aggregated packets on rx > > path.

Re: [PATCH net] tcp: warn on bogus MSS and try to amend it

2016-12-01 Thread marcelo . leitner
On Thu, Dec 01, 2016 at 03:29:49PM -0500, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 30 Nov 2016 11:14:32 -0200 > > > There have been some reports lately about TCP connection stalls caused > > by NIC drivers that aren't setting gso_size on aggregated packets on rx > > path.

Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

2016-10-31 Thread marcelo . leitner
On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote: > From: Xin Long > Date: Mon, 31 Oct 2016 00:42:35 +0800 > > > Prior to this patch, it used a local variable to save the transport that is > > looked up by __sctp_lookup_association(), and didn't return it back. But in > > sctp_rcv, it

Re: [PATCHv2 net 0/5] sctp: some fixes of prsctp polices

2016-09-28 Thread marcelo . leitner
On Wed, Sep 28, 2016 at 11:17:16AM -0400, David Miller wrote: > From: Xin Long > Date: Wed, 28 Sep 2016 20:35:40 +0800 > > >> > >>> This patchset is to improve some codes about prsctp polices, and also > >>> to fix some issues. > >>> > >>> v1->v2: > >>> - wrap the check of chunk->sent_count in

Re: [PATCH net] sctp: change to use TCP_CLOSE_WAIT as SCTP_SS_CLOSING

2016-08-01 Thread marcelo . leitner
On Sat, Jul 30, 2016 at 10:08:03PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Sat, 30 Jul 2016 10:25:35 -0300 > > > On Sat, Jul 30, 2016 at 08:00:45PM +0800, Xin Long wrote: > >> Prior to this patch, sctp defined TCP_CLOSING as SCTP_SS_CLOSING. > >> TCP_CLOSING is such a s

Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate

2016-06-16 Thread marcelo . leitner
On Thu, Jun 16, 2016 at 02:11:39PM -0700, David Miller wrote: > From: Xin Long > Date: Thu, 16 Jun 2016 01:15:06 +0800 > > > Commit d46e416c11c8 ("sctp: sctp should change socket state when > > shutdown is received") may set sk_state CLOSING in sctp_sock_migrate, > > but inet_accept doesn't allow

Re: [PATCH v3 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-29 Thread marcelo . leitner
On Fri, Apr 29, 2016 at 12:10:31PM -0400, Neil Horman wrote: > On Fri, Apr 29, 2016 at 10:47:25AM -0300, marcelo.leit...@gmail.com wrote: > > On Fri, Apr 29, 2016 at 09:36:37AM -0400, Neil Horman wrote: > > > On Thu, Apr 28, 2016 at 05:46:59PM -0300, marcelo.leit...@gmail.com wrote: > > > > On Thu,

Re: [PATCH v3 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-29 Thread marcelo . leitner
On Fri, Apr 29, 2016 at 09:36:37AM -0400, Neil Horman wrote: > On Thu, Apr 28, 2016 at 05:46:59PM -0300, marcelo.leit...@gmail.com wrote: > > On Thu, Apr 14, 2016 at 05:19:00PM -0300, marcelo.leit...@gmail.com wrote: > > > On Thu, Apr 14, 2016 at 04:03:51PM -0400, Neil Horman wrote: > > > > On Thu,

Re: [PATCH v3 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-28 Thread marcelo . leitner
On Thu, Apr 14, 2016 at 05:19:00PM -0300, marcelo.leit...@gmail.com wrote: > On Thu, Apr 14, 2016 at 04:03:51PM -0400, Neil Horman wrote: > > On Thu, Apr 14, 2016 at 02:59:16PM -0400, David Miller wrote: > > > From: Marcelo Ricardo Leitner > > > Date: Thu, 14 Apr 2016 14:00:49 -0300 > > > > > > >

Re: [PATCH net-next 1/2] skbuff: Add pskb_extract() helper function

2016-04-22 Thread marcelo . leitner
On Wed, Apr 20, 2016 at 03:17:41AM -0700, Sowmini Varadhan wrote: ... > +/* Extract to_copy bytes starting at off from skb, and return this in > + * a new skb > + */ > +struct sk_buff *pskb_extract(struct sk_buff *skb, int off, > + int to_copy, gfp_t gfp) > +{ > + struc

Re: [PATCH net-next 0/2] pskb_extract() helper function.

2016-04-22 Thread marcelo . leitner
On Wed, Apr 20, 2016 at 03:17:40AM -0700, Sowmini Varadhan wrote: > This patchset follows up on the discussion in > https://www.mail-archive.com/netdev@vger.kernel.org/msg105090.html > > For RDS-TCP, we have to deal with the full gamut of > nonlinear sk_buffs, including all the frag_list variants

Re: [PATCH v3 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-14 Thread marcelo . leitner
On Thu, Apr 14, 2016 at 04:03:51PM -0400, Neil Horman wrote: > On Thu, Apr 14, 2016 at 02:59:16PM -0400, David Miller wrote: > > From: Marcelo Ricardo Leitner > > Date: Thu, 14 Apr 2016 14:00:49 -0300 > > > > > Em 14-04-2016 10:03, Neil Horman escreveu: > > >> On Wed, Apr 13, 2016 at 11:05:32PM -

Re: [PATCH v3 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-14 Thread marcelo . leitner
On Thu, Apr 14, 2016 at 02:59:16PM -0400, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Thu, 14 Apr 2016 14:00:49 -0300 > > > Em 14-04-2016 10:03, Neil Horman escreveu: > >> On Wed, Apr 13, 2016 at 11:05:32PM -0400, David Miller wrote: > >>> From: Marcelo Ricardo Leitner > >>> Date

Re: [PATCH net-next 0/7] sctp: support sctp_diag in kernel

2016-04-06 Thread marcelo . leitner
On Wed, Apr 06, 2016 at 04:13:12PM -0400, David Miller wrote: > From: Xin Long > Date: Tue, 5 Apr 2016 12:06:25 +0800 > > > This patchset will add sctp_diag module to implement diag interface on > > sctp in kernel. > ... > > This series looks generally fine to me, but I'd like to see some revi

Re: [PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread marcelo . leitner
On Wed, Apr 06, 2016 at 03:57:35PM -0400, David Miller wrote: > From: Joe Perches > Date: Wed, 06 Apr 2016 12:53:24 -0700 > > > On Wed, 2016-04-06 at 14:53 -0300, Marcelo Ricardo Leitner wrote: > >> It wastes space and gets worse as we add new flags, so convert bit-wide > >> flags to a bitfield.

Re: [PATCH] sctp: flush if we can't fit another DATA chunk

2016-03-30 Thread marcelo . leitner
On Wed, Mar 30, 2016 at 03:46:22PM -0400, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Tue, 29 Mar 2016 10:41:25 -0300 > > > There is no point in delaying the packet if we can't fit a single byte > > of data on it anymore. So lets just reduce the threshold by the amount > > that a

Re: [PATCH net] sctp: translate host order to network order when setting a hmacid

2015-11-12 Thread marcelo . leitner
On Thu, Nov 12, 2015 at 01:07:07PM +0800, Xin Long wrote: > now sctp auth cannot work well when setting a hmacid manually, which > is caused by that we didn't use the network order for hmacid, so fix > it by adding the transformation in sctp_auth_ep_set_hmacs. > > even we set hmacid with the netwo