Re: [PATCH][next] net: hns3: Fix uninitialized return from function

2021-02-17 Thread lipeng (Y)
在 2021/2/10 23:26, Colin King 写道: From: Colin Ian King Currently function hns3_reset_notify_uninit_enet is returning the contents of the uninitialized variable ret. Fix this by removing ret (since it is no longer used) and replace it with a return of the literal value 0. you can not remov

Re: [PATCH net-next v2 0/7] Support setting lanes via ethtool

2020-12-17 Thread lipeng (Y)
在 2020/12/17 16:57, Danielle Ratson 写道: From: Danielle Ratson Some speeds can be achieved with different number of lanes. For example, 100Gbps can be achieved using two lanes of 50Gbps or four lanes of 25Gbps. This patch set adds a new selector that allows ethtool to patch set -> patchset

Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

2019-01-02 Thread lipeng (Y)
On 2019/1/1 9:22, dann frazier wrote: On Mon, Nov 26, 2018 at 06:43:00PM +, Salil Mehta wrote: From: Peng Li Port 0/1 of HiP08 supports 10G and 25G. This patch adds a change to configure NIC port speed same as that of optical module(SFP/QFSP). Driver gets the optical module speed and s

Re: [PATCH net-next 00/23] net: hns3: HNS3 bug fixes & code improvements

2018-03-08 Thread lipeng (Y)
On 2018/3/8 13:00, David Miller wrote: Sorry, this is way too large of a patch series. Please keep your series to about a dozen or so changes. Anything longer puts an unreasonable burdon upon patch reviewers, and such a large series will often make it so that nearly all reviewers are discoura

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

2018-01-18 Thread lipeng (Y)
On 2018/1/18 22:25, Andrew Lunn wrote: +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) +{ + int ret, cur_page; + + mutex_lock(&phydev->lock); + + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); + if (ret < 0) + goto out; + else

Re: [PATCH net-next 00/11] add some new features and fix some bugs

2018-01-11 Thread lipeng (Y)
On 2018/1/12 1:07, David Miller wrote: From: Peng Li Date: Thu, 11 Jan 2018 19:45:55 +0800 This patchset adds some new features and fixes some bugs: [patch 1/11] adds ethtool_ops.get_channels support for VF. [patch 2/11] removes TSO config command from VF driver. [patch 3/11] adds ethtool_op

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

2018-01-08 Thread lipeng (Y)
On 2018/1/9 11:06, David Miller wrote: From: "lipeng (Y)" Date: Tue, 9 Jan 2018 10:48:04 +0800 So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). I think it is OK if you send the revert patch, which is what I am asking

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

2018-01-08 Thread lipeng (Y)
On 2018/1/9 9:54, David Miller wrote: From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 Oh, I only noticed this extra misleading comment now. Unless each queue has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted. [patch 12/20 ] add

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread lipeng (Y)
On 2018/1/5 22:54, Andrew Lunn wrote: --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev, { struct hns3_nic_priv *priv = netdev_priv(netdev);

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 12:04, David Miller wrote: From: "lipeng (Y)" Date: Thu, 21 Dec 2017 09:30:01 +0800 On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/1

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix some related bugs for chan

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix some related bugs for chan

Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-19 Thread lipeng (Y)
On 2017/12/20 3:18, David Miller wrote: From: Lipeng Date: Tue, 19 Dec 2017 12:02:24 +0800 @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv *priv) return ret; } +static void hns3_put_ring_config(struct hns3_nic_priv *priv) +{ + struct hnae3_han

Re: [PATCH V2 net-next 01/17] net: hns3: add support to query tqps number

2017-12-19 Thread lipeng (Y)
On 2017/12/20 3:16, David Miller wrote: From: Lipeng Date: Tue, 19 Dec 2017 12:02:23 +0800 @@ -5002,6 +5002,26 @@ static void hclge_uninit_ae_dev(struct hnae3_ae_dev *ae_dev) ae_dev->priv = NULL; } +static u32 hclge_get_max_channels(struct hnae3_handle *handle) +{ + stru

Re: [PATCH net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

2017-12-18 Thread lipeng (Y)
On 2017/12/18 17:08, Sergei Shtylyov wrote: On 12/18/2017 12:31 PM, Lipeng wrote: TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43 (net: hns3: Add tc-based TM support for sriov enable

Re: [PATCH net-next 14/17] net: hns3: add Asym Pause support to phy default features

2017-12-18 Thread lipeng (Y)
On 2017/12/18 17:07, Sergei Shtylyov wrote: Hello! On 12/18/2017 12:31 PM, Lipeng wrote: From: Fuyun Liang commit c4fb2cdf575d (net: hns3: fix a bug for phy supported feature initialization) adds default supported features for phy, but our hardware Ten cited commit's summary needs to

Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

2017-11-08 Thread lipeng (Y)
On 2017/11/8 22:30, Andrew Lunn wrote: On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote: From: Fuyun Liang Driver gets phy address from NCL_config file and uses the phy address to initialize phydev. There are 5 bits for phy address. And C22 phy address has 5 bits. So 0-31 are all valid

Re: [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver

2017-11-07 Thread lipeng (Y)
please ignore this patch-set. I should remove "{topost}" from the subject. sorry for that, I will resend the patch-set. On 2017/11/8 15:31, Lipeng wrote: This patch-set introduces some bug fixes and code improvements. As [patch 1/2] depends on the patch {5392902 net: hns3: Consistently using

Re: [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings

2017-11-05 Thread lipeng (Y)
On 2017/11/4 3:52, Florian Fainelli wrote: On 11/02/2017 09:18 PM, Lipeng wrote: From: Fuyun Liang This patch adds set_link_ksettings support for ethtool cmd. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 11 +++

Re: [PATCH net v4 3/3] net: hns: fixed bug that skb used after kfree

2017-04-27 Thread lipeng (Y)
On 2017/4/28 1:38, Florian Fainelli wrote: On 04/26/2017 07:44 PM, Yankejian wrote: struct hns_nic_priv *priv = netdev_priv(ndev); struct hnae_ring *ring = ring_data->ring; @@ -361,6 +361,10 @@ int hns_nic_net_xmit_hw(struct net_device *ndev, dev_queue = netdev_get_tx_q

Re: [PATCH net v4 1/3] net: hns: support deferred probe when can not obtain irq

2017-04-27 Thread lipeng (Y)
On 2017/4/27 19:58, Matthias Brugger wrote: On 27/04/17 04:44, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, the interrupt lines from the DSAF controllers are connected to mbigen hw module. The mbigen module is probed with module_init, and, as such, is not guaranteed to probe

Re: [PATCH net v3 1/3] net: hns: support deferred probe when can not obtain irq

2017-04-26 Thread lipeng (Y)
On 2017/4/26 22:03, Matthias Brugger wrote: On 26/04/17 09:00, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, the interrupt lines from the DSAF controllers are connected to mbigen hw module. The mbigen module is probed with module_init, and, as such, is not guaranteed to probe

Re: [PATCH net v2 0/3] net: hns: bug fix for HNS driver

2017-04-25 Thread lipeng (Y)
On 2017/4/25 0:24, David Miller wrote: From: Yankejian Date: Fri, 21 Apr 2017 15:44:41 +0800 From: lipeng This series adds support defered probe when mdio or mbigen module insmod behind HNS driver, and fixes a bug that a skb has been freed, but it may be still used in driver. change log:

Re: [PATCH net v2 1/3] net: hns: support deferred probe when can not obtain irq

2017-04-25 Thread lipeng (Y)
On 2017/4/24 22:47, Matthias Brugger wrote: On 24/04/17 13:43, lipeng (Y) wrote: On 2017/4/24 18:28, Matthias Brugger wrote: On 21/04/17 09:44, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, the interrupt lines from the DSAF controllers are connected to mbigen hw module

Re: [PATCH net-next 2/3] net: hns: support deferred probe when no mdio

2017-04-21 Thread lipeng (Y)
On 2017/4/20 19:13, Matthias Brugger wrote: On 18/04/17 12:12, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, phy connect to mdio bus.The mdio module is probed with module_init, and, as such, is not guaranteed to probe before the HNS driver. So we need to support deferred probe.