On Tue, Nov 24, 2020 at 09:05:52PM +0900, Bongsu Jeon wrote:
> On Mon, Nov 23, 2020 at 5:55 PM k...@kernel.org wrote:
> > > +static enum s3fwrn5_mode s3fwrn82_uart_get_mode(void *phy_id)
> > > +{
> > > + struct s3fwrn82_uart_phy *phy = phy_id;
>
On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote:
> On Mon, Nov 23, 2020 at 5:02 PM k...@kernel.org wrote:
> >
> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote:
> > examples:
> > >- |
> > > #include
> > > @@ -
On Mon, Nov 23, 2020 at 04:56:58PM +0900, Bongsu Jeon wrote:
> Since S3FWRN82 NFC Chip, The UART interface can be used.
> S3FWRN82 uses NCI protocol and supports I2C and UART interface.
>
> Signed-off-by: Bongsu Jeon
Please start sending emails properly, e.g. with git send-email, so all
your pat
On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote:
> Since S3FWRN82 NFC Chip, The UART interface can be used.
> S3FWRN82 supports I2C and UART interface.
>
> Signed-off-by: Bongsu Jeon
> ---
> .../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +--
> 1 file changed, 26
On Tue, Nov 17, 2020 at 10:18:50AM +0900, Bongsu Jeon wrote:
> ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP.
>
> Signed-off-by: Bongsu Jeon
> ---
> drivers/nfc/s3fwrn5/s3fwrn5.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
I already reviewed it.
Reviewed-by: Krzyszt
On Tue, Nov 17, 2020 at 10:16:11AM +0900, Bongsu Jeon wrote:
> max_payload is unused.
Why did you resend the patch ignoring my review? I already provided you
with a tag, so you should include it.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Reviewed-by: Krzysztof Kozlow
On Tue, Nov 17, 2020 at 10:17:42AM +0900, Bongsu Jeon wrote:
> stucture should be replaced by structure.
>
> Signed-off-by: Bongsu Jeon
I already reviewed it.
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Mon, Nov 16, 2020 at 10:17:55AM +0900, Bongsu Jeon wrote:
> stucture should be replaced by structure.
>
> Signed-off-by: Bongsu Jeon
> ---
> drivers/nfc/s3fwrn5/firmware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Mon, Nov 16, 2020 at 10:19:50AM +0900, Bongsu Jeon wrote:
> ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP.
>
> Signed-off-by: Bongsu Jeon
> ---
> drivers/nfc/s3fwrn5/s3fwrn5.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski
Best r
On Mon, Nov 16, 2020 at 10:12:05AM +0900, Bongsu Jeon wrote:
> max_payload is unused.
>
> Signed-off-by: Bongsu Jeon
Please version your patches (this should be a v2) and describe changes
between versions in changelog, either in cover letter or after ---
separator.
Reviewed-by: Krzysztof Kozlow
On Sat, Nov 14, 2020 at 09:21:34AM +0900, Bongsu Jeon wrote:
>
> ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP.
The same as in patch #1 - trailing dot a subject end empty line at
beginning of commit.
Please CC all required maintainers and lists when submitting patches.
You skipped here L
On Sat, Nov 14, 2020 at 09:19:20AM +0900, Bongsu Jeon wrote:
>
Empty commit messsage cannot be accepted.
Best regards,
Krzysztof
On Sat, Nov 14, 2020 at 09:17:36AM +0900, Bongsu Jeon wrote:
>
> max_payload is unused.
Thanks for the patch.
You have an empty line at beginning of commit msg - please format the
commit description correctly. Remove alo the trailing dot from subject.
Best regards,
Krzysztof
>
> Signed-off-
13 matches
Mail list logo
