en STMMAC resume back, right?
I tested your patch on top of next-20210419 which has Thierry's revert
of 9c63faaa931e. So yes this is reverted. Unfortunately, with this
change resuming from suspend still does not work.
Jon
--
nvpublic
/arm64")
Signed-off-by: Jon Hunter
---
drivers/ptp/ptp_kvm_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_kvm_common.c b/drivers/ptp/ptp_kvm_common.c
index 721ddcede5e1..fcae32f56f25 100644
--- a/drivers/ptp/ptp_kvm_common.c
+++ b/drivers/
stmmac_clear_tx_descriptors(priv, queue);
> }
> }
>
> @@ -7250,7 +7252,6 @@ int stmmac_resume(struct device *dev)
> stmmac_reset_queues_param(priv);
>
> stmmac_free_tx_skbufs(priv);
> - stmmac_clear_descriptors(priv);
>
> stmmac_hw_setup(ndev, false);
> stmmac_init_coalesce(priv);
>
I have tested this patch, but unfortunately the board still fails to
resume correctly. So it appears to suffer with the same issue we saw on
the previous implementation.
Jon
--
nvpublic
On 01/04/2021 17:28, Jon Hunter wrote:
>
> On 31/03/2021 12:41, Joakim Zhang wrote:
>
> ...
>
>>> In answer to your question, resuming from suspend does work on this board
>>> without your change. We have been testing suspend/resume now on this board
>&g
rm_smmu_pm_resume
<-platform_pm_resume
rtcwake-748 [003] ...1 536.856771: stmmac_pltfr_resume
<-platform_pm_resume
So I don't see any ordering issues that could be causing this.
Jon
--
nvpublic
ard which fails after this change is made,
>>> it has the IOMMU enabled. The other board does not at the moment
>>> (although work is in progress to enable). If I add
>>> 'iommu.passthrough=1' to cmdline for the failing board, then it works
>>> again. So in
nt (although work is in
>> progress to enable). If I add 'iommu.passthrough=1' to cmdline for the
>> failing
>> board, then it works again. So in my case, the problem is linked to the IOMMU
>> being enabled.
>>
>> Does you platform enable the IOMMU?
&g
t;> affect this. Sorry.
I realised that for the board which fails after this change is made, it
has the IOMMU enabled. The other board does not at the moment (although
work is in progress to enable). If I add 'iommu.passthrough=1' to
cmdline for the failing board, then it works again. So in my case, the
problem is linked to the IOMMU being enabled.
Does you platform enable the IOMMU?
Thanks
Jon
--
nvpublic
On 25/03/2021 07:53, Joakim Zhang wrote:
>
>> -Original Message-
>> From: Jon Hunter
>> Sent: 2021年3月24日 20:39
>> To: Joakim Zhang
>> Cc: netdev@vger.kernel.org; Linux Kernel Mailing List
>> ; linux-tegra ;
>> Jakub Kicinski
>> Subj
ess test, there is no issue found.
>
> Could you please do more test to see where the issue happen?
The issue occurs 100% of the time on the failing board and always on the
first resume from suspend. Is there any more debug I can enable to track
down what the problem is?
Jon
--
nvpublic
-eth-dwmac 249.ethernet eth0: Link is Up - 1Gbps/Full - flow
control rx/tx
I don't see any crash, but then it hangs at some point. Please note that
this board is using NFS for mounting the rootfs.
Let me know if there is any more info I can provide or tests I can run.
Thanks
Jon
ing the BRCM PHY resolves that
as well. I will ensure that these are enabled going forward.
Cheers
Jon
--
nvpublic
* @dnode: address of destination node
Acked-by: Jon Maloy
_timers.part.0+0x2bc/0x370
> > > > > [ 714.465578] run_timer_softirq+0x48/0x80
> > > > > [ 714.465583] __do_softirq+0x120/0x36c
> > > > > [ 714.465589] irq_exit+0xac/0x100
> > > > > [ 714.465596] __handle_domain_irq+0x8c/0xf0
> >
Given it is the iommu code that is provoking the warning I should
> > probably mention that the board I have requires
> > arm-smmu.disable_bypass=0 on the kernel command line in order to boot.
> > Also if it matters I am running the latest firmware from Solidrun
> > whic
have been working with Calvin over the past week and a half and the new
patchset will be submitted early next week most likely.
-Jon
>
> Andrew
te error: value doesn't fit into mask
__field_overflow(); \
^~
./include/linux/bitfield.h:151:2: note: in expansion of macro ‘MAKE_OP’
MAKE_OP(u##size,u##size,,)
^~~
./include/linux/bitfield.h:154:1: note: in expansion of macro ‘__MAKE_OP’
__MAKE_OP(32)
^
Cheers
Jon
--
nvpublic
On 10/9/20 12:12 AM, Hoang Huu Le wrote:
Hi Jon, Jakub,
I tried with your comment. But looks like we got into circular locking and
deadlock could happen like this:
CPU0CPU1
lock(&n->
ipc_named_dequeue() is called, and the same lock is
accessible from no.c where node_lost_contact() is executed. The patch
and the code becomes simpler.
I suggest you post a v2 of this one.
///jon
/* Abort any ongoing link failover */
for (i = 0; i < MAX_BEARERS; i++) {
eir children. This works okay
for enumeration and parenting but how do they talk?
This is where 2) comes into play. The big problem is that MDIO isn't
designated as a SPB
(https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/simple-peripheral-bus--spb-)
We have GPIO, I2C, SPI, UART, MIPI and a couple of others. While not
a silver bullet I think getting MDIO added to the spec would be the
next step forward to being able to implement this in Linux with
phylink / phylib in a sane manner. Currently SFP definitions are
using the SPB to designate the various GPIO and I2C interfaces that
are needed to probe devices and handle interrupts.
The other alternatives is the ACPI maintainers agree on the _DSD
method (would be quickest and should be easy to migrate to SBP if MDIO
were adopter), or nothing is done at all (which I know seems to be a
popular opinion).
-Jon
ould be wrong, but are Ethernet switches something you expect
> to see on ACPI/SBSA platforms? Or is this a legitimate use of the
> escape hatch?
I think with the rise in adoption of Smart-NICs in datacenters there
will definitely be a lot more crossover between ACPI/SBSA and network
appliance oriented hardware.
-Jon
On 7/12/20 7:15 PM, Andrew Lunn wrote:
Simple fixes which require no deep knowledge of the code.
Cc: Jon Maloy
Cc: Ying Xue
Signed-off-by: Andrew Lunn
---
net/tipc/bearer.c| 2 +-
net/tipc/discover.c | 5 ++---
net/tipc/link.c | 6 +++---
net/tipc/msg.c | 2 +-
net
L);
- print_uint(PRINT_ANY, "ratio", " ratio:%u%\n",
+ print_uint(PRINT_ANY, "ratio", " ratio:%u\n",
mnl_attr_get_u32(props[prop_ratio]));
break;
default:
Acked-by: Jon Maloy
we add another 'is_not_legacy' bit
to all new messages so that those can be distinguished from legacy
messages and the latter delivered directly.
Signed-off-by: Hoang Huu Le
Acked-by: Jon Maloy
---
net/tipc/bcast.c | 6 +--
net/tipc/bcast.h | 4 +-
net/tipc/l
On 5/22/20 4:10 PM, Eric Dumazet wrote:
On 5/22/20 12:47 PM, Jon Maloy wrote:
On 5/22/20 11:57 AM, Eric Dumazet wrote:
On 5/22/20 8:01 AM, Jon Maloy wrote:
On 5/22/20 2:18 AM, Xin Long wrote:
On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote:
Resend to the list in non HTML form
On
On 5/22/20 11:57 AM, Eric Dumazet wrote:
On 5/22/20 8:01 AM, Jon Maloy wrote:
On 5/22/20 2:18 AM, Xin Long wrote:
On Fri, May 22, 2020 at 1:55 PM Eric Dumazet wrote:
Resend to the list in non HTML form
On Thu, May 21, 2020 at 10:53 PM Eric Dumazet wrote:
On Thu, May 21, 2020 at 10
eally worth using dst_cache here.
Also add tipc-discussion and Jon to CC list.
The suggested solution will affect all bearers, not only UDP, so it is
not a good.
Is there anything preventing us from disabling preemtion inside the
scope of the rcu lock?
///jon
Thanks.
have you checked other p
Acked. Thanks Jiri.
///jon
> -Original Message-
> From: Jiri Pirko
> Sent: 8-Oct-19 07:02
> To: netdev@vger.kernel.org
> Cc: da...@davemloft.net; Jon Maloy ;
> ying@windriver.com; johannes.b...@intel.com; mkube...@suse.cz;
> ml...@mellanox.com
> Subject: [p
s
where we incorrectly access the spinlock on the send/error path.
This patch also reverts commit d12cffe9329f ("tipc: ensure head->lock
is initialised") which has now become redundant.
CC: Eric Dumazet
Reported-by: Chris Packham
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Xin Long
> Sent: 15-Aug-19 01:58
> To: Jon Maloy
> Cc: da...@davemloft.net; netdev@vger.kernel.org; Tung Quang Nguyen
> ; Hoang Huu Le
> ; shu...@redhat.com; ying xue
> ; eduma...@
s
where we incorrectly access the spinlock on the send/error path.
This patch also reverts commit d12cffe9329f ("tipc: ensure head->lock
is initialised") which has now become redundant.
CC: Eric Dumazet
Reported-by: Chris Packham
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
ne
ther
down in tipc_sk_filter_rcv() as it should be.
Reported-by: Li Shuang
Signed-off-by: Jon Maloy
---
net/tipc/socket.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index dd8537f..83ae41d 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket
e risk of user starvation during link congestion")
Reported-by: Tung Nguyen
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/link.c | 29 +
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 2c27477..dd3155
t the packet is erroneously perceived as already validated by TIPC.
We fix this by initializing the said field to 'false' before performing
the initial validation.
Signed-off-by: Jon Maloy
---
net/tipc/node.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tipc/node.c b/net/
The macro TIPC_BC_RETR_LIM is always used in combination with 'jiffies',
so we can just as well perform the addition in the macro itself. This
way, we get a few shorter code lines and one less line break.
Signed-off-by: Jon Maloy
---
net/tipc/link.c | 9 -
1 file changed, 4
We rename the inline function msg_get_wrapped() to the more
comprehensible msg_inner_hdr().
Signed-off-by: Jon Maloy
---
net/tipc/bcast.c | 4 ++--
net/tipc/link.c | 2 +-
net/tipc/msg.h | 4 ++--
net/tipc/node.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net
We increase the allocated headroom for the buffer copies to be
retransmitted. This eliminates the need for the lower stack levels
(UDP/IP/L2) to expand the headroom in order to add their own headers.
Signed-off-by: Jon Maloy
---
net/tipc/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
e original, additional criteria of 99 failed retransmissions
is now redundant, and may in some cases lead to failure detection
times in the order of minutes instead of the expected 1.5 sec link
tolerance value.
We now remove this criteria altogether.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
s and
> > send the clones to the loopback interface. The clones are dropped at
> > reception and have no functional role except making the traffic visible.
> >
> > The feature is turned on/off by enabling/disabling the loopback "bearer"
> > "eth:lo"
Acked-by: Jon Maloy
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Xin Long
> Sent: 20-Jun-19 07:04
> To: network dev
> Cc: da...@davemloft.net; Jon Maloy ; Ying Xue
> ; tipc-discuss...@lists.sourceforge.net; Paolo
> Abeni
> Sub
Acked-by: Jon Maloy
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Xin Long
> Sent: 20-Jun-19 06:39
> To: network dev
> Cc: da...@davemloft.net; Jon Maloy ; Ying Xue
> ; tipc-discuss...@lists.sourceforge.net
> Subject: [PATCH
Yet another duplicate of syzbot+a25307ad099309f1c...@syzkaller.appspotmail.com
A fix has been posted.
///jon
> -Original Message-
> From: netdev-ow...@vger.kernel.org
> On Behalf Of syzbot
> Sent: 23-Mar-19 19:03
> To: da...@davemloft.net; Jon Maloy ;
> kuz...@ms
From: Erik Hugne
Fix regression bug introduced in
commit 365ad353c256 ("tipc: reduce risk of user starvation during link
congestion")
Only signal -EDESTADDRREQ for RDM/DGRAM if we don't have a cached
sockaddr.
Signed-off-by: Erik Hugne
Signed-off-by: Jon Maloy
---
net/ti
Acked-by: Jon Maloy
Thank you, Cong.
///jon
> -Original Message-
> From: Cong Wang
> Sent: 17-Dec-18 02:25
> To: netdev@vger.kernel.org
> Cc: Cong Wang ; Ying Xue
> ; Jon Maloy
> Subject: [Patch net] tipc: check group dests after tipc_wait_for_cond()
&
> -Original Message-
> From: netdev-ow...@vger.kernel.org
> On Behalf Of Eric Dumazet
> Sent: 14-Dec-18 10:15
> To: Jon Maloy ; Cong Wang
> ; Dmitry Vyukov
> Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Ying Xue
> ; tipc-discuss...@lists.sourcef
> -Original Message-
> From: Cong Wang
> Sent: 12-Dec-18 01:17
> To: Dmitry Vyukov
> Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Jon Maloy
> ; Ying Xue ; tipc-
> discuss...@lists.sourceforge.net; David Miller ;
> Alexey Kuznetsov ; LKML ker...
> -Original Message-
> From: Dmitry Vyukov
> Sent: 13-Dec-18 04:47
> To: Jon Maloy
> Cc: syzbot+9845fed98688e01f4...@syzkaller.appspotmail.com; David Miller
> ; LKML ; netdev
> ; syzkaller-bugs b...@googlegroups.com>; tipc-discuss...@lists.sourceforge.net; Y
> -Original Message-
> From: Dmitry Vyukov
> Sent: 12-Dec-18 06:03
> To: syzbot+aab62b9c7b12e7c6a...@syzkaller.appspotmail.com; Jon Maloy
> ; Ying Xue ; David
> Miller ; tipc-discuss...@lists.sourceforge.net
> Cc: Alexey Kuznetsov ; LKML ker...@vger.kernel.org>;
> -Original Message-
> From: syzbot
> Sent: 12-Dec-18 06:11
> To: da...@davemloft.net; Jon Maloy ; linux-
> ker...@vger.kernel.org; netdev@vger.kernel.org; syzkaller-
> b...@googlegroups.com; tipc-discuss...@lists.sourceforge.net;
> ying@windriver.com
> S
> -Original Message-
> From: Cong Wang
> Sent: 10-Dec-18 18:24
> To: netdev@vger.kernel.org
> Cc: Cong Wang ; Ying Xue
> ; Jon Maloy
> Subject: [Patch net] tipc: compare remote and local protocols in
> tipc_udp_enable()
>
> When TIPC_NLA_UDP_REMOT
Acked.
Thank you for both your quick fixes, Cong.
///jon
> -Original Message-
> From: Cong Wang
> Sent: 10-Dec-18 15:46
> To: netdev@vger.kernel.org
> Cc: Cong Wang ; Ying Xue
> ; Jon Maloy
> Subject: [Patch net] tipc: fix a double kfree_skb()
>
> tipc_udp
timer cleanup function use spin_trylock()
instead of just spin_lock(), and when it fails to grab the lock it
just returns so that the timer handler can terminate its execution.
This is safe to do, since tipc_node_stop() anyway is about to
delete both the timer and the node instance.
Fixes: 6a939f36
Acked-by: Jon Maloy
///jon
> -Original Message-
> From: Ying Xue
> Sent: October 11, 2018 7:58 AM
> To: Jon Maloy ; dvyu...@google.com
> Cc: da...@davemloft.net; parthasarathy.bhuvara...@ericsson.com;
> netdev@vger.kernel.org; linux-ker...@vger.kernel.or
Hi Dmitry,
Yes, we are aware of this, the kernel test robot warned us about this a few
days ago.
I am looking into it.
///jon
> -Original Message-
> From: Dmitry Vyukov
> Sent: October 11, 2018 3:55 AM
> To: parthasarathy.bhuvara...@ericsson.com; Jon Maloy
> ; David Mi
surdly large :) to present a compelling
argument in one direction or another. As far as I know there aren't
currently any NAPI related ethtool commands (based on a quick perusal
of ethtool.h) -- it seems like it would be fairly involved/heavyweight
to plumb one solely for this unless NAPI Tx is something many users
will want to tune (and for which other drivers would support tuning).
--
Jon Olson
Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path.
Otherwise we get splats when tc mirred is used to redirect packets to ifb.
Before fix:
nic: hw csum failure
Signed-off-by: Jon Maxwell
---
drivers/net/ifb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
> -Original Message-
> From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com]
> Sent: Wednesday, May 23, 2018 9:37 AM
> To: Jon Rosen (jrosen)
> Cc: David S. Miller ; Willem de Bruijn
> ; Eric Dumazet
> ; Kees Cook ; David Windsor
> ; Rosen,
&
> > For the ring, there is no requirement to allocate exactly the amount
> > specified by the user request. Safer than relying on shared memory
> > and simpler than the extra allocation in this patch would be to allocate
> > extra shadow memory at the end of the ring (and not mmap that).
> >
> > Th
> >>> I think the bigger issues as you've pointed out are the cost of
> >>> the additional spin lock and should the additional state be
> >>> stored in-band (fewer cache lines) or out-of band (less risk of
> >>> breaking due to unpredictable application behavior).
> >>
> >> We don't need the spinlo
On Monday, May 21, 2018 2:17 PM, Jon Rosen (jrosen) wrote:
> On Monday, May 21, 2018 1:07 PM, Willem de Bruijn
> wrote:
>> On Mon, May 21, 2018 at 8:57 AM, Jon Rosen (jrosen) wrote:
...snip...
>>
>> A setsockopt for userspace to signal a stricter interpretation of
&
On Monday, May 21, 2018 1:07 PM, Willem de Bruijn
wrote:
>On Mon, May 21, 2018 at 8:57 AM, Jon Rosen (jrosen) wrote:
>> On Sunday, May 20, 2018 7:22 PM, Willem de Bruijn
>> wrote:
>>> On Sun, May 20, 2018 at 6:51 PM, Willem de Bruijn
>>> wrote:
>>>&g
On Sunday, May 20, 2018 7:22 PM, Willem de Bruijn
wrote:
> On Sun, May 20, 2018 at 6:51 PM, Willem de Bruijn
> wrote:
>> On Sat, May 19, 2018 at 8:07 AM, Jon Rosen wrote:
>>> Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which
>>> casues the rin
> -Original Message-
> From: netdev-ow...@vger.kernel.org
> On Behalf Of David Miller
> Sent: Saturday, May 19, 2018 23:00
> To: ying@windriver.com
> Cc: netdev@vger.kernel.org; Jon Maloy ;
> syzkaller-b...@googlegroups.com; tipc-discuss...@lists.sourcefo
Forward link to a new proposed patch at:
https://www.mail-archive.com/netdev@vger.kernel.org/msg236629.html
x27;s fully filled in, passed to user space, and then
eventually passed back to the kernel for use with a new packet.
Signed-off-by: Jon Rosen
---
There is a bug in net/packet/af_packet.c:tpacket_rcv in how it manages
the PACKET_RX_RING for versions TPACKET_V1 and TPACKET_V2. This bug makes
it pos
from David Ahern
v3: Fixed leaking socket as per comment from David Ahern
Signed-off-by: Jon Maloy
---
tipc/misc.c | 20
tipc/misc.h | 1 +
tipc/nametable.c | 18 ++
tipc/node.c | 19 ---
tipc/peer.c | 4
5 files ch
David Ahern
Signed-off-by: Jon Maloy
---
tipc/misc.c | 18 ++
tipc/misc.h | 1 +
tipc/nametable.c | 18 ++
tipc/node.c | 19 ---
tipc/peer.c | 4
5 files changed, 41 insertions(+), 19 deletions(-)
diff --git a/tipc/
ginal sk->sk_mark in __inet_twsk_hashdance() to the new tw->tw_mark
location.
Then progate this so that the skb gets sent with the correct mark. Do the same
for resets. Give the "fwmark_reflect" sysctl precedence over sk->sk_mark so that
netfilter rules are still honored.
Sign
tw->tw_mark
location.
Then progate this so that the skb gets sent with the correct mark. Do the same
for resets. Give the "fwmark_reflect" sysctl precedence over sk->sk_mark so that
netfilter rules are still honored.
Signed-off-by: Jon Maxwell
---
include/net/inet_timewait_sock
k_mark so that netfilter rules are still honored.
Signed-off-by: Jon Maxwell
---
include/net/inet_timewait_sock.h | 1 +
net/ipv4/ip_output.c | 3 ++-
net/ipv4/tcp_ipv4.c | 18 --
net/ipv4/tcp_minisocks.c | 1 +
net/ipv6/tcp_ipv6.c
Acked-by: Jon Maloy
Thank you Eric.
> -Original Message-
> From: Eric Dumazet [mailto:eduma...@google.com]
> Sent: Wednesday, May 09, 2018 09:50
> To: David S . Miller
> Cc: netdev ; Eric Dumazet
> ; Eric Dumazet ; Jon
> Maloy ; Ying Xue
> Subject: [PATCH net]
kup the tipc_service
-> service_range -> publication items in the correct hierarchical
order.
In this commit we try to make this right, and as a side effect obtain
some code simplification.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/name_table.c | 103 ++-
ormer potentially is much
longer than the latter, we make room for it by eliminating the (to the
user) irrelevant publication key. We also reorder some of the columns
so that the node id comes last, since this looks nicer and more logical.
Signed-off-by: Jon Maloy
---
tipc/misc.c | 18
Acked-by: Jon Maloy
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Paolo Abeni
> Sent: Monday, May 07, 2018 06:06
> To: netdev@vger.kernel.org
> Cc: David S. Miller
> Subject: [PATCH net-next] flow_d
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, May 03, 2018 15:22
> To: syzbot+df0257c92ffd4fcc5...@syzkaller.appspotmail.com
> Cc: Jon Maloy ; linux-ker...@vger.kernel.org;
> netdev@vger.kernel.org; syzkaller-b...@goog
> -Original Message-
> From: Wenwen Wang [mailto:wang6...@umn.edu]
> Sent: Tuesday, May 01, 2018 00:26
> To: Wenwen Wang
> Cc: Kangjie Lu ; Jon Maloy ; Ying
> Xue ; David S. Miller ;
> open list:TIPC NETWORK LAYER ; open list:TIPC
> NETWORK LAYER ; open list
particularly useful when we extend some of the commands in the
'tipc' tool, but we also expect regular user applications to need
this feature.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc.h | 12
net/tipc/node.c | 21 +
he missing part.
Fixes: 36a50a989ee8 ("tipc: fix infinite loop when dumping link monitor
summary")
Signed-off-by: Jon Maloy
---
net/tipc/node.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 6f98b56..baaf93f 100644
--- a/n
. This solution also caters for the case
where there may be gaps in the bearer array.
Signed-off-by: Tung Nguyen
Signed-off-by: Jon Maloy
---
net/tipc/monitor.c | 2 +-
net/tipc/node.c| 11 ---
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/net/tipc/monitor.c b/net/
e delete of the service range item outside
the said function. Instead, we now let the two functions calling it
test if the list is empty and perform the removal when that is the
case.
Reported-by: syzbot+d64b64afc55660106...@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy
---
net/tipc/na
Acked-by: Jon Maloy
Thank you, Eric.
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Eric Dumazet
> Sent: Monday, April 16, 2018 11:30
> To: David S . Miller
> Cc: netdev ; Eric Dumazet
> ; Eric Dumaz
the named function if the given address
type is illegal.
Reported-by: syzbot+b0975ce9355b347c1...@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy
---
net/tipc/socket.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 1fd1c8b..252a5
plies
back to the commit shown below. Given the low risk of this happening
we believe this to be sufficient.
Fixes: commit 218527fe27ad ("tipc: replace name table service range
array with rb tree")
Reported-by: syzbot+aa245f26d42b8305d...@syzkaller.appspotmail.com
Signed-off-by: Jon
> -Original Message-
> From: Ying Xue [mailto:ying@windriver.com]
> Sent: Wednesday, April 11, 2018 06:27
> To: Jia-Ju Bai ; Jon Maloy
> ; da...@davemloft.net
> Cc: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux-
> ker...@vger.kernel.org
>
> >> >One issue with the above proposed change to use TP_STATUS_IN_PROGRESS
> >> >is that the documentation of the tp_status field is somewhat
> >> >inconsistent. In some places it's described as TP_STATUS_KERNEL(0)
> >> >meaning the entry is owned by the kernel and !TP_STATUS_KERN
On Wednesday, April 04, 2018 9:49 AM, Willem de Bruijn
wrote:
>
> On Tue, Apr 3, 2018 at 11:55 PM, Jon Rosen wrote:
> > Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which
> > casues the ring to get corrupted by allowing multiple kernel threads
> > t
> introduced in some previous kernel?
Sorry about the tabs, I'll fix that and try to figure out what I did wrong with
the signed-off-by.
I've looked back as far as I could find online (2.6.11) and it would appear that
this bug has always been there.
Thanks, jon.
work properly. More discussion on this
change can be found in the additional comments section titled
"3. Discussion on packet_mmap ownership semantics:".
Signed-off-by: Jon Rosen
---
Additional Comments Section
---
1. Descripti
#syz dup: general protection fault in __list_del_entry_valid (3)
> -Original Message-
> From: syzbot
> [mailto:syzbot+4859fe19555ea87c4...@syzkaller.appspotmail.com]
> Sent: Monday, April 02, 2018 02:01
> To: da...@davemloft.net; Jon Maloy ; linux-
> ker...@vger.
ation functions"), which is still in net-next.
We fix this for that commit by initializing the two lists properly.
Fixes: 242e82cc95f6 ("tipc: collapse subscription creation functions")
Reported-by: syzbot+0bb443b74ce09197e...@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy
---
net/tip
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of David Ahern
> Sent: Thursday, March 29, 2018 13:59
> To: Jon Maloy ; da...@davemloft.net;
> netdev@vger.kernel.org
> Cc: Mohan Krishna Ghanta Krishn
The function tipc_nametbl_translate() function is ugly and hard to
follow. This can be improved somewhat by introducing a stack variable
for holding the publication list to be used and re-ordering the if-
clauses for selection of algorithm.
Signed-off-by: Jon Maloy
---
net/tipc/name_table.c
safe side we also replace the sprintf() call with
snprintf().
Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address
hash values")
Reported-by: Arnd Bergmann
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc.h | 2 +-
net/tipc/link.c | 3 ++-
2 files changed, 3
improving cache hit rate.
Signed-off-by: Jon Maloy
---
net/tipc/core.h |1 +
net/tipc/link.c |2 +-
net/tipc/name_table.c | 1032 ++---
net/tipc/name_table.h |2 +-
net/tipc/node.c |4 +-
net/tipc/subscr.h |4
ication/withdrawal item
from a peer node never will be rejected, and make it possible to
eliminate the problematic backlog functionality we currently have for
handling such cases.
Signed-off-by: Jon Maloy
---
net/tipc/name_distr.c | 90 +--
ed-off-by: Jon Maloy
---
include/uapi/linux/tipc.h | 57 +++
1 file changed, 33 insertions(+), 24 deletions(-)
diff --git a/include/uapi/linux/tipc.h b/include/uapi/linux/tipc.h
index 4ac9f1f..156224a 100644
--- a/include/uapi/linux/tipc.h
+++ b/inc
replaced a few more macros to get a consistent
terminology in the API.
#5: Added new commit to fix a potential string overflow bug (it
is still only in net-next) reported by Arnd Bergmann
Jon Maloy (5):
tipc: replace name table service range array with rb tree
tipc: ref
same operations. For compatibility the old 'netid' commands are
retained, -we just remove them from the help texts.
Acked-by: GhantaKrishnamurthy MohanKrishna
Signed-off-by: Jon Maloy
---
include/uapi/linux/tipc_netlink.h | 2 +
tipc/misc.c | 78 ++
1: We introduce ability to set/get 128-bit node identities
2: We rename 'net id' to 'cluster id' in the command API,
of course in a compatible way.
3: We print out all 32-bit node addresses as an integer in hex format,
i.e., we remove the assumption about an internal s
1 - 100 of 757 matches
Mail list logo
