[PATCH] igb: Debugging for setting rate negotiation settings.

2019-04-02 Thread greearb
From: Ben Greear I found this useful while debugging an issue setting igb to fixed rates. Signed-off-by: Ben Greear --- drivers/net/ethernet/intel/igb/igb_main.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/d

[PATCH v2] net-fq: Add WARN_ON check for null flow.

2018-06-07 Thread greearb
From: Ben Greear While testing an ath10k firmware that often crashed under load, I was seeing kernel crashes as well. One of them appeared to be a dereference of a NULL flow object in fq_tin_dequeue. I have since fixed the firmware flaw, but I think it would be worth adding the WARN_ON in case

[PATCH] net-fq: Add WARN_ON check for null flow.

2018-06-07 Thread greearb
From: Ben Greear While testing an ath10k firmware that often crashed under load, I was seeing kernel crashes as well. One of them appeared to be a dereference of a NULL flow object in fq_tin_dequeue. I have since fixed the firmware flaw, but I think it would be worth adding the WARN_ON in case

[PATCH v2 3/3] ath10k: Support ethtool gstats2 API.

2018-04-19 Thread greearb
From: Ben Greear Skip a firmware stats update when calling code indicates the stats refresh is not needed. Signed-off-by: Ben Greear --- v2: Convert to new flag name, attempt to fix build when there is not DEBUGFS enabled for ath10k. drivers/net/wireless/ath/ath10k/debug.c | 18 +

[PATCH v2 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-19 Thread greearb
From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify flags. These flags can be used by the driver to decrease the amount of stats refreshed. In particular, this helps with ath10k since getting the firmware stats can be slow. Signed-off-by: Ben Greear --- v2: Chan

[PATCH v2 2/3] mac80211: Add support for ethtool gstats2 API.

2018-04-19 Thread greearb
From: Ben Greear This enables users to request fewer stats to be refreshed in cases where firmware does not need to be probed. Signed-off-by: Ben Greear --- v2: No changes. include/net/mac80211.h| 6 ++ net/mac80211/driver-ops.h | 9 +++-- net/mac80211/ethtool.c| 18 ++

[PATCH] net: Work around crash in ipv6 fib-walk-continue

2018-04-19 Thread greearb
From: Ben Greear This keeps us from crashing in certain test cases where we bring up many (1000, for instance) mac-vlans with IPv6 enabled in the kernel. This bug has been around for a very long time. Until a real fix is found (and for stable), maybe it is better to return an incomplete fib wal

[PATCH 2/3] mac80211: Add support for ethtool gstats2 API.

2018-04-17 Thread greearb
From: Ben Greear This enables users to request fewer stats to be refreshed in cases where firmware does not need to be probed. Signed-off-by: Ben Greear --- include/net/mac80211.h| 6 ++ net/mac80211/driver-ops.h | 9 +++-- net/mac80211/ethtool.c| 18 +- 3 fil

[PATCH] ethtool: Support ETHTOOL_GSTATS2 API.

2018-04-17 Thread greearb
From: Ben Greear This allows users to specify flags to the get-stats API, potentially saving expensive stats queries when they are not desired. Signed-off-by: Ben Greear --- ethtool-copy.h | 9 + ethtool.c | 25 - 2 files changed, 29 insertions(+), 5 delet

[PATCH 3/3] ath10k: Support ethtool gstats2 API.

2018-04-17 Thread greearb
From: Ben Greear Skip a firmware stats update when calling code indicates the stats refresh is not needed. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/debug.c | 18 +++--- drivers/net/wireless/ath/ath10k/debug.h | 4 drivers/net/wireless/ath/ath10k/mac.c |

[PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-17 Thread greearb
From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify flags. These flags can be used by the driver to decrease the amount of stats refreshed. In particular, this helps with ath10k since getting the firmware stats can be slow. Signed-off-by: Ben Greear --- include/l

[RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-07 Thread greearb
From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify a 'level'. This level can be used by the driver to decrease the amount of stats refreshed. In particular, this helps with ath10k since getting the firmware stats can be slow. Signed-off-by: Ben Greear --- NOTE:

[PATCH v2] ethtool: Do not return error code if no changes were attempted.

2017-10-19 Thread greearb
From: Ben Greear This makes it easier to properly handle errors when calling this from scripts, etc. Old behaviour: $ ethtool -L eth3 combined 1 combined unmodified, ignoring no channel parameters changed, aborting current values: tx 0 rx 0 other 1 combined 1 [root@lf0313-6477 ethtool]# echo $?

[PATCH] ethtool: Do not return error code if no changes were attempted.

2017-10-19 Thread greearb
From: Ben Greear This makes it easier to properly handle errors when calling this from scripts, etc. Old behaviour: combined unmodified, ignoring no channel parameters changed, aborting current values: tx 0 rx 0 other 1 combined 1 [root@lf0313-6477 ethtool]# echo $? 1 New behaviour: combined

[PATCH] Fix build on fedora-14 (and other older systems)

2017-09-02 Thread greearb
From: Ben Greear Seems Fedora-20 and below fail, hopefully this fixes them. Signed-off-by: Ben Greear --- include/linux/sysinfo.h | 8 ip/ipxfrm.c | 1 + ip/xfrm_policy.c| 1 + ip/xfrm_state.c | 1 + 4 files changed, 11 insertions(+) diff --git a/include/l

[PATCH] igb: add module param to set max-rss-queues.

2017-03-24 Thread greearb
From: Ben Greear In systems where you may have a very large number of network adapters, certain drivers may consume an unfair amount of IRQ resources. So, allow a module param that will limit the number of IRQs at driver load time. This way, other drivers (40G Ethernet, for instance), which pro

[PATCH-v2 2/2] mac80211: ensure association req uses configured ratemask.

2015-10-20 Thread greearb
From: Ben Greear When sending the association request, pay attention to the legacy rates configured by the user, and do not advertise support for any that are not configured. This makes the assoc request packet look more correct when making modern hardware act like a /b mode station, for instanc

[PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

2015-10-20 Thread greearb
From: Ben Greear If a user restricts the rateset for some reason, then the probe requests should not advertise rates that are not selected by the user. To implement this, we save the requested bitrates at the mac80211 level and take it into account when building the IEs. This allows one to crea