Re: ax25: fix possible use-after-free

2019-02-17 Thread f6bvp
the full path in order to satisfy functions declarations. #include Thank you for your help in understanding the issue. Bernard > Le 17 févr. 2019 à 19:39, Eric Dumazet a écrit : > > > >> On 02/16/2019 02:33 PM, f6bvp wrote: >> >> Patch applied successfull

ax25: fix possible use-after-free

2019-02-16 Thread f6bvp
Patch applied successfully on Linux draws-f6bvp 4.14.79-v7+ #1159 SMP Sun Nov 4 17:50:20 GMT 2018 armv7l GNU/Linux However ax25_route_lock_use and ax25_route_lock_unuse() are not declared and compile failed. make : on entre dans le répertoire « /usr/src/linux-headers-4.14.79-v7+ » CC [M

[ROSE] Bug : waiting for rose module to become free

2019-02-16 Thread f6bvp
DCE yes 0 0 7 F3KT-11 ax0 2 1 DCE yes 0 0 3 SK7ES-9 ax0 2 1 DTE yes 0 0 2 K4GBB-9 ax0 4 0 DCE yes 0 0 1 RSLOOP-0 ??? 1 2 DCE yes 0 0 Help is kindly requested to get a valid patch. Bernard, f6bvp

Re: [PATCH] NET:AX25:ROSE NULL ax25_cb kernel panic

2019-01-20 Thread f6bvp
Vyukov a écrit : > On Sun, Jan 20, 2019 at 10:58 AM f6bvp wrote: >> >> Hi, >> >> Dmitry wrote: >> >>> Please also add: >>> Reported-by: syzbot+1a2c456a1ea08fa5b...@syzkaller.appspotmail.com >> >> I did mention syzbot report but with

Re: [PATCH] NET:AX25:ROSE NULL ax25_cb kernel panic

2019-01-20 Thread f6bvp
0e2f1c91d8e6e5725 Yes exactly ! This is a long date well know bug I reported two years ago. Bernard On Sat, Jan 19, 2019 at 11:58 AM f6bvp wrote: > > > [PATCH] [ROSE] NULL ax25_cb kernel panic > > When an internally generated frame is handled by rose_xmit(), > rose_rout

[PATCH] NET:AX25:ROSE NULL ax25_cb kernel panic

2019-01-19 Thread f6bvp
] << 0) & 0x0FF); if (frametype == ROSE_CALL_REQUEST && Signed-off-by: Bernard Pidoux, f6bvp

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-11-08 Thread f6bvp
Hi all, I just want to report that I applied the NetRom patch to most recent kernel. NetRom does not seem to be affected and connexion is doing well between my FPAC node f6bvp and f3kt. 73 de Bernard f6bvp Sent from my iPhone > Le 29 oct. 2017 à 05:15, David Ranch a écrit : > >

[PATCH 3/6]NET:AX25:ROSE Traps calls to rose_route_frame with a NULL ax25 callback

2016-08-14 Thread f6bvp
Hi Richard, Thanks for this patch and all others for ROSE code you sent recently. I already committed a similar one in february 2016. Subject: [Patch] rose_route_frame() NULL pointer dereference kernel panic From: f6bvp Date: Wed, 24 Feb 2016 17:53:11 +0100 Cc: Ralf Baechle , "&

Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic

2016-03-06 Thread f6bvp
François, Thank you for providing information about rose_rebuild_header history. I was not able to find Jonathan Naylor G4KLX email. However as rose_xmit() has been recently changed by Eric Biederman, he may have more precise information about rose_route_frame() NULL argument. Meanwhile, I browse

Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic

2016-03-05 Thread f6bvp
Le 05/03/2016 17:22, David Miller a écrit : > From: f6bvp > Date: Sat, 5 Mar 2016 16:32:42 +0100 > >> I understand I did not explain clearly or completely things. >> >> I agree that each time patched rose_xmit() is calling >> rose_route_frame() it will >>

Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic

2016-03-05 Thread f6bvp
frames into UDP frames via ax25ipd daemon. First, I set ax25ipd configuration with a rose neighbour with a local network address. # Route HAMNET # F6BVP-10/11 route f6bvp-10 44.168.19.19 udp 10093 route f6bvp-11 44.168.19.19 udp 10093 b # kernel route looks like: Destination Passerelle

Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic

2016-03-01 Thread f6bvp
Hi David, Ralf, David is absolutely right about my unappropriate patch. Although I had searched functions calling rose_route_frame(), I did not notice rose_xmit() was involved. Shame on me ! Then, David precisely located the source of the issue we are facing. When rose_xmit() calls rose_route_f

[Patch] rose_route_frame() NULL pointer dereference kernel panic

2016-02-24 Thread f6bvp
[Patch] Null pointer in rose_route_frame() Bug appears when setting a second IP to ethernet device without adding a route and a gateway: /sbin/ifconfig enp4s0:1 44.168.19.22 netmask 255.255.255.240 If a route and a gateway are not added for subnet, and if ax25ipd configuration includes a destin

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-10 Thread Bernard Pidoux F6BVP
ROSE driver nor application. I will try your new patch version 2 and report any possible change. Regards, Bernard Pidoux, F6BVP Jarek Poplawski wrote: On Sat, Feb 09, 2008 at 07:44:50PM +0100, Bernard Pidoux F6BVP wrote: Hi, With AX25 patches applied I still get this possible circular

[PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-09 Thread Bernard Pidoux F6BVP
Hi, With AX25 patches applied I still get this possible circular locking message. Regards, Bernard P. === [ INFO: possible circular locking dependency detected ] 2.6.24 #3 --- swapper/

Re: [PATCH][ROSE][AX25] af_ax25: possible circular locking

2008-01-12 Thread Bernard Pidoux F6BVP
Jarek Poplawski wrote: On Thu, Jan 10, 2008 at 09:22:42PM -0800, David Miller wrote: From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Sun, 30 Dec 2007 15:13:23 +0100 On Sat, Dec 29, 2007 at 07:14:43PM -0800, David Miller wrote: ... I've removed the warning and made the branch back to 'again

[PATCH] [ROSE] two extra tab characters removed

2008-01-11 Thread Bernard Pidoux F6BVP
Signed-off-by: Bernard Pidoux <[EMAIL PROTECTED]> --- include/net/rose.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/rose.h b/include/net/rose.h index d3ab453..0cfdc0e 100644 --- a/include/net/rose.h +++ b/include/net/rose.h @@ -86,7 +86,7 @@ struct ro

[BUG] [ROSE] [AX25] system impossible to reboot with linux-2.6.24-rc5

2007-12-17 Thread Bernard Pidoux F6BVP
Hi, I am running a packet switch application using AX25, mkiss and ROSE modules (FPAC). It runs for days without problems when the patch I recently sent to this list are applied. However, if I try to shutdown linux-2.6.24-rc5 it goes into an infinite loop displaying the following message aga

[ROSE] [AX25] possible circular locking

2007-12-17 Thread Bernard Pidoux F6BVP
Hi, When I killall kissattach I can see the following message. This happens on kernel 2.6.24-rc5 already patched with the 6 previously patches I sent recently. === [ INFO: possible circular locking dependency detected ] 2.6.23.9 #1 -