RE: [ PATCH v1 2/2] ibmveth: Identify ingress large send packets.

2020-10-12 Thread dwilder
On 2020-10-11 11:31, Jakub Kicinski wrote: On Sat, 10 Oct 2020 12:51:30 -0400 Willem de Bruijn wrote: > > @@ -1385,7 +1386,17 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) > > skb_put(skb, length); > > skb->protocol = eth_type_t

RE: [(RFC) PATCH ] NULL pointer dereference on rmmod iptable_mangle.

2020-06-15 Thread dwilder
On 2020-06-15 04:44, Florian Westphal wrote: Florian Westphal wrote: dwilder wrote: > > Since the netns core already does an unconditional synchronize_rcu after > > the pre_exit hooks this would avoid the problem as well. > > Something like this? (un-tested) Yes. >

RE: [(RFC) PATCH ] be2net: Allow a VF to use physical link state.

2020-06-10 Thread dwilder
On 2020-06-09 14:58, Jakub Kicinski wrote: On Mon, 8 Jun 2020 17:00:59 -0700 David Wilder wrote: Hyper-visors owning a PF are allowed by Emulex specification to provide a VF with separate physical and/or logical link states. However, on linux, a VF driver must chose one or the other. My scena

RE: [(RFC) PATCH ] NULL pointer dereference on rmmod iptable_mangle.

2020-06-03 Thread dwilder
On 2020-06-03 15:05, Florian Westphal wrote: David Wilder wrote: This crash happened on a ppc64le system running ltp network tests when ltp script ran "rmmod iptable_mangle". [213425.602369] BUG: Kernel NULL pointer dereference at 0x0010 [213425.602388] Faulting instruction address: 0xc00

[patch] netlink.7: srcfix Change buffer size in example code about reading netlink message.

2016-11-14 Thread dwilder
The example code in netlink(7) (for reading netlink message) suggests using a 4k read buffer with recvmsg. This can cause truncated messages on systems using a page size is >4096. Please see: linux/include/linux/netlink.h (in the kernel source) /* * skb should fit one page. This choice

Re: Double free of dst_entry in ipv4_dst_destroy()

2015-12-14 Thread dwilder
Eric - With this patch applied the test ran clean for 2 days. Thanks for your help. Quoting Eric Dumazet : On Fri, 2015-12-11 at 07:48 -0800, Eric Dumazet wrote: On Fri, 2015-12-11 at 06:23 -0800, Eric Dumazet wrote: > On Sun, 2015-12-06 at 17:58 -0800, Eric Dumazet wrote: > > On Sun, 2015-12

Double free of dst_entry in ipv4_dst_destroy()

2015-12-06 Thread dwilder
Hi- I am seeing a crash on a distro V4.2.3 kernel caused by a double release of a dst_entry. In ipv4_dst_destroy() the call to list_empty() finds a poisoned next pointer, indicating the dst_entry has already been removed from the list and freed. The crash occurs 18 to 24 hours into a r