RE: [PATCH v6 net-next 11/14] virtio_net: Accurate ECN flag in virtio_net_hdr

>From: Jason Wang >Sent: Monday, December 30, 2024 8:52 AM >To: Chia-Yu Chang (Nokia) >Cc: netdev@vger.kernel.org; dsah...@gmail.com; da...@davemloft.net; >eduma...@google.com; dsah...@kernel.org; pab...@redhat.com; >joel.grana...@kernel.org; k...@kernel.org; andrew+ne

[PATCH v6 net-next 13/14] tcp: add new TCP_TW_ACK_OOW state and allow ECN bits in TOS

fix TOS value in ACK messages sent from TIME_WAIT") did not clean ECN bits of ACKs for oow data or paws_reject. But now the ECN bits rae cleaned for these ACKs. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang --- include/net/tcp.h| 3 ++- net/ipv4/ip_output.c

[PATCH v6 net-next 10/14] net: hns3/mlx5e: avoid corrupting CWR flag when receiving GRO packet

From: Chia-Yu Chang In Accurate ECN, ACE counter (AE, ECE, CWR flags) changes only when new CE packets arrive, while setting SKB_GSO_TCP_ECN in case of not knowing the ECN variant can result in header change that corrupts the ACE field. The new flag SKB_GSO_TCP_ACCECN is to prevent

[PATCH v6 net-next 14/14] tcp: Pass flags to __tcp_send_ack

From: Ilpo Järvinen Accurate ECN needs to send custom flags to handle IP-ECN field reflection during handshake. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang Reviewed-by: Eric Dumazet --- include/net/tcp.h | 2 +- net/ipv4/bpf_tcp_ca.c | 2 +- net/ipv4/tcp_dctcp.h | 2

[PATCH v6 net-next 11/14] virtio_net: Accurate ECN flag in virtio_net_hdr

From: Chia-Yu Chang Unlike RFC 3168 ECN, accurate ECN uses the CWR flag as part of the ACE field to count new packets with CE mark; however, it will be corrupted by the RFC 3168 ECN-aware TSO. Therefore, fallback shall be applied by seting NETIF_F_GSO_ACCECN to ensure that the CWR flag should

[PATCH v6 net-next 12/14] tcp: AccECN support to tcp_add_backlog

From: Ilpo Järvinen AE flag needs to be preserved for AccECN. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang Reviewed-by: Eric Dumazet --- net/ipv4/tcp_ipv4.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index

[PATCH v6 net-next 08/14] gso: AccECN support

should be evaluated per NIC basis (not done in this patch series for any NICs). For the cases, where TSO cannot keep its hands off the CWR flag, a GSO fallback is provided by this patch. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang Reviewed-by: Eric Dumazet --- incl

[PATCH v6 net-next 07/14] tcp: helpers for ECN mode handling

From: Ilpo Järvinen Create helpers for TCP ECN modes. No functional changes. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang Reviewed-by: Eric Dumazet --- include/net/tcp.h| 44 net/ipv4/tcp.c | 2 +- net/ipv4/tcp_dctcp.c

[PATCH v6 net-next 09/14] gro: prevent ACE field corruption & better AccECN handling

corrupting CWR flag somewhere. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang --- net/ipv4/tcp_offload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_offload.c b/net/ipv4/tcp_offload.c index 0b05f30e9e5f..f59762d88c38 100644 --- a/net/ipv4

[PATCH v6 net-next 04/14] tcp: extend TCP flags to allow AE bit/ACE field

ned-off-by: Chia-Yu Chang Reviewed-by: Eric Dumazet --- include/net/tcp.h | 11 +-- include/uapi/linux/tcp.h | 9 ++--- net/ipv4/tcp_ipv4.c | 2 +- net/ipv4/tcp_output.c | 8 net/ipv6/tcp_ipv6.c | 2 +- net/netfilter/nf_log_sys

[PATCH v6 net-next 06/14] tcp: rework {__,}tcp_ecn_check_ce() -> tcp_data_ecn_check()

eck rather than having the __ variant. No functional changes. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang Reviewed-by: Eric Dumazet --- net/ipv4/tcp_input.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_inp

[PATCH v6 net-next 05/14] tcp: reorganize SYN ECN code

From: Ilpo Järvinen Prepare for AccECN that needs to have access here on IP ECN field value which is only available after INET_ECN_xmit(). No functional changes. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang Reviewed-by: Eric Dumazet --- net/ipv4/tcp_output.c | 5 +++-- 1 file

[PATCH v6 net-next 03/14] tcp: use BIT() macro in include/net/tcp.h

From: Chia-Yu Chang Use BIT() macro for TCP flags field and TCP congestion control flags that will be used by the congestion control algorithm. No functional changes. Signed-off-by: Chia-Yu Chang Reviewed-by: Ilpo Järvinen Reviewed-by: Eric Dumazet --- include/net/tcp.h | 21

[PATCH v6 net-next 02/14] tcp: create FLAG_TS_PROGRESS

Järvinen Signed-off-by: Chia-Yu Chang Reviewed-by: Eric Dumazet --- net/ipv4/tcp_input.c | 37 - 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index f3691c1cdc83..eebe3a99aa90 100644 --- a/net/ipv4

[PATCH v6 net-next 01/14] tcp: reorganize tcp_in_ack_event() and tcp_count_delivered()

igned-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang --- net/ipv4/tcp_input.c | 56 +--- 1 file changed, 32 insertions(+), 24 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 5bdf13ac26ef..f3691c1cdc83 100644 --- a/net

[PATCH v6 net-next 00/14] AccECN protocol preparation patch series

From: Chia-Yu Chang Hello, Specific changes in v6 (27-Dec-2024) - Avoid removing removing the potential CA_ACK_WIN_UPDATE in ack_ev_flags of patch #1 (Eric Dumazet ) - Add reviewed-by tag in patches #2, #3, #4, #5, #6, #7, #8, #12, #14 - Foloiwng 2 new pathces are added after patch #9 (Patch

RE: [PATCH v5 net-next 09/13] gro: prevent ACE field corruption & better AccECN handling

>From: Jason Wang >Sent: Wednesday, November 13, 2024 2:43 AM >To: Ilpo Järvinen >Cc: Chia-Yu Chang (Nokia) ; Michael S. >Tsirkin ; virtualizat...@lists.linux.dev; Eric Dumazet >; netdev@vger.kernel.org; dsah...@gmail.com; >da...@davemloft.net; dsah...@kernel.o