Re: [PATCH 2/12] smc911x: Fix SMC_WRITE_EEPROM_CMD macro

s said, which one will be stay at the kernel, Dustin's or SMSC's? Because I have additional patches againist to in-kernel driver and maybe some more in the future. Our board is MIPS based. PS: I am happy if you send me your patches privately... -- Bora SAHIN - To unsubscribe from this

Re: [PATCH 12/12] smc911x: afc_cfg calculation is wrong at case 5

lp->afc_cfg=0x006E378F;break; > > Not your fault but the break statement is misplaced. Or one space ahead? like lp->afc_cfg=0x006E378F; break; -- Bora SAHIN - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH 12/12] smc911x: afc_cfg calculation is wrong at case 5

x006E378F;break; > > Not your fault but the break statement is misplaced. One line below? Thanks for all of your comments. I will create a new set of patches... -- Bora SAHIN - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 8/12] smc911x: Fix external phy detect routine

reading > > the same two PHY registers at PHY addresses 0x02 through 0x30. If values of > [...] > > - for (phyaddr = 1; phyaddr < 32; ++phyaddr) { > > + for (phyaddr = 2; phyaddr < 30; ++phyaddr) { > > Is 30 inclusive

Re: [PATCH 2/12] smc911x: Fix SMC_WRITE_EEPROM_CMD macro

#x27;s two different things. Just want to explain it. Do you think if I convert them(smc911x.h) to static inline, would that be correct? -- Bora SAHIN - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/12] smc911x: Fix SMC_WRITE_EEPROM_CMD macro

SMC_WRITE_EEPROM_CMD macro is wrong Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.h === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.h 2006-08-06 21:20:11.0 +0300 +++

[PATCH 4/12] smc911x: PRINT_PKT doesnt count on odd remainder

PRINT_PKT doesnt count on odd remainder... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0

[PATCH 5/12] smc911x: SMC_SET_IRQ_CFG is arch specific

SMC_SET_IRQ_CFG macro is PXA specific... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0 +0300 +++

[PATCH 12/12] smc911x: afc_cfg calculation is wrong at case 5

BACKDUR calculation is wrong at case 5. Also some cosmetic around smc911x_probe... AFC_HI is about ((Rx Data Fifo Size)*2/3)/64 AFC_LO is AFC_HI/2 BACK_DUR is about 5uS*(AFC_LO) rounded down Rx Data Fifo Size = 10560 AFC_HI = 110 AFC_LO = 55 BACK_DUR = 55 * 5 = 275 Signed-off-by: Bora Sahin

[PATCH 8/12] smc911x: Fix external phy detect routine

And according to the datasheet, waiting is needed when disabling clocks. Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06

[PATCH 9/12] smc911x: phy_check_media reverses MAC duplex settings

Datasheet says, page: 98 -> http://www.smsc.com/main/datasheets/9115.pdf "MAC_CR_RCVOWN_ should be reset when the Full Duplex Mode bit is set" and "When MAC_CR_FDPX_ set, the MAC operates in Full-Duplex mode, in which it can transmit and receive simultaneously." Si

[PATCH 3/12] smc911x: Use SET_ETHTOOL_OPS macro

Use SET_ETHTOOL_OPS macro... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0 +0300 +++ linux-2.6.

[PATCH 1/12] smc911x: Fix a few accessor SMC_* routines

When in 16 bit mode, SMC_outl incorrectly simulates the situation and plus in 32 bit mode SMC_outw is missing... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.h === --- linux-2.6.

[PATCH 10/12] smc911x: phy_configure releases spinlocks before grabing

phy_configure releases spinlocks before grabing... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0

[PATCH 6/12] smc911x: Unneeded spinlocks around smc911x_enable

smc911x_enable, which enables irqs as a last task, is called with irqs disabled. There is no any other concurrent access at that phase so spinlock protection is unneeded... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc

[PATCH 11/12] smc911x: Undocumented interrupt now reserved

In Rev B silicon #defineINT_STS_RXDF_INT_   (0x0040)  /* R/WC */ seems reserved. Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.

[PATCH 7/12] smc911x: Fix a few DBG macros

Some cosmetic around DBG macros... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0 +0300 +++

Re: [PATCH 1/11] smc911x: Fix accessor SMC_* routines

> When in 16 bit mode, SMC_outl incorrectly simulates the situation and plus in > 32 bit mode SMC_outw is missing... > [Snip] Because mailer wraps the lines patch is not applied. I pushed it by mistake... Sory for the inconsistencies. I'll cook up new series of patches... -- B

[PATCH 1/11] smc911x: Fix accessor SMC_* routines

When in 16 bit mode, SMC_outl incorrectly simulates the situation and plus in 32 bit mode SMC_outw is missing... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.h === --- linux-2.6.