Thanks Jeff for your advice,
Sorry for the my innocence as a Linux kernel rookie.
Zhouyi
On Thu, Dec 8, 2016 at 1:30 AM, Jeff Kirsher
wrote:
> On Wed, 2016-12-07 at 15:43 +0800, Zhouyi Zhou wrote:
>> Signed-off-by: Zhouyi Zhou
>> Reviewed-by: Cong Wang
>> Rev
return value of skb_linearize should be handled
Signed-off-by: Zhouyi Zhou
Reviewed-by: Cong Wang
Reviewed-by: Yuval Shaia
Reviewed-by: Eric Dumazet
---
net/tipc/link.c | 3 ++-
net/tipc/name_distr.c | 5 -
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/tipc
Signed-off-by: Zhouyi Zhou
Reviewed-by: Cong Wang
Reviewed-by: Yuval Shaia
Reviewed-by: Eric Dumazet
---
drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net
On Wed, Dec 7, 2016 at 1:02 PM, Cong Wang wrote:
> On Mon, Dec 5, 2016 at 11:10 PM, Zhouyi Zhou wrote:
>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
>> b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
>> index 2a653ec..ab787cb 100644
>> --- a/drive
kmalloc_reserve may fail to allocate memory inside skb_linearize,
which means skb_linearize's return value should not be ignored.
Following patch correct the uses of skb_linearize.
Compiled in x86_64
Signed-off-by: Zhouyi Zhou
---
drivers/infiniband/hw/nes/nes_nic.c
Thanks Pablo for reviewing
> From: "Pablo Neira Ayuso"
> Sent Time: Saturday, March 12, 2016
> To: "Zhouyi Zhou"
> On Sun, Feb 21, 2016 at 12:03:59AM +0800, Zhouyi Zhou wrote:
> > I think hackers chould build a malicious h323 packet to overflow
(iph->ih
and set addr functions.
Because the temporary h323 buffer is dynamiclly allocated, I remove
the h323 spin lock in my patch.
Signed-off-by: Zhouyi Zhou
---
include/linux/netfilter/nf_conntrack_h323.h | 17 +-
net/ipv4/netfilter/nf_nat_h323.c| 33 ++-
net/netfil
ted by Eric, this module is protected by a lock (nf_h323_lock)
so adding a variable h323_buffer_valid_bytes that would contain
the number of valid bytes would not require to change prototypes of
get_h2x5_addr.
Thanks Sergei for reviewing.
Signed-off-by: Zhouyi Zhou
---
net/netfil
ted by Eric, this module is protected by a lock (nf_h323_lock)
so adding a variable h323_buffer_valid_bytes that would contain
the number of valid bytes would not require to change prototypes of
get_h2x5_addr.
Signed-off-by: Zhouyi Zhou
---
net/netfilter/nf_conntrack_h323_main.c |
ble h323_buffer_valid_bytes that would contain
the number of valid bytes would not require to change prototypes of
get_h2x5_addr.
Signed-off-by: Zhouyi Zhou
---
net/netfilter/nf_conntrack_h323_main.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/net/netfil
ble h323_buffer_valid_bytes that would contain
the number of valid bytes would not require to change prototypes of
get_h2x5_addr.
Signed-off-by: Zhouyi Zhou
Signed-off-by: Eric Dumazet
Reviewed-by: Sergei Shtylyov
---
net/netfilter/nf_conntrack_h323_main.c | 13 +
1 file changed, 13 inserti
January 28, 2016
> To: "Zhouyi Zhou"
> Cc: eric.duma...@gmail.com, pa...@netfilter.org, ka...@trash.net,
> kad...@blackhole.kfki.hu, da...@davemloft.net,
> netfilter-de...@vger.kernel.org, coret...@netfilter.org,
> netdev@vger.kernel.org, linux-ker...@vger.kernel
Thanks Eric for replying
> -Original Messages-
> From: "Eric Dumazet"
> Sent Time: Thursday, January 28, 2016
> To: "Zhouyi Zhou"
> Cc: pa...@netfilter.org, ka...@trash.net, kad...@blackhole.kfki.hu,
> da...@davemloft.net, netfilter-de...@v
Thanks Eric for your review and advice.
I think hackers chould build a malicious h323 packet to overflow
the pointer p which will panic during the memcpy(addr, p, len)
For example, he may fabricate a very large taddr->ipAddress.ip;
Signed-off-by: Zhouyi Zhou
---
net/netfil
From: Zhouyi Zhou
I think hackers chould build a malicious h323 packet to overflow
the pointer p which will panic during the memcpy(addr, p, len)
For example, he may fabricate a very large taddr->ipAddress.ip;
Signed-off-by: Zhouyi Zhou
---
net/netfilter/nf_conntrack_h323_main.c |
15 matches
Mail list logo
