Re: [PATCH v19 6/7] KVM: arm64: Add support for the KVM PTP service

2021-04-17 Thread Zenghui Yu
On 2021/4/17 17:10, Marc Zyngier wrote: On Sat, 17 Apr 2021 09:59:39 +0100, Zenghui Yu wrote: On 2021/3/30 22:54, Marc Zyngier wrote: +PTP_KVM support for arm/arm64 += + +PTP_KVM is used for high precision time sync between host and guests. +It relies on

Re: [PATCH v19 1/7] arm/arm64: Probe for the presence of KVM hypervisor

2021-04-17 Thread Zenghui Yu
On 2021/3/30 22:54, Marc Zyngier wrote: #define SMCCC_ARCH_WORKAROUND_RET_UNAFFECTED 1 I think it'd be better to keep this definition together with other wa Function IDs. It's only a cosmetic comment anyway. Zenghui

Re: [PATCH v19 4/7] time: Add mechanism to recognize clocksource in time_get_snapshot

2021-04-17 Thread Zenghui Yu
On 2021/3/30 22:54, Marc Zyngier wrote: - u64 cycles; - ktime_t real; - ktime_t raw; - unsigned intclock_was_set_seq; - u8 cs_was_changed_seq; + u64 cycles; + ktime_t real; +

Re: [PATCH v19 6/7] KVM: arm64: Add support for the KVM PTP service

2021-04-17 Thread Zenghui Yu
On 2021/3/30 22:54, Marc Zyngier wrote: +PTP_KVM support for arm/arm64 += + +PTP_KVM is used for high precision time sync between host and guests. +It relies on transferring the wall clock and counter value from the +host to the guest using a KVM-specific hypercall. +

Re: [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

2021-04-17 Thread Zenghui Yu
On 2021/3/30 22:54, Marc Zyngier wrote: +int kvm_arch_ptp_init(void) +{ + int ret; + + ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP); + if (ret <= 0) kvm_arm_hyp_service_available() returns boolean. Maybe write as ? bool ret; ret = kvm_arm_hyp_s

[PATCH net] docs: net: ena: Fix ena_start_xmit() function name typo

2021-03-15 Thread Zenghui Yu
The ena.rst documentation referred to end_start_xmit() when it should refer to ena_start_xmit(). Fix the typo. Signed-off-by: Zenghui Yu --- Documentation/networking/device_drivers/ethernet/amazon/ena.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-23 Thread Zenghui Yu
On 2020/10/23 14:22, Yunsheng Lin wrote: On 2020/10/23 13:15, Zenghui Yu wrote: When unbinding the hns3 driver with the HNS3 VF, I got the following kernel panic: [ 265.709989] Unable to handle kernel paging request at virtual address 800054627000 [ 265.717928] Mem abort info

[PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-22 Thread Zenghui Yu
, which is pretty bad and the kernel happily kills itself because of a Current EL Data Abort (on arm64). Moving the CMDQ uninitialization a bit early fixes the issue for me. Signed-off-by: Zenghui Yu --- I have almost zero knowledge about the hns3 driver. You can regard this as a report and make a