[PATCH net-next] ravb: Remove manual pause frame transmit

2016-06-01 Thread Yoshihiro Kaneko
From: Masaru Nagai Writing a non-zero value to the manual PAUSE frame register (MPR) starts the transmission of a PAUSE frame. A PAUSE frame is sent in ravb_emac_init(), but it is not expected behavior. Signed-off-by: Masaru Nagai Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro

[PATCH net-next v2] ravb: Add ESF in RCR for enabling separation filter

2016-05-31 Thread Yoshihiro Kaneko
ams are processed in reception queue 0 (best effort). This patch sets B'11 in ESF. [ykaneko0...@gmail.com: revised this commit message] Signed-off-by: Masaru Nagai Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko Acked-by: Sergei Shtylyov --- This patch is based on the master

Re: [PATCH net-next] ravb: Add ESF in RCR for enabling separation filter

2016-05-31 Thread Yoshihiro Kaneko
t; >>It was somewhat hard for me to parse that... > > >Forgot about s/Non-mating/Non-matching/. Thanks for your review. I will revise the commit message. Thanks, kaneko > > >>> Signed-off-by: Masaru Nagai >>> Signed-off-by: Kazuya Mizuguchi >>> Signed-off-by: Yoshihiro Kaneko >> >> >> Acked-by: Sergei Shtylyov > > > MBR, Sergei >

[PATCH net-next] ravb: Add SET_RUNTIME_PM_OPS macro

2016-05-29 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi Use SET_RUNTIME_PM_OPS macro instead of assigning a member of dev_pm_ops directly. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's next networking tree. drivers/net/ethernet/re

[PATCH net-next] ravb: Add ESF in RCR for enabling separation filter

2016-05-29 Thread Yoshihiro Kaneko
11 or B'10. When B'10 is setting, Non-mating frames are discarded. Signed-off-by: Masaru Nagai Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's next networking tree. drivers/net/ethernet/renesas/ra

[PATCH net-next v2] ravb: Remove rx buffer ALIGN

2016-05-01 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi Aligning the reception data size is not required. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko Tested-by: Simon Horman --- This patch is based on the master branch of David Miller's next networking tree. v2 [Yoshihiro Kaneko] * As suggest

Re: [PATCH net-next] ravb: Remove rx buffer ALIGN

2016-05-01 Thread Yoshihiro Kaneko
Hi Simon-san, Thank you for testing this patch! Thanks, kaneko 2016-04-29 8:34 GMT+09:00 Simon Horman : > Hi Sergei, Hi Kaneko-san, > > On Tue, Apr 26, 2016 at 10:14:41PM +0300, Sergei Shtylyov wrote: >> Hello. >> >> On 04/24/2016 07:16 PM, Yoshihiro Kaneko wrote: &g

Re: [PATCH net-next] ravb: Remove rx buffer ALIGN

2016-05-01 Thread Yoshihiro Kaneko
Hi Sergei, Sorry for the late reply. 2016-04-27 4:14 GMT+09:00 Sergei Shtylyov : > Hello. > > On 04/24/2016 07:16 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> Aligning the reception data size is not required. > > >OK, the gen 2/3 manu

[PATCH net-next] ravb: Remove rx buffer ALIGN

2016-04-24 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi Aligning the reception data size is not required. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's next networking tree. drivers/net/ethernet/renesas/ravb_main.c | 16 --

[PATCH v9 net-next] ravb: Add dma queue interrupt support

2016-04-03 Thread Yoshihiro Kaneko
...@gmail.com: make timestamp interrupt handler a function] [ykaneko0...@gmail.com: timestamp interrupt is handled in multiple interrupt handler instead of dma queue interrupt handler] Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko Acked-by: Sergei Shtylyov --- This patch is

Re: [PATCH v8 net-next] ravb: Add dma queue interrupt support

2016-03-28 Thread Yoshihiro Kaneko
Hello. 2016-03-27 22:02 GMT+09:00 Sergei Shtylyov : > Hello. > > > On 03/22/2016 06:22 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (timestamp, error

Re: [PATCH v8 net-next] ravb: Add dma queue interrupt support

2016-03-23 Thread Yoshihiro Kaneko
2016-03-23 4:55 GMT+09:00 David Miller : > From: Yoshihiro Kaneko > Date: Wed, 23 Mar 2016 00:22:00 +0900 > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (timestamp, error, gPTP) >>

[PATCH v8 net-next] ravb: Add dma queue interrupt support

2016-03-22 Thread Yoshihiro Kaneko
...@gmail.com: make timestamp interrupt handler a function] [ykaneko0...@gmail.com: timestamp interrupt is handled in multiple interrupt handler instead of dma queue interrupt handler] Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of

[PATCH net] ravb: fix result value overwrite

2016-03-15 Thread Yoshihiro Kaneko
The result value is overwritten by a return value of ravb_ptp_interrupt(). Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. drivers/net/ethernet/renesas/ravb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v7 net-next] ravb: Add dma queue interrupt support

2016-03-15 Thread Yoshihiro Kaneko
Hi, 2016-03-15 5:48 GMT+09:00 Sergei Shtylyov : > Hello. > > > On 03/13/2016 09:11 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (timestamp, error

[PATCH v7 net-next] ravb: Add dma queue interrupt support

2016-03-13 Thread Yoshihiro Kaneko
...@gmail.com: make timestamp interrupt handler a function] [ykaneko0...@gmail.com: timestamp interrupt is handled in multiple interrupt handler instead of dma queue interrupt handler] Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of

Re: [PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-03-08 Thread Yoshihiro Kaneko
Hi Sergei-san, 2016-02-29 0:41 GMT+09:00 Yoshihiro Kaneko : [snip] > +static bool ravb_timestamp_interrupt(struct net_device *ndev, u32 tis) > +{ I'd like to read TIS here like ravb_queue_interrupt(). > + if (tis & TIS_TFUF) { > + ravb_write

Re: [PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-03-07 Thread Yoshihiro Kaneko
2016-03-03 3:50 GMT+09:00 Sergei Shtylyov : > On 03/02/2016 09:16 PM, Yoshihiro Kaneko wrote: > >>>> From: Kazuya Mizuguchi >>>> >>>> This patch supports the following interrupts. >>>> >>>> - One interrupt for multiple (timestamp,

Re: [PATCH/RFC v5 net-next] ravb: Add dma queue interrupt support

2016-03-02 Thread Yoshihiro Kaneko
2016-03-01 5:55 GMT+09:00 Sergei Shtylyov : > On 02/28/2016 05:13 PM, Yoshihiro Kaneko wrote: > >>>> From: Kazuya Mizuguchi >>>> >>>> This patch supports the following interrupts. >>>> >>>> - One interrupt for multiple (error,

Re: [PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-03-02 Thread Yoshihiro Kaneko
2016-03-01 5:30 GMT+09:00 Sergei Shtylyov : > Hello. > > > On 02/28/2016 06:41 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (timestamp, error, gPTP) >

[PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-02-28 Thread Yoshihiro Kaneko
...@gmail.com: make timestamp interrupt handler a function] [ykaneko0...@gmail.com: timestamp interrupt is handled in multiple interrupt handler instead of dma queue interrupt handler] Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of

Re: [PATCH/RFC v5 net-next] ravb: Add dma queue interrupt support

2016-02-28 Thread Yoshihiro Kaneko
2016-02-22 4:05 GMT+09:00 Sergei Shtylyov : > On 02/14/2016 10:39 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (error, gPTP) >> - One interrupt for ema

[PATCH/RFC v5 net-next] ravb: Add dma queue interrupt support

2016-02-14 Thread Yoshihiro Kaneko
()] [ykaneko0...@gmail.com: revert ravb_close() and ravb_ptp_stop()] [ykaneko0...@gmail.com: avoid calling free_irq() to non-hooked interrupts] [ykaneko0...@gmail.com: make NC/BE interrupt handler a function] Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-02-08 Thread Yoshihiro Kaneko
Hi Sergei-san, 2016-02-08 2:09 GMT+09:00 Sergei Shtylyov : > Hello. > > On 02/07/2016 07:50 PM, Yoshihiro Kaneko wrote: > >> I apologize for not responding to you earlier. > > >Absolutely no problem, these reviews/tests take time from my main tasks > any

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-02-07 Thread Yoshihiro Kaneko
2016-01-29 2:51 GMT+09:00 Sergei Shtylyov : > On 01/24/2016 06:52 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (descriptor, error, management

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-02-07 Thread Yoshihiro Kaneko
Hi Sergei, I apologize for not responding to you earlier. 2016-01-29 1:48 GMT+09:00 Sergei Shtylyov : > Hello. > > > On 01/24/2016 06:52 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-02-07 Thread Yoshihiro Kaneko
2016-01-29 2:32 GMT+09:00 Sergei Shtylyov : > On 01/24/2016 06:52 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (descriptor, error, management) >> - One inter

[PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-01-24 Thread Yoshihiro Kaneko
the interrupt handler corresponding to each interrupt source described above. Additionally, it reduces the number of times of the access to EthernetAVB IF. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's

Re: [PATCH/RFC v3 net-next] ravb: Add dma queue interrupt support

2016-01-24 Thread Yoshihiro Kaneko
Hi Sergei, 2016-01-24 7:17 GMT+09:00 Sergei Shtylyov : > Hello. > > On 01/17/2016 01:55 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (descriptor, erro

Re: [PATCH/RFC v2 net-next] ravb: Add dma queue interrupt support

2015-12-26 Thread Yoshihiro Kaneko
Hello, 2015-12-23 0:02 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/20/2015 12:15 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (descriptor, error, managem

[PATCH/RFC v2 net-next] ravb: Add dma queue interrupt support

2015-12-20 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko

Re: [PATCH/RFC net-next] ravb: Add dma queue interrupt support

2015-12-20 Thread Yoshihiro Kaneko
Hi, 2015-12-18 2:42 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/17/2015 07:29 PM, Yoshihiro Kaneko wrote: > >>>> From: Kazuya Mizuguchi >>>> >>>> This patch supports the following interrupts. >>>> >>>> - One interrupt fo

Re: [PATCH/RFC net-next] ravb: Add dma queue interrupt support

2015-12-17 Thread Yoshihiro Kaneko
Hi, 2015-12-16 4:00 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/15/2015 03:23 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (descriptor, error, managem

[PATCH/RFC net-next] ravb: Add dma queue interrupt support

2015-12-15 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko

Re: [PATCH net-next] ravb: Add fixed-link support

2015-12-15 Thread Yoshihiro Kaneko
Hi, 2015-12-14 6:00 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/13/2015 06:16 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch adds support of the fixed PHY. >> This patch is based on commit 87009814cdbb ("ucc_geth: use the new

[PATCH v2 net-next] ravb: Add fixed-link support

2015-12-15 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch adds support of the fixed PHY. This patch is based on commit 87009814cdbb ("ucc_geth: use the new fixed PHY helpers"). Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Mil

Re: [PATCH v2 net] ravb: Remove clear unhandled interrupt

2015-12-14 Thread Yoshihiro Kaneko
Hi, 2015-12-14 1:25 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/13/2015 06:12 PM, Yoshihiro Kaneko wrote: > >The subject doesn't seem to reflect what the patch is doing. > > >> From: Kazuya Mizuguchi >> >> AVB-DMAC Receive FIFO Warning interru

[PATCH v3 net] ravb: clear RIC1 in init instead of stop

2015-12-14 Thread Yoshihiro Kaneko
boot loader left. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. v3 [Yoshihiro Kaneko] * compile tested only * As suggested by Sergei Shtylyov - update the subject to reflect what this patch is

Re: [PATCH net-next] ravb: ptp: fix misplaced ravb_ptp_stop() calling in ravb_probe()

2015-12-13 Thread Yoshihiro Kaneko
2015-12-09 23:20 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/8/2015 9:39 PM, Yoshihiro Kaneko wrote: > >> 'commit ("ravb: ptp: Add CONFIG mode support")' added >> a calling of ravb_ptp_stop() in a wrong place in ravb_probe(). >> >> Signe

[PATCH net-next] ravb: Add fixed-link support

2015-12-13 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch adds support of the fixed PHY. This patch is based on commit 87009814cdbb ("ucc_geth: use the new fixed PHY helpers"). Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Mil

[PATCH net] ravb: Add disable 10base

2015-12-13 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi Ethernet AVB does not support 10 Mbps transfer speed. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. drivers/net/ethernet/renesas/ravb_main.c | 3 +++ 1 file chang

[PATCH v2 net] ravb: Remove clear unhandled interrupt

2015-12-13 Thread Yoshihiro Kaneko
loader left. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. v2 [Yoshihiro Kaneko] * compile tested only * As suggested by Sergei Shtylyov - clear RIC1 in ndo_open() to disable the interrupt regar

[PATCH net-next] ravb: ptp: fix misplaced ravb_ptp_stop() calling in ravb_probe()

2015-12-08 Thread Yoshihiro Kaneko
'commit ("ravb: ptp: Add CONFIG mode support")' added a calling of ravb_ptp_stop() in a wrong place in ravb_probe(). Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's next networking tree. Compile tested only. dri

Re: [PATCH net] ravb: Remove clear unhandled interrupt

2015-12-07 Thread Yoshihiro Kaneko
Hello, 2015-12-07 4:18 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/06/2015 02:42 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> AVB-DMAC Reception Warning interrupt is not enabled, so it is not >> necessary to clear the interrupt. &

Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-07 Thread Yoshihiro Kaneko
Hello Sergei, 2015-12-07 4:19 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/05/2015 01:01 PM, Yoshihiro Kaneko wrote: > >> Thanks for your review. > > >From now on, it'll be my duty. :-) Thank you always for your help. > >> 2015-12-04 6:09 GMT

[PATCH net] ravb: Remove clear unhandled interrupt

2015-12-06 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi AVB-DMAC Reception Warning interrupt is not enabled, so it is not necessary to clear the interrupt. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. drivers/net/eth

Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-05 Thread Yoshihiro Kaneko
Hello Sergei, Thanks for your review. 2015-12-04 6:09 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/01/2015 08:04 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch makes PTP support active in CONFIG mode on R-Car Gen3. >> >> Sign

[PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-01 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch makes PTP support active in CONFIG mode on R-Car Gen3. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's next networking tree. drivers/net/ethernet/renesas/ravb.h

[PATCH net] ravb: remove unhandle int cause

2015-11-15 Thread Yoshihiro Kaneko
From: Masaru Nagai This driver does not handle the AVB-DMAC Receive FIFO Warning interrupt now, so the interrupt should not be enabled. Signed-off-by: Masaru Nagai Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. driver

[PATCH net] ravb: Fix int mask value overwritten issue

2015-11-13 Thread Yoshihiro Kaneko
: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. drivers/net/ethernet/renesas/ravb_main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_m