[PATCH v3 1/2] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-21 Thread YASUAKI ISHIMATSU
JITSU LIMITED" The message makes users confused because there is no reason that the message is shown in other vendor servers. To avoid the confusion, the patch adds a check that the server has a extended socket device or not. Signed-off-by: Yasuaki Ishimatsu CC: Taku Izumi --- v3: - Reb

[PATCH v3 2/2] fjes: Do not load fjes driver if extended socket device is not power on.

2017-03-21 Thread YASUAKI ISHIMATSU
The extended device socket cannot turn on/off while system is running. So when system boots up and the device is not power on, the fjes driver does not need be loaded. To check the status of the device, the patch adds ACPI _STA method check. Signed-off-by: Yasuaki Ishimatsu CC: Taku Izumi

[PATCH v3 0/2] fjes: Do not load fjes driver

2017-03-21 Thread YASUAKI ISHIMATSU
l variable declarations from longest to shortest line Yasuaki Ishimatsu(2): fjes: Do not load fjes driver if system does not have extended socket device. fjes: Do not load fjes driver if extended socket device is not power on. drivers/net/fjes/fjes_main.c | 76 +

Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-14 Thread YASUAKI ISHIMATSU
I'll update the patch soon. Thanks, Yasuaki Ishimatsu I'll review and test your patch soon. Sincerely, Taku Izumi # git clone git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git Cloning into 'net-next'... remote: Counting objects: 5265118, done.

Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-14 Thread YASUAKI ISHIMATSU
On 03/12/2017 02:29 PM, Bjørn Mork wrote: Yasuaki Ishimatsu writes: The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table, the following message is always shown: "FUJITSU Ext

Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-10 Thread Yasuaki Ishimatsu
On 03/09/2017 08:35 PM, David Miller wrote: From: Yasuaki Ishimatsu Date: Wed, 8 Mar 2017 16:05:18 -0500 The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table, the following message is

[PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-08 Thread Yasuaki Ishimatsu
JITSU LIMITED" The message makes users confused because there is no reason that the message is shown in other vendor servers. To avoid the confusion, the patch adds a check that the server has a extended socket device or not. Signed-off-by: Yasuaki Ishimatsu CC: Taku Izumi --- v2: - O

Re: [PATCH] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-08 Thread Yasuaki Ishimatsu
Hi David, On 03/07/2017 04:44 PM, David Miller wrote: From: Yasuaki Ishimatsu Date: Thu, 2 Mar 2017 11:56:44 -0500 + /* fjes_init_module - Driver Registration Routine */ static int __init fjes_init_module(void) { int result; + bool found = false; + Please order local

[PATCH] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-02 Thread Yasuaki Ishimatsu
JITSU LIMITED" The message makes users confused because there is no reason that the message is shown in other vendor servers. To avoid the confusion, the patch adds a check that the server has a extended socket device or not. Signed-off-by: Yasuaki Ishimatsu CC: Taku Izumi --- driver

Re: [PATCH] fjes: Move fjes driver info message into fjes_acpi_add()

2017-02-22 Thread Yasuaki Ishimatsu
Thank you for quick response. I'll think of other solution. Thanks, Yasuaki Ishimatsu On 02/22/2017 03:45 PM, David Miller wrote: From: Yasuaki Ishimatsu Date: Wed, 22 Feb 2017 15:40:49 -0500 To avoid the confusion, the patch moves the message into fjes_acpi_add() so that it is shows

[PATCH] fjes: Move fjes driver info message into fjes_acpi_add()

2017-02-22 Thread Yasuaki Ishimatsu
JITSU LIMITED" The message makes users confused because there is no reason that the message is shown in other vendor servers. To avoid the confusion, the patch moves the message into fjes_acpi_add() so that it is shows only when fjes_acpi_add() succeeded. Signed-off-by: Yasuaki Ishimatsu CC:

Re: [PATCH v2 18/22] fjes: unshare_watch_task

2015-07-13 Thread Yasuaki Ishimatsu
&adapter->force_close_task); > + } > + break; > + } > + mutex_unlock(&hw->hw_info.lock); > + > + fjes_hw_setup_epbuf(&hw->ep_shm

Re: [PATCH v2 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid

2015-07-13 Thread Yasuaki Ishimatsu
Hi Izumi-san, On Wed, 24 Jun 2015 11:55:47 +0900 Taku Izumi wrote: > This patch adds net_device_ops.ndo_vlan_rx_add_vid and > net_device_ops.ndo_vlan_rx_kill_vid callback. > > Signed-off-by: Taku Izumi > --- > drivers/net/fjes/fjes_hw.c | 27 +++ > drivers/net/fjes/f

Re: [PATCH v2 10/22] fjes: tx_stall_task

2015-07-13 Thread Yasuaki Ishimatsu
tdev; > + enum ep_partner_status pstatus; > + int epid; > + int max_epid, my_epid; > + union ep_buffer_info *info; > + int all_queue_available; > + int i; > + int sendable; > + > + if (((long)jiffies - > + (long)(netdev->trans_start)) &

Re: [PATCH v2 08/22] fjes: net_device_ops.ndo_start_xmit

2015-07-10 Thread Yasuaki Ishimatsu
netdev->trans_start = jiffies; > + netif_tx_stop_queue(cur_queue); > + > + ret = NETDEV_TX_BUSY; Even if ret set NETDEV_TX_BUSY, it may be changed to NETDEV_TX_OK in the for loop. Is it OK? > + } &g

Re: [PATCH v2 06/22] fjes: buffer address regist/unregistration routine

2015-07-07 Thread Yasuaki Ishimatsu
ase FJES_CMD_STATUS_UNKNOWN: > + result = -EPERM; > + break; > + case FJES_CMD_STATUS_TIMEOUT: > + result = -EBUSY; > + break; > + case FJES_CMD_STATUS_ERROR_PARAM: > +

Re: [PATCH v2 02/22] fjes: Hardware initialization routine

2015-07-07 Thread Yasuaki Ishimatsu
izeof(struct ep_share_mem_info), GFP_KERNEL); > + if (!buf) > + return -ENOMEM; > + > + hw->ep_shm_info = (struct ep_share_mem_info *)buf; > + > + mem_size = FJES_DEV_REQ_BUF_SIZE(hw->max_epid); > + hw->hw_info.req_buf = kzalloc(mem_siz

Re: [PATCH v2 06/22] fjes: buffer address regist/unregistration routine

2015-07-06 Thread Yasuaki Ishimatsu
On Wed, 24 Jun 2015 11:55:38 +0900 Taku Izumi wrote: > This patch adds buffer address regist/unregistration routine. > > This function is mainly invoked when network device's > activation (open) and deactivation (close) > in order to retist/unregist shared buffer address. registe

Re: [PATCH 02/22] fjes: Hardware initialization routine

2015-06-19 Thread Yasuaki Ishimatsu
t; + buf_pair = &(hw->ep_shm_info[epidx]); > + > + result = fjes_hw_alloc_epbuf(&(buf_pair->tx)); > + if (result) > + return result; > + > + result = fjes_hw_alloc_ep