[PATCH] tun: fix inability to set offloads after disabling them via ethtool

2017-03-16 Thread Yaroslav Isakov
Added missing logic in tun driver, which prevents apps to set offloads using tun ioctl, if offloads were previously disabled via ethtool Signed-of-by: Yaroslav Isakov (yaroslav.isa...@gmail.com) --- drivers/net/tun.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/tun.c b

[PATCH] tun: fix inability to set offloads after disabling them via ethtool

2017-03-16 Thread Yaroslav Isakov
Added missing logic in tun driver, which prevents apps to set offloads using tun ioctl, if offloads were previously disabled via ethtool Signed-off-by: Yaroslav Isakov --- drivers/net/tun.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 34cc3c5

Re: [PATCH] tun: fix inability to set offloads after disabling them via ethtool

2017-03-16 Thread Yaroslav Isakov
Sorry for spamming mailing list, forgot to check via checkpatch.pl, will resend it one more time 2017-03-16 21:08 GMT+03:00 Yaroslav Isakov : > Added missing logic in tun driver, which prevents apps to set > offloads using tun ioctl, if offloads were previously disabled via ethtool > &g

Re: tun offloads bug

2017-03-16 Thread Yaroslav Isakov
Sorry for this mess! I'll do it properly this time, I hope :) 2017-03-16 22:12 GMT+03:00 David Miller : > > This is not how you resubmit a patch. > > You must make a fresh patch posting to the mailing list, provide the > commit message and patch as inline text, and not do it as a reply to > anothe

Re: tun offloads bug

2017-03-16 Thread Yaroslav Isakov
Hello! I'm sending new patch, with proper formatting and signed tag 2017-03-08 23:29 GMT+03:00 Yaroslav Isakov : > Hello! > I've found a bug in TUN/TAP driver with offloads - when Qemu is trying > to set offloads on tap device, there is no error, but offloads are not > ap

tun offloads bug

2017-03-08 Thread Yaroslav Isakov
Hello! I've found a bug in TUN/TAP driver with offloads - when Qemu is trying to set offloads on tap device, there is no error, but offloads are not appied. The cause of this is that udev in recent systemd is using ethtool to disable offloads. So, udev is setting tun->dev->wanted_features via etht