Remove redundant semi-colon in infinalize_btf_ext().
Signed-off-by: Yang Yingliang
---
v2:
add commit log
---
tools/lib/bpf/linker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/linker.c b/tools/lib/bpf/linker.c
index 46b16cbdcda3..4e08bc07e635 100644
Signed-off-by: Yang Yingliang
---
tools/lib/bpf/linker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/linker.c b/tools/lib/bpf/linker.c
index 46b16cbdcda3..4e08bc07e635 100644
--- a/tools/lib/bpf/linker.c
+++ b/tools/lib/bpf/linker.c
@@ -1895,7 +1895,7
Signed-off-by: Yang Yingliang
---
drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c
b/drivers/net/ethernet/microchip/lan743x_main.c
index 1c3e204d727c..e7ab5f3f73fd 100644
--- a/drivers
Add the missing destroy_workqueue() before return from
tipc_crypto_start() in the error handling case.
Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
net/tipc/crypto.c | 2 ++
1 file changed, 2 insertion
It already has null pointer check in kfree_skb(),
remove pointless pointer check before kfree_skb().
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
drivers/net/mhi/net.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/mhi/net.c b/drivers/net/mhi
The spinlock nf_tables_destroy_list_lock is initialized statically.
It is unnecessary to initialize by spin_lock_init().
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
net/netfilter/nf_tables_api.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/netfilter/nf_tables_api.c b
Fix the following make W=1 kernel build warning:
drivers/net/mdio.c:95: warning: expecting prototype for mdio_link_ok().
Prototype was for mdio45_links_ok() instead
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
drivers/net/mdio.c | 2 +-
1 file changed, 1 insertion(+), 1
Fix the following make W=1 kernel build warning:
drivers/net/bonding/bond_main.c:982: warning: expecting prototype for
change_active_interface(). Prototype was for bond_change_active_slave() instead
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
drivers/net/bonding/bond_main.c
Fix the following make W=1 kernel build warning:
drivers/net/phy/mdio-boardinfo.c:63: warning: expecting prototype for
mdio_register_board_info(). Prototype was for mdiobus_register_board_info()
instead
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
drivers/net/phy/mdio
Add the missing unlock before return from stmmac_suspend()
in the error handling case.
Fixes: 5ec55823438e ("net: stmmac: add clocks management for gmac driver")
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++-
1 fi
Fix the following make W=1 kernel build warning:
net/llc/llc_pdu.c:36: warning: expecting prototype for pdu_set_pf_bit().
Prototype was for llc_pdu_set_pf_bit() instead
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
net/llc/llc_pdu.c | 2 +-
1 file changed, 1 insertion(+), 1
(). Prototype was for
llc_conn_ev_qlfy_last_frame_eq_0() instead
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
net/llc/llc_c_ev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/llc/llc_c_ev.c b/net/llc/llc_c_ev.c
index 523fdd1cf781..d6627a80cb45 100644
--- a/net
Fix some make W=1 kernel build warnings in net/llc/
Yang Yingliang (3):
net: llc: Correct some function names in header
net: llc: Correct function name llc_sap_action_unitdata_ind() in
header
net: llc: Correct function name llc_pdu_set_pf_bit() in header
net/llc/llc_c_ev.c | 4
Fix the following make W=1 kernel build warning:
net/llc/llc_s_ac.c:38: warning: expecting prototype for
llc_sap_action_unit_data_ind(). Prototype was for llc_sap_action_unitdata_ind()
instead
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
net/llc/llc_s_ac.c | 2 +-
1 file
k_registered(), on other error
path in register_netdevice(), ndo_uninit() and priv_destructor() are
called before register_netdevice() return, but in this case,
priv_destructor() will never be called, then it causes memory leak,
so we should call priv_destructor() here.
Reported-by: Hulk Robot
Signed
On 2020/12/1 17:46, Jason A. Donenfeld wrote:
Hi Yang,
On Tue, Dec 1, 2020 at 10:31 AM Yang Yingliang wrote:
After commit cf124db566e6 ("net: Fix inconsistent teardown and..."),
priv_destruct() doesn't call free_netdev() in driver, we use
dev->needs_free_netdev t
ctor() and set
dev->needs_free_netdev to true.
Signed-off-by: Yang Yingliang
---
drivers/net/wireguard/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireguard/device.c b/drivers/net/wireguard/device.c
index c9f65e96ccb0..578ac6097d7e 100644
--- a/drivers/net/wir
k_registered(), on other error
path in register_netdevice(), ndo_uninit() and priv_destructor() are
called before register_netdevice() return, but in this case,
priv_destructor() will never be called, then it causes memory leak,
so we should call priv_destructor() here.
Reported-by: Hulk Robot
Signed-o
On 2020/11/29 21:56, Toshiaki Makita wrote:
On 2020/11/26 22:23, Yang Yingliang wrote:
...
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
net/core/dev.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 82dc6b48e45f
On 2020/11/30 12:39, Stephen Hemminger wrote:
On Thu, 26 Nov 2020 21:23:12 +0800
Yang Yingliang wrote:
I got a memleak report when doing fault-inject test:
unreferenced object 0x88810ace9000 (size 1024):
comm "ip", pid 4622, jiffies 4295457037 (age 43.378s)
hex dump
k_registered(), on other error
path in register_netdevice(), ndo_uninit() and priv_destructor() are
called before register_netdevice() return, but in this case,
priv_destructor() will never be called, then it causes memory leak,
so we should call priv_destructor() here.
Reported-by: Hulk Robot
Signed-
6>] do_syscall_64+0x33/0x40
[<e00521b4>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
If call_netdevice_notifiers() failed in register_netdevice(),
dev->priv_destructor() is not called, it will cause memleak.
Fix this by assigning ndo_uninit with veth_dev_free(), so
the memory can be fre
It's hard to read the code without spaces around '&',
for better reading, add spaces around '&'.
Signed-off-by: Yang Yingliang
---
net/netlink/af_netlink.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/netlink/af_netlink.c
Spaces preferred around '&'.
Signed-off-by: Yang Yingliang
---
net/netlink/af_netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index d2d1448274f5..5a86bf4f80b1 100644
--- a/net/netlink/af_netli
Hi,
I got some crashes when using connector module in linux-4.19:
log1:
[10385482.776385] Unable to handle kernel paging request at virtual address
0003004c
[10385482.777083] Mem abort info:
[10385482.777340] ESR = 0x9604
[10385482.777578] Exception class = DABT (current EL), IL
] __x64_sys_ioctl+0x6f/0xb0
[<e1023498>] do_syscall_64+0x56/0xa0
[<9ec0eb12>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
If call_netdevice_notifiers() failed, then rollback_registered()
calls netdev_unregister_kobject() which holds the kobject. The
reference cannot be put because the
When devinet_sysctl_register() failed, the memory allocated
in neigh_parms_alloc() should be freed.
Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or
default")
Signed-off-by: Yang Yingliang
---
net/ipv4/devinet.c | 1 +
1 file changed, 1 insertion(+)
diff -
On 2020/5/6 15:51, Zefan Li wrote:
On 2020/5/6 10:16, Zefan Li wrote:
On 2020/5/6 9:50, Yang Yingliang wrotee:
+cc lize...@huawei.com
On 2020/5/6 0:06, Tejun Heo wrote:
Hello, Yang.
On Sat, May 02, 2020 at 06:27:21PM +0800, Yang Yingliang wrote:
I find the number nr_dying_descendants is
The type of dispatch is u8 which is always '<=' 0xff, so the
dispatch <= 0xff is always true, we can remove this comparison.
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
net/ieee802154/6lowpan/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
+cc lize...@huawei.com
On 2020/5/6 0:06, Tejun Heo wrote:
Hello, Yang.
On Sat, May 02, 2020 at 06:27:21PM +0800, Yang Yingliang wrote:
I find the number nr_dying_descendants is increasing:
linux-dVpNUK:~ # find /sys/fs/cgroup/ -name cgroup.stat -exec grep
'^nr_dying_descendant
Hi,
I got an oom panic because cgroup is leaked.
Here is the steps :
- run a docker with --cap-add sys_admin parameter and the systemd
process in the docker uses both cgroupv1 and cgroupv2
- ssh/exit from host to docker repeately
I find the number nr_dying_descendants is increasing:
linux
hing of tfile->tun after register_netdevice(),
so tun_get() won't get the tun pointer that freed by
err_detach path if register_netdevice() failed.
Fixes: eb0fb363f920 ("tuntap: attach queue 0 before registering netdevice")
Reported-by: Hulk Robot
Suggested-by: Jason Wang
Signed-off-by: Y
On 2019/9/5 11:10, Jason Wang wrote:
On 2019/9/5 上午10:03, Yang Yingliang wrote:
On 2019/9/3 18:50, Jason Wang wrote:
- Original Message -
On 2019/9/3 14:06, Jason Wang wrote:
On 2019/9/3 下午1:42, Yang Yingliang wrote:
On 2019/9/3 11:03, Jason Wang wrote:
On 2019/9/3 上午9:45, Yang
On 2019/9/3 18:50, Jason Wang wrote:
- Original Message -
On 2019/9/3 14:06, Jason Wang wrote:
On 2019/9/3 下午1:42, Yang Yingliang wrote:
On 2019/9/3 11:03, Jason Wang wrote:
On 2019/9/3 上午9:45, Yang Yingliang wrote:
On 2019/9/2 13:32, Jason Wang wrote:
On 2019/8/23 下午5:36
On 2019/9/3 14:06, Jason Wang wrote:
On 2019/9/3 下午1:42, Yang Yingliang wrote:
On 2019/9/3 11:03, Jason Wang wrote:
On 2019/9/3 上午9:45, Yang Yingliang wrote:
On 2019/9/2 13:32, Jason Wang wrote:
On 2019/8/23 下午5:36, Yang Yingliang wrote:
On 2019/8/23 11:05, Jason Wang wrote
On 2019/9/3 11:03, Jason Wang wrote:
On 2019/9/3 上午9:45, Yang Yingliang wrote:
On 2019/9/2 13:32, Jason Wang wrote:
On 2019/8/23 下午5:36, Yang Yingliang wrote:
On 2019/8/23 11:05, Jason Wang wrote:
- Original Message -
On 2019/8/22 14:07, Yang Yingliang wrote:
On 2019/8
On 2019/9/2 13:32, Jason Wang wrote:
On 2019/8/23 下午5:36, Yang Yingliang wrote:
On 2019/8/23 11:05, Jason Wang wrote:
- Original Message -
On 2019/8/22 14:07, Yang Yingliang wrote:
On 2019/8/22 10:13, Jason Wang wrote:
On 2019/8/20 上午10:28, Jason Wang wrote:
On 2019/8/20 上午
On 2019/8/23 11:05, Jason Wang wrote:
- Original Message -
On 2019/8/22 14:07, Yang Yingliang wrote:
On 2019/8/22 10:13, Jason Wang wrote:
On 2019/8/20 上午10:28, Jason Wang wrote:
On 2019/8/20 上午9:25, David Miller wrote:
From: Yang Yingliang
Date: Mon, 19 Aug 2019 21:31:19
On 2019/8/22 14:07, Yang Yingliang wrote:
On 2019/8/22 10:13, Jason Wang wrote:
On 2019/8/20 上午10:28, Jason Wang wrote:
On 2019/8/20 上午9:25, David Miller wrote:
From: Yang Yingliang
Date: Mon, 19 Aug 2019 21:31:19 +0800
Call tun_attach() after register_netdevice() to make sure tfile
On 2019/8/22 10:13, Jason Wang wrote:
On 2019/8/20 上午10:28, Jason Wang wrote:
On 2019/8/20 上午9:25, David Miller wrote:
From: Yang Yingliang
Date: Mon, 19 Aug 2019 21:31:19 +0800
Call tun_attach() after register_netdevice() to make sure tfile->tun
is not published until the netdevice
n_attach()
- call tun_set_real_num_queues() before register_netdevice()
- call tun_attach() after register_netdevice()
---
Fixes: eb0fb363f920 ("tuntap: attach queue 0 before registering netdevice")
Reported-by: Hulk Robot
Suggested-by: Jason Wang
Signed-off-by: Yang Yingliang
On 2019/8/19 11:17, Jason Wang wrote:
On 2019/8/16 下午7:00, Yang Yingliang wrote:
[...]
INIT_LIST_HEAD(&tun->disabled);
- err = tun_attach(tun, file, false, ifr->ifr_flags & IFF_NAPI,
-ifr->ifr_flags & IFF_NAPI_FRAGS
etdevice()
- call tun_attach() after register_netdevice()
---
Cc: Yang Yingliang
Fixes: eb0fb363f920 ("tuntap: attach queue 0 before registering netdevice")
Reported-by: Hulk Robot
Suggested-by: Jason Wang
Signed-off-by: Yang Yingliang
---
drivers/net/tun.c | 38 ++
On 2019/8/15 17:21, Jason Wang wrote:
On 2019/8/15 下午4:18, Yang Yingliang wrote:
I got a UAF repport in tun driver when doing fuzzy test:
[ 466.269490]
==
[ 466.271792] BUG: KASAN: use-after-free in
tun_chr_read_iter+0x2ca
On 2019/8/15 17:35, Eric Dumazet wrote:
On 8/15/19 10:18 AM, Yang Yingliang wrote:
I got a UAF repport in tun driver when doing fuzzy test:
[ 466.368604] page:ea000dc84e00 refcount:1 mapcount:0
mapping:8883df1b4f00 index:0x0 compound_mapcount: 0
[ 466.371582] flags
s: eb0fb363f920 ("tuntap: attach queue 0 before registering netdevice")
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
drivers/net/tun.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index db16d7a13e00..
On 2016/4/12 10:59, Yang Yingliang wrote:
On 2016/4/11 20:13, Eric Dumazet wrote:
On Mon, 2016-04-11 at 19:57 +0800, Yang Yingliang wrote:
On 2016/4/8 22:44, Eric Dumazet wrote:
On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote:
I expand tcp_adv_win_scale and tcp_rmem. It has no
On 2016/4/11 20:13, Eric Dumazet wrote:
On Mon, 2016-04-11 at 19:57 +0800, Yang Yingliang wrote:
On 2016/4/8 22:44, Eric Dumazet wrote:
On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote:
I expand tcp_adv_win_scale and tcp_rmem. It has no effect.
Try :
echo -2 >/proc/sys/net/i
On 2016/4/9 1:04, Eric Dumazet wrote:
On Fri, 2016-04-08 at 12:53 -0400, David Miller wrote:
From: Eric Dumazet
Date: Fri, 08 Apr 2016 07:44:25 -0700
On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote:
I expand tcp_adv_win_scale and tcp_rmem. It has no effect.
Try :
echo -2
On 2016/4/8 22:44, Eric Dumazet wrote:
On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote:
I expand tcp_adv_win_scale and tcp_rmem. It has no effect.
Try :
echo -2 >/proc/sys/net/ipv4/tcp_adv_win_scale
And restart your flows.
cat /proc/sys/net/ipv4/tcp_rmem
10240 2097152 10485
On 2016/4/7 22:51, Eric Dumazet wrote:
On Thu, 2016-04-07 at 03:21 -0700, Eric Dumazet wrote:
Please do not send patches before really understanding the issue you
have.
Having a backlog of 12506206 bytes is ridiculous. Dropping packets is
absolutely fine if this ever happens.
Something is r
On 2016/3/30 21:47, Eric Dumazet wrote:
On Wed, 2016-03-30 at 13:56 +0800, Yang Yingliang wrote:
Sorry, I made a mistake. I am very sure my kernel has these two patches.
And I can get some dropping of the packets in 10Gb eth.
# netstat -s | grep -i backlog
TCPBacklogDrop: 4135
On 2016/3/30 20:56, Sergei Shtylyov wrote:
Hello.
On 3/30/2016 8:16 AM, Yang Yingliang wrote:
When task A hold the sk owned in tcp_sendmsg, if lots of packets
arrive and the packets will be added to backlog queue. The packets
will be handled in release_sock called from tcp_sendmsg. When the
On 2016/3/30 13:34, Eric Dumazet wrote:
On Tue, 2016-03-29 at 22:25 -0700, Eric Dumazet wrote:
On Wed, 2016-03-30 at 13:16 +0800, Yang Yingliang wrote:
When task A hold the sk owned in tcp_sendmsg, if lots of packets
arrive and the packets will be added to backlog queue. The packets
will be
On 2016/3/30 13:25, Eric Dumazet wrote:
On Wed, 2016-03-30 at 13:16 +0800, Yang Yingliang wrote:
When task A hold the sk owned in tcp_sendmsg, if lots of packets
arrive and the packets will be added to backlog queue. The packets
will be handled in release_sock called from tcp_sendmsg. When
are handled. This may leads to the
new packets be dropped because the lenth is too big. So set the
lenth to 0 immediately after it's detached from sk.
Signed-off-by: Yang Yingliang
---
net/core/sock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/sock.c b/net/core/sock.c
Hi,
I got a tap device refcnt leak message when I was detaching the device
and it's deadloop for waiting the usage count decrease to 0.
The log is:
unregister_netdevice: waiting for pae_tap0 to become free. Usage count = 1
Unfortunately, it happened only once unit now, I cannot reproduce this
57 matches
Mail list logo
