[PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Yang Li
Robot Signed-off-by: Yang Li --- tools/testing/selftests/bpf/progs/profiler.inc.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/profiler.inc.h b/tools/testing/selftests/bpf/progs/profiler.inc.h index 4896fdf8..a33066c

[PATCH] rsi: remove unused including

2021-04-13 Thread Yang Li
Fix the following versioncheck warning: ./drivers/net/wireless/rsi/rsi_91x_ps.c: 19 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/wireless/rsi/rsi_91x_ps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_ps.c b

[PATCH] rtlwifi: rtl8188ee: remove redundant assignment of variable rtlpriv->btcoexist.reg_bt_sco

2021-03-31 Thread Yang Li
t_reg_init Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c index 861cc66..bf686

[PATCH] isdn: mISDN: remove unneeded variable 'ret'

2021-03-10 Thread Yang Li
Fix the following coccicheck warning: ./drivers/isdn/mISDN/dsp_core.c:956:6-9: Unneeded variable: "err". Return "0" on line 1001 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/isdn/mISDN/dsp_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] drivers: ipa: Add missing IRQF_ONESHOT

2021-02-23 Thread Yang Li
fixed the following coccicheck: ./drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers

[PATCH] ibmveth: Switch to using the new API kobj_to_dev()

2021-02-22 Thread Yang Li
fixed the following coccicheck: ./drivers/net/ethernet/ibm/ibmveth.c:1805:51-52: WARNING opportunity for kobj_to_dev() Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/ibm/ibmveth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net

[PATCH v2] xfrm: Fix incorrect types in assignment

2021-02-19 Thread Yang Li
Fix the following sparse warnings: net/xfrm/xfrm_policy.c:1303:22: warning: incorrect type in assignment (different address spaces) Reported-by: Abaci Robot Signed-off-by: Yang Li --- net/xfrm/xfrm_policy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/xfrm

[PATCH] xfrm: Fix incorrect types in assignment

2021-02-19 Thread Yang Li
Fix the following sparse warnings: net/xfrm/xfrm_policy.c:1303:22: warning: incorrect type in assignment (different address spaces) Reported-by: Abaci Robot Signed-off-by: Yang Li --- net/xfrm/xfrm_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm

[PATCH] selftests: bpf: remove unneeded semicolon

2021-02-08 Thread Yang Li
Eliminate the following coccicheck warning: ./tools/testing/selftests/bpf/test_flow_dissector.c:506:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- tools/testing/selftests/bpf/test_flow_dissector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] selftests/net: so_txtime: remove unneeded semicolon

2021-02-08 Thread Yang Li
Eliminate the following coccicheck warning: ./tools/testing/selftests/net/so_txtime.c:199:3-4: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- tools/testing/selftests/net/so_txtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing

[PATCH v2] perf script: Simplify bool conversion

2021-02-08 Thread Yang Li
Fix the following coccicheck warning: ./tools/perf/builtin-script.c:2789:36-41: WARNING: conversion to bool not needed here ./tools/perf/builtin-script.c:3237:48-53: WARNING: conversion to bool not needed here Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: -Change the

[PATCH] bpf/benchs/bench_ringbufs: remove unneeded semicolon

2021-02-06 Thread Yang Li
Eliminate the following coccicheck warning: ./tools/testing/selftests/bpf/benchs/bench_ringbufs.c:322:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] samples: bpf: remove unneeded semicolon

2021-02-02 Thread Yang Li
Eliminate the following coccicheck warning: ./samples/bpf/cookie_uid_helper_example.c:316:3-4: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- samples/bpf/cookie_uid_helper_example.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf

[PATCH] mt76: mt7915: remove unneeded semicolon

2021-02-02 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/net/wireless/mediatek/mt76/mt7915/mac.c:1694:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] octeontx2-af: remove unneeded semicolon

2021-02-02 Thread Yang Li
semicolon ./drivers/net/ethernet/marvell/octeontx2/af/rvu.c:1326:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +- drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 ++-- drivers/net/ethernet/marvell

[PATCH 4/4] cxgb4: remove redundant NULL check

2021-01-26 Thread Yang Li
Fix below warnings reported by coccicheck: ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 6 ++ 1 file

[PATCH 1/4] cxgb4: remove redundant NULL check

2021-01-26 Thread Yang Li
Fix below warnings reported by coccicheck: ./drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c:327:3-9: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c | 3 +-- 1 file changed, 1

[PATCH 2/4] cxgb4: remove redundant NULL check

2021-01-26 Thread Yang Li
Fix below warnings reported by coccicheck: ./drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3558:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 3 +-- 1 file changed, 1

[PATCH net-next] cxgb4: remove redundant NULL check

2021-01-26 Thread Yang Li
/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:157:2-7: WARNING: NULL check before some freeing functions is not needed. ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:525:3-9: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li

[PATCH 3/4] cxgb4: remove redundant NULL check

2021-01-25 Thread Yang Li
Fix below warnings reported by coccicheck: ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:161:2-7: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 3 +-- 1 file changed

[PATCH v2] rtw88: Simplify bool comparison

2021-01-12 Thread YANG LI
Fix the following coccicheck warning: ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING: Comparison of 0/1 to bool variable Reported-by: Abaci Robot Signed-off-by: YANG LI --- Changes in v2: make "rtw88:" as subject prefix drivers/net/wireless/realtek/rtw88/debug.c

[PATCH] wireless: realtek: Simplify bool comparison

2021-01-12 Thread YANG LI
Fix the following coccicheck warning: ./drivers/net/wireless/realtek/rtlwifi/ps.c:803:7-21: WARNING: Comparison to bool Reported-by: Abaci Robot Signed-off-by: YANG LI --- drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

2021-01-12 Thread YANG LI
Fix the following coccicheck warning: ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: WARNING: Comparison of 0/1 to bool variable Reported-by: Abaci Robot Signed-off-by: YANG LI --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] scsi: qedf: style: Simplify bool comparison

2021-01-11 Thread YANG LI
Fix the following coccicheck warning: ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool Signed-off-by: YANG LI Reported-by: Abaci Robot --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b

[PATCH] hci: llc_shdlc: style: Simplify bool comparison

2021-01-11 Thread YANG LI
Fix the following coccicheck warning: ./net/nfc/hci/llc_shdlc.c:239:5-21: WARNING: Comparison to bool Signed-off-by: YANG LI Reported-by: Abaci Robot --- net/nfc/hci/llc_shdlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c

[PATCH] rtw88: debug: style: Simplify bool comparison

2021-01-11 Thread YANG LI
Fix the following coccicheck warning: ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING: Comparison of 0/1 to bool variable Signed-off-by: YANG LI Reported-by: Abaci Robot --- drivers/net/wireless/realtek/rtw88/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] ibmvnic: fix: NULL pointer dereference.

2020-12-29 Thread YANG LI
expression is true, scrq must be a null pointer and cannot dereference. Signed-off-by: YANG LI Reported-by: Abaci --- drivers/net/ethernet/ibm/ibmvnic.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmv

[PATCH] 9p: fix: Uninitialized variable p.

2020-12-29 Thread YANG LI
The pointer p is being used but it isn't being initialized, need to assign a NULL to it. Signed-off-by: YANG LI Reported-by: Abaci --- net/9p/trans_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c index 93f2f86..d4

[PATCH] liquidio: fix: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'.

2020-12-29 Thread YANG LI
For safety, modify '%u' to '%d' to keep the type consistent. Signed-off-by: YANG LI Reported-by: Abaci --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_c

[PATCH] mlx4: style: replace zero-length array with flexible-array member.

2020-12-29 Thread YANG LI
ed[2]. [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.9/process/ deprecated.html#zero-length-and-one-element-arrays Signed-off-by: YANG LI Reported-by: Abaci --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0.

2020-12-29 Thread YANG LI
: YANG LI Reported-by: Abaci --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 37d0641..cff18a0 100644 --- a/drivers/net

[PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0.

2020-12-29 Thread YANG LI
: YANG LI Reported-by: Abaci --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 37d0641..6e2426f 100644 --- a/drivers/net

[PATCH] bpf: fix: symbol 'btf_vmlinux' was not declared.

2020-12-24 Thread YANG LI
Symbol 'btf_vmlinux' was not declared in the header file and does not add extern, so no other file uses it. It's better to add static to it. Signed-off-by: YANG LI Reported-by: Abaci --- kernel/bpf/verifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH] bpf: fix: address of local auto-variable assigned to a function parameter.

2020-12-23 Thread YANG LI
off-by: YANG LI Reported-by: Abaci --- kernel/bpf/devmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c index f6e9c68..af6f004 100644 --- a/kernel/bpf/devmap.c +++ b/kernel/bpf/devmap.c @@ -454,7 +454,7 @@ static struct xdp_b