On Fri, Aug 9, 2019 at 6:35 AM Daniel T. Lee wrote:
>
> By this commit, using `bpftool net detach`, the attached XDP prog can
> be detached. Detaching the BPF prog will be done through libbpf
> 'bpf_set_link_xdp_fd' with the progfd set to -1.
>
> Signed-off-by: Daniel T. Lee
> ---
> tools/bpf/bp
On Fri, Aug 9, 2019 at 6:35 AM Daniel T. Lee wrote:
>
> By this commit, using `bpftool net attach`, user can attach XDP prog on
> interface. New type of enum 'net_attach_type' has been made, as stated at
> cover-letter, the meaning of 'attach' is, prog will be attached on interface.
>
> With 'over
On Thu, Aug 8, 2019 at 12:43 PM Toke Høiland-Jørgensen wrote:
>
> Alexei Starovoitov writes:
>
> > On Fri, Jul 26, 2019 at 9:06 AM Toke Høiland-Jørgensen
> > wrote:
> >>
> >> This series adds a new map type, devmap_hash, that works like the existing
> >> devmap type, but using a hash-based inde
On Wed, Aug 7, 2019 at 1:40 PM Maciej Fijalkowski
wrote:
>
> On Wed, 7 Aug 2019 13:12:17 -0700
> Y Song wrote:
>
> > On Wed, Aug 7, 2019 at 11:30 AM Maciej Fijalkowski
> > wrote:
> > >
> > > On Wed, 7 Aug 2019 10:02:04 -0700
> > > Y Song
On Thu, Aug 8, 2019 at 9:17 AM Jesper Dangaard Brouer wrote:
>
> This address the TODO in samples/bpf/xdp_fwd_kern.c, which points out
> that the chosen egress index should be checked for existence in the
> devmap. This can now be done via taking advantage of Toke's work in
> commit 0cdbb4b09a06 (
On Thu, Aug 8, 2019 at 10:52 AM Carlos Antonio Neira Bustos
wrote:
>
> Yonghong,
>
> I have modified the patch following your feedback.
> Let me know if I'm missing something.
Yes, I have some other requests about formating.
https://lore.kernel.org/netdev/20190808174848.poybtaagg5ctle7t@dev00/T/#
On Wed, Aug 7, 2019 at 11:30 AM Maciej Fijalkowski
wrote:
>
> On Wed, 7 Aug 2019 10:02:04 -0700
> Y Song wrote:
>
> > On Tue, Aug 6, 2019 at 7:25 PM Daniel T. Lee wrote:
> > >
> > > By this commit, using `bpftool net detach`, the attached XDP prog can
>
On Wed, Aug 7, 2019 at 5:38 AM Jesper Dangaard Brouer wrote:
>
> Make it clear that this XDP program depend on the network
> stack to do the ARP resolution. This is connected with the
> BPF_FIB_LKUP_RET_NO_NEIGH return code from bpf_fib_lookup().
>
> Another common mistake (seen via XDP-tutorial)
On Wed, Aug 7, 2019 at 5:37 AM Jesper Dangaard Brouer wrote:
>
> This address the TODO in samples/bpf/xdp_fwd_kern.c, which points out
> that the chosen egress index should be checked for existence in the
> devmap. This can now be done via taking advantage of Toke's work in
> commit 0cdbb4b09a06 (
On Wed, Aug 7, 2019 at 5:37 AM Jesper Dangaard Brouer wrote:
>
> The devmap name 'tx_port' came from a copy-paste from xdp_redirect_map
> which only have a single TX port. Change name to xdp_tx_ports
> to make it more descriptive.
>
> Signed-off-by: Jesper Dangaard Brouer
Acked-by: Yonghong Song
On Tue, Aug 6, 2019 at 7:25 PM Daniel T. Lee wrote:
>
> By this commit, using `bpftool net detach`, the attached XDP prog can
> be detached. Detaching the BPF prog will be done through libbpf
> 'bpf_set_link_xdp_fd' with the progfd set to -1.
>
> Signed-off-by: Daniel T. Lee
> ---
> tools/bpf/bp
On Tue, Aug 6, 2019 at 7:25 PM Daniel T. Lee wrote:
>
> By this commit, using `bpftool net attach`, user can attach XDP prog on
> interface. New type of enum 'net_attach_type' has been made, as stated at
> cover-letter, the meaning of 'attach' is, prog will be attached on interface.
>
> With 'over
On Tue, Aug 6, 2019 at 5:20 PM Jakub Kicinski
wrote:
>
> Hi!
>
> First make sure we don't use "prog" in error messages because
> the pinning operation could be performed on a map. Second add
> back missing error message if pin syscall failed.
>
> Jakub Kicinski (2):
> tools: bpftool: fix error m
ied for our custom use case.
> >
> > The Linux kernel provides a single abstraction for the src port for UDP
> > tunneling
> > via udp_flow_src_port. If it's improved eBPF filters would benefit if the
> > call is the same.
> >
> > Exposing this fun
On Sat, Aug 3, 2019 at 8:29 PM Farid Zakaria wrote:
>
> Foo over UDP uses UDP encapsulation to add additional entropy
> into the packets so that they get beter distribution across EMCP
> routes.
>
> Expose udp_flow_src_port as a bpf helper so that tunnel filters
> can benefit from the helper.
>
>
On Thu, Aug 1, 2019 at 1:33 AM Daniel T. Lee wrote:
>
> Currently, bpftool net only supports dumping progs attached on the
> interface. To attach XDP prog on interface, user must use other tool
> (eg. iproute2). By this patch, with `bpftool net attach/detach`, user
> can attach/detach XDP prog on
On Thu, Aug 1, 2019 at 2:04 AM Daniel T. Lee wrote:
>
> By this commit, using `bpftool net detach`, the attached XDP prog can
> be detached. Detaching the BPF prog will be done through libbpf
> 'bpf_set_link_xdp_fd' with the progfd set to -1.
>
> Signed-off-by: Daniel T. Lee
> ---
> Changes in v2
On Thu, Aug 1, 2019 at 2:04 AM Daniel T. Lee wrote:
>
> By this commit, using `bpftool net attach`, user can attach XDP prog on
> interface. New type of enum 'net_attach_type' has been made, as stated at
> cover-letter, the meaning of 'attach' is, prog will be attached on interface.
>
> BPF prog w
On Fri, Jul 19, 2019 at 7:35 AM Arnaldo Carvalho de Melo
wrote:
>
> From: Arnaldo Carvalho de Melo
>
> Using endian.h and its endianness macros makes this code build in a
> wider range of compilers, as some don't have those macros
> (__BYTE_ORDER__, __ORDER_LITTLE_ENDIAN__, __ORDER_BIG_ENDIAN__),
On Thu, Jul 18, 2019 at 8:01 AM Ilya Leoshkevich wrote:
>
> The very first check in test_pkt_md_access is failing on s390, which
> happens because loading a part of a struct __sk_buff field produces
> an incorrect result.
>
> The preprocessed code of the check is:
>
> {
> __u8 tmp = *((vol
On Wed, Jul 17, 2019 at 1:52 PM Ilya Leoshkevich wrote:
>
> > Am 17.07.2019 um 18:25 schrieb Y Song :
> >
> > On Wed, Jul 17, 2019 at 3:36 AM Ilya Leoshkevich wrote:
> >>
> >>
> >> Here is a better one: len=0x11223344 and we would like to do
>
On Wed, Jul 17, 2019 at 3:36 AM Ilya Leoshkevich wrote:
>
> > Am 17.07.2019 um 11:21 schrieb Ilya Leoshkevich :
> >
> >> Am 17.07.2019 um 07:11 schrieb Y Song :
> >>
> >> [sorry, resend again as previous one has come text messed out due to
> >> n
[sorry, resend again as previous one has come text messed out due to
networking issues]
On Tue, Jul 16, 2019 at 10:08 PM Y Song wrote:
>
> On Tue, Jul 16, 2019 at 4:59 AM Ilya Leoshkevich wrote:
> >
> > test_pkt_md_access is failing on s390, since the associated eBP
On Tue, Jul 16, 2019 at 4:59 AM Ilya Leoshkevich wrote:
>
> test_pkt_md_access is failing on s390, since the associated eBPF prog
> returns TC_ACT_SHOT, which in turn happens because loading a part of a
> struct __sk_buff field produces an incorrect result.
>
> The problem is that when verifier em
On Fri, Jul 12, 2019 at 11:24 AM Andrii Nakryiko
wrote:
>
> On Fri, Jul 12, 2019 at 10:46 AM Ilya Leoshkevich wrote:
> >
> > Many s390 setups (most notably, KVM guests) do not have access to
> > hardware performance events.
> >
> > Therefore, use the software event instead.
> >
> > Signed-off-by:
On Mon, Jul 8, 2019 at 2:55 AM Toke Høiland-Jørgensen wrote:
>
> Y Song writes:
>
> > On Sat, Jul 6, 2019 at 1:48 AM Toke Høiland-Jørgensen
> > wrote:
> >>
> >> From: Toke Høiland-Jørgensen
> >>
> >> A common pattern when using xd
On Sat, Jul 6, 2019 at 1:48 AM Toke Høiland-Jørgensen wrote:
>
> From: Toke Høiland-Jørgensen
>
> A common pattern when using xdp_redirect_map() is to create a device map
> where the lookup key is simply ifindex. Because device maps are arrays,
> this leaves holes in the map, and the map has to b
On Sat, Jul 6, 2019 at 1:47 AM Toke Høiland-Jørgensen wrote:
>
> From: Toke Høiland-Jørgensen
>
> The subsequent patch to add a new devmap sub-type can re-use much of the
> initialisation and allocation code, so refactor it into separate functions.
>
> Signed-off-by: Toke Høiland-Jørgensen
Acke
On Sat, Jul 6, 2019 at 1:47 AM Toke Høiland-Jørgensen wrote:
>
> From: Toke Høiland-Jørgensen
>
> When we changed the device and CPU maps to use linked lists instead of
> bitmaps, we also removed the need for the map_insert_ctx() helpers to keep
> track of the bitmaps inside each map. However, it
On Sat, Jul 6, 2019 at 1:47 AM Toke Høiland-Jørgensen wrote:
>
> This series adds a new map type, devmap_hash, that works like the existing
> devmap type, but using a hash-based indexing scheme. This is useful for the
> use
> case where a devmap is indexed by ifindex (for instance for use with th
On Fri, Jul 5, 2019 at 11:14 AM Toke Høiland-Jørgensen wrote:
>
> From: Toke Høiland-Jørgensen
>
> A common pattern when using xdp_redirect_map() is to create a device map
> where the lookup key is simply ifindex. Because device maps are arrays,
> this leaves holes in the map, and the map has to
On Fri, Jul 5, 2019 at 10:54 AM Quentin Monnet
wrote:
>
> Add a new "bpftool prog run" subcommand to run a loaded program on input
> data (and possibly with input context) passed by the user.
>
> Print output data (and output context if relevant) into a file or into
> the console. Print return val
On Fri, Jul 5, 2019 at 9:03 AM Quentin Monnet
wrote:
>
> 2019-07-05 08:42 UTC-0700 ~ Y Song
> > On Fri, Jul 5, 2019 at 1:21 AM Quentin Monnet
> > wrote:
> >>
> >> 2019-07-04 22:49 UTC-0700 ~ Y Song
> >>> On Thu, Jul 4, 2019 at 1:58 AM Quen
On Fri, Jul 5, 2019 at 1:21 AM Quentin Monnet
wrote:
>
> 2019-07-04 22:49 UTC-0700 ~ Y Song
> > On Thu, Jul 4, 2019 at 1:58 AM Quentin Monnet
> > wrote:
> >>
> >> Add a new "bpftool prog run" subcommand to run a loaded program on input
> >&g
On Thu, Jul 4, 2019 at 1:58 AM Quentin Monnet
wrote:
>
> Add a new "bpftool prog run" subcommand to run a loaded program on input
> data (and possibly with input context) passed by the user.
>
> Print output data (and output context if relevant) into a file or into
> the console. Print return valu
On Thu, Jul 4, 2019 at 1:52 AM Ilya Leoshkevich wrote:
>
> BPF_LDX_MEM is used to load the least significant byte of the retrieved
> test_val.index, however, on big-endian machines it ends up retrieving
> the most significant byte.
>
> Use the correct least significant byte offset on big-endian ma
On Wed, Jul 3, 2019 at 1:51 PM Stanislav Fomichev wrote:
>
> Take the first x bytes of pt_regs for scalability tests, there is
> no real reason we need x86 specific rax.
>
> Signed-off-by: Stanislav Fomichev
> ---
> tools/testing/selftests/bpf/progs/loop1.c | 3 ++-
> tools/testing/selftests/bpf
On Wed, Jul 3, 2019 at 2:31 PM Stanislav Fomichev wrote:
>
> Commit 2589726d12a1 ("bpf: introduce bounded loops") caused a change
> in the way some registers liveliness is reported in the test_align.
> Add missing "_w" to a couple of tests. Note, there are no offset
> changes!
>
> Fixes: 2589726d1
On Wed, Jul 3, 2019 at 9:06 AM Ilya Leoshkevich wrote:
>
> BPF_LDX_MEM is used to load the least significant byte of the retrieved
> test_val.index, however, on big-endian machines it ends up retrieving
> the most significant byte.
>
> Use the correct least significant byte offset on big-endian ma
On Wed, Jul 3, 2019 at 1:10 PM Stanislav Fomichev wrote:
>
> Forgot to add it in the original patch.
>
> Fixes: b55873984dab ("selftests/bpf: test BPF_SOCK_OPS_RTT_CB")
> Reported-by: Andrii Nakryiko
> Signed-off-by: Stanislav Fomichev
Acked-by: Yonghong Song
> ---
> tools/testing/selftests/
On Fri, Jun 28, 2019 at 8:26 AM Andrii Nakryiko wrote:
>
> Change BTF-defined map definitions to capture compile-time integer
> values as part of BTF type definition, to avoid split of key/value type
> information and actual type/size/flags initialization for maps.
>
> Signed-off-by: Andrii Nakryi
On Tue, Jul 2, 2019 at 10:41 AM Jiri Benc wrote:
>
> Selftests are reporting this failure in test_lwt_seg6local.sh:
>
> + ip netns exec ns2 ip -6 route add fb00::6 encap bpf in obj
> test_lwt_seg6local.o sec encap_srh dev veth2
> Error fetching program/map!
> Failed to parse eBPF program: Operati
On Tue, Jul 2, 2019 at 9:14 AM Stanislav Fomichev wrote:
>
> Congestion control team would like to have a periodic callback to
> track some TCP statistics. Let's add a sock_ops callback that can be
> selectively enabled on a socket by socket basis and is executed for
> every RTT. BPF program frequ
On Tue, Jul 2, 2019 at 8:40 AM Ilya Leoshkevich wrote:
>
> Use PT_REGS_RC(ctx) instead of ctx->rax, which is not present on s390.
>
> Pass -D__TARGET_ARCH_$(ARCH) to selftests in order to choose a proper
> PT_REGS_RC variant.
>
> Fix s930 -> s390 typo.
>
> On s390, provide the forward declaration
On Tue, Jul 2, 2019 at 9:58 AM Ilya Leoshkevich wrote:
>
> > Am 02.07.2019 um 18:42 schrieb Y Song :
> >
> > On Tue, Jul 2, 2019 at 8:40 AM Ilya Leoshkevich wrote:
> >>
> >> -#elif defined(__s390x__)
> >> - #define bpf_target_s930x
>
On Tue, Jul 2, 2019 at 8:40 AM Ilya Leoshkevich wrote:
>
> Use PT_REGS_RC(ctx) instead of ctx->rax, which is not present on s390.
>
> Pass -D__TARGET_ARCH_$(ARCH) to selftests in order to choose a proper
> PT_REGS_RC variant.
>
> Fix s930 -> s390 typo.
>
> On s390, provide the forward declaration
On Tue, Jul 2, 2019 at 8:17 AM Andrii Nakryiko wrote:
>
> GCC8 started emitting warning about using strncpy with number of bytes
> exactly equal destination size, which is generally unsafe, as can lead
> to non-zero terminated string being copied. Use IFNAMSIZ - 1 as number
> of bytes to ensure na
On Mon, Jul 1, 2019 at 10:47 PM Andrii Nakryiko wrote:
>
> GCC8 started emitting warning about using strncpy with number of bytes
> exactly equal destination size, which is generally unsafe, as can lead
> to non-zero terminated string being copied. Use IFNAMSIZ - 1 as number
> of bytes to ensure n
On Mon, Jul 1, 2019 at 5:31 PM Stanislav Fomichev wrote:
>
> On 07/01, Y Song wrote:
> > On Mon, Jul 1, 2019 at 1:49 PM Stanislav Fomichev wrote:
> > >
> > > Uses new RTT callback to dump stats every second.
> > >
> > > $ mkdir -p /tmp/cgro
On Mon, Jul 1, 2019 at 5:07 PM Stanislav Fomichev wrote:
>
> On 07/01, Y Song wrote:
> > On Mon, Jul 1, 2019 at 1:49 PM Stanislav Fomichev wrote:
> > >
> > > Make sure the callback is invoked for syn-ack and data packet.
> > >
> > > Cc: Eric Dumaz
On Mon, Jul 1, 2019 at 1:49 PM Stanislav Fomichev wrote:
>
> Uses new RTT callback to dump stats every second.
>
> $ mkdir -p /tmp/cgroupv2
> $ mount -t cgroup2 none /tmp/cgroupv2
> $ mkdir -p /tmp/cgroupv2/foo
> $ echo $$ >> /tmp/cgroupv2/foo/cgroup.procs
> $ bpftool prog load ./tcp_dumpstats_ker
On Mon, Jul 1, 2019 at 1:49 PM Stanislav Fomichev wrote:
>
> Make sure the callback is invoked for syn-ack and data packet.
>
> Cc: Eric Dumazet
> Cc: Priyaranjan Jha
> Cc: Yuchung Cheng
> Cc: Soheil Hassas Yeganeh
> Signed-off-by: Stanislav Fomichev
> ---
> tools/testing/selftests/bpf/Makef
On Sat, Jun 29, 2019 at 11:05 AM Song Liu wrote:
>
> On Sat, Jun 29, 2019 at 11:04 AM Song Liu wrote:
> >
> > On Sat, Jun 29, 2019 at 7:43 AM Jiri Benc wrote:
> > >
> > > Selftests are reporting this failure in test_lwt_seg6local.sh:
> > >
> > > + ip netns exec ns2 ip -6 route add fb00::6 encap
On Sun, May 26, 2019 at 3:35 AM Chang-Hsien Tsai wrote:
>
> use fgets() as the while loop condition.
>
> Signed-off-by: Chang-Hsien Tsai
Looks like right now we did not really differentiate error in fgets from EOF,
so the change is in this patch is equivalent to its previous behavior.
Acked-by:
On Fri, May 24, 2019 at 3:29 PM Stanislav Fomichev wrote:
>
> Right now test_tunnel.sh always exits with success even if some
> of the subtests fail. Since the output is very verbose, it's
> hard to spot the issues with subtests. Let's fail the script
> if any subtest fails.
>
> Signed-off-by: Sta
On Thu, May 23, 2019 at 12:26 AM Daniel T. Lee wrote:
>
> This commit fixes style problem in samples/bpf/bpf_load.c
>
> Styles that have been changed are:
> - Magic string use of 'DEBUGFS'
> - Useless zero initialization of a global variable
> - Minor style fix with whitespace
>
> Signed-off-by
On Wed, May 22, 2019 at 1:46 PM Björn Töpel wrote:
>
> On Wed, 22 May 2019 at 20:13, Y Song wrote:
> >
> > On Wed, May 22, 2019 at 2:25 AM Björn Töpel wrote:
> > >
> > > Add three tests to test_verifier/basic_instr that make sure that the
> > >
On Wed, May 22, 2019 at 2:25 AM Björn Töpel wrote:
>
> Add three tests to test_verifier/basic_instr that make sure that the
> high 32-bits of the destination register is cleared after an ALU32
> and/or/xor.
>
> Signed-off-by: Björn Töpel
I think the patch intends for bpf-next, right? The patch i
On Fri, May 3, 2019 at 12:54 PM William Tu wrote:
>
> On Thu, May 2, 2019 at 1:18 PM Y Song wrote:
> >
> > On Thu, May 2, 2019 at 11:34 AM William Tu wrote:
> > >
> > > The libbpf_util.h is used by xsk.h, so add it to
> > > the install headers.
>
On Thu, May 2, 2019 at 11:34 AM William Tu wrote:
>
> The libbpf_util.h is used by xsk.h, so add it to
> the install headers.
Can we try to change code a little bit to avoid exposing libbpf_util.h?
Originally libbpf_util.h is considered as libbpf internal.
I am not strongly against this patch. Bu
On Tue, Apr 30, 2019 at 2:34 AM Quentin Monnet
wrote:
>
> Hi Yonghong,
>
> 2019-04-29 16:32 UTC-0700 ~ Y Song
> > On Mon, Apr 29, 2019 at 2:53 AM Quentin Monnet
> > wrote:
> >>
> >> libbpf has three levels of priority for output: warn, info, debug. By
On Mon, Apr 29, 2019 at 2:53 AM Quentin Monnet
wrote:
>
> libbpf has three levels of priority for output: warn, info, debug. By
> default, debug output is not printed to stderr.
>
> Add a new "--log-libbpf LOG_LEVEL" option to bpftool to provide more
> flexibility on the log level for libbpf. LOG_
On Tue, Apr 23, 2019 at 6:02 PM Daniel T. Lee wrote:
>
> Oh, I've found what's the problem.
> About the files you've mentioned, nothing seems to matter on my system.
> But the problem is the order of the '-I' option matters.
>
> user@host:~/linux/samples/bpf $ make -n
>
> gcc -Wp,-MD,./sam
On Tue, Apr 23, 2019 at 1:26 PM Daniel T. Lee wrote:
>
> Currently, building bpf samples will cause the following error.
>
> ./tools/lib/bpf/bpf.h:132:27: error: 'UINT32_MAX' undeclared here (not in
> a function) ..
> #define BPF_LOG_BUF_SIZE (UINT32_MAX >> 8) /* verifier maximum in
> k
On Mon, Apr 22, 2019 at 4:47 PM Willem de Bruijn
wrote:
>
> On Mon, Apr 22, 2019 at 7:40 PM Y Song wrote:
> >
> > On Mon, Apr 22, 2019 at 7:58 AM Willem de Bruijn
> > wrote:
> > >
> > > From: Willem de Bruijn
> > >
> > > So far,
On Mon, Apr 22, 2019 at 7:58 AM Willem de Bruijn
wrote:
>
> From: Willem de Bruijn
>
> So far, all BPF tc tunnel testcases encapsulate in the same network
> protocol. Add an encap testcase that requires updating skb->protocol.
>
> The 6in4 tunnel encapsulates an IPv6 packet inside an IPv4 tunnel.
On Mon, Apr 22, 2019 at 7:58 AM Willem de Bruijn
wrote:
>
> From: Willem de Bruijn
>
> Some tunnels, like sit, change the network protocol of packet.
> If so, update skb->protocol to match the new type.
>
> Signed-off-by: Willem de Bruijn
Acked-by: Yonghong Song
> ---
> net/core/filter.c | 8
On Fri, Apr 19, 2019 at 12:32 PM rjmccabe3701
wrote:
>
> From: "McCabe, Robert J"
>
> The BPF_PROG_LOAD condition for kernel version <= 5.1 is
>
>log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
>
> Signed-off-by: McCabe, Robert J
Acked-by: Yonghong Song
> ---
> tools/lib/bpf/
On Thu, Apr 18, 2019 at 12:23 AM Magnus Karlsson
wrote:
>
> Having a helpful compile time warning in libbpf_util.h is not a good
> idea since all warnings are treated as errors. Change this into a
> comment in the code instead.
>
> Fixes: b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xs
On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson
wrote:
>
> The use of smp_rmb() and smp_wmb() creates a Linux header dependency
> on barrier.h that is uneccessary in most parts. This patch implements
> the two small defines that are needed from barrier.h. As a bonus, the
> new implementations are
On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson
wrote:
>
> This patch removes the use of likely and unlikely in xsk.h since they
> create a dependency on Linux headers as reported by several
> users. There have also been reports that the use of these decreases
> performance as the compiler puts t
On Tue, Apr 9, 2019 at 11:55 PM Magnus Karlsson
wrote:
>
> In commit da11b417583e ("libbpf: teach libbpf about log_level bit 2"),
> the BPF_LOG_BUF_SIZE was increased to 16M. The XDP socket part of
> libbpf allocated the log_buf on the stack, but for the new 16M buffer
> size this is not going to
On Mon, Mar 18, 2019 at 6:03 AM Naresh Kamboju
wrote:
>
> selftests: bpf: test_align failed on all devices ( arm64, armv7,
> x86_64 and i386) running Linux -next kernel 5.1.0-rc1 tag:
> next-20190318.
>
> Here is the log from arm64,
>
> selftests: bpf: test_align
> Test 0: mov ... Failed to find
On Mon, Mar 11, 2019 at 12:32 PM Martynas Pumputis wrote:
>
> It has been observed that sometimes a higher order memory allocation
> for BPF maps fails when there is no obvious memory pressure in a system.
>
> E.g. the map (BPF_MAP_TYPE_LRU_HASH, key=38, value=56, max_elems=524288)
> could not be
On Thu, Mar 7, 2019 at 10:12 PM Bo YU wrote:
>
> Sparse warning below:
>
> sudo make C=2 CF=-D__CHECK_ENDIAN__ M=net/bpf/
> CHECK net/bpf//test_run.c
> net/bpf//test_run.c:19:77: warning: Using plain integer as NULL pointer
> ./include/linux/bpf-cgroup.h:295:77: warning: Using plain integer as N
On Wed, Mar 6, 2019 at 1:15 PM Willem de Bruijn
wrote:
>
> From: Willem de Bruijn
>
> BPF can adjust gso only for tcp bytestreams. Fail on other gso types.
>
> But only on gso packets. It does not touch this field if !gso_size.
Could you specify which field you are referring here?
gso_type, gso_s
On Wed, Mar 6, 2019 at 1:14 PM Stanislav Fomichev wrote:
>
> libbpf targets don't explicitly depend on fixdep target, so when
> we do 'make -j$(nproc)', there is a high probability, that some
> objects will be built before fixdep binary is available.
>
> Fix this by running sub-make; this makes su
On Wed, Mar 6, 2019 at 1:14 PM Stanislav Fomichev wrote:
>
> A bunch of related changes lumped together:
> * Create prog_tests and verifier output directories; these don't exist with
> out-of-tree $(OUTPUT)
> * Add missing -I (via separate TEST_{PROGS,VERIFIER}_CFLAGS) for the main tree
> ($(P
On Wed, Mar 6, 2019 at 3:25 PM Stanislav Fomichev wrote:
>
> CHECK macro implicitly uses duration. We call CHECK() a couple of times
> before duration is initialized from bpf_prog_test_run().
> Explicitly set duration to 0 to avoid compiler warnings.
>
> Fixes: 740f8a657221 ("selftests/bpf: make s
FYI.The latest llvm trunk will not emit errors for static variables. The patch
also gives detailed information how to relate a particular static
variable to a particular
relocation.
https://reviews.llvm.org/rL354954
Thanks,
Yonghong
On Fri, Feb 15, 2019 at 12:18 PM Y Song wrote:
>
>
On Thu, Feb 14, 2019 at 11:16 PM Joe Stringer wrote:
>
> On Thu, 14 Feb 2019 at 21:39, Y Song wrote:
> >
> > On Mon, Feb 11, 2019 at 4:48 PM Joe Stringer wrote:
> > >
> > > Support loads of static 32-bit data when BPF writers make use of
> > > conven
On Mon, Feb 11, 2019 at 4:48 PM Joe Stringer wrote:
>
> Support loads of static 32-bit data when BPF writers make use of
> convenience macros for accessing static global data variables. A later
> patch in this series will demonstrate its usage in a selftest.
>
> As of LLVM-7, this technique only w
On Tue, Feb 5, 2019 at 6:26 PM Prashant Bhole
wrote:
>
> Documentation about cgroup, feature, prog uses wrong header
> 'MAP COMMANDS' while listing commands. This patch corrects the header
> in respective doc files.
>
> Signed-off-by: Prashant Bhole
Acked-by: Yonghong Song
> ---
> tools/bpf/b
On Tue, Feb 5, 2019 at 6:25 PM Prashant Bhole
wrote:
>
> This patch adds missing information about feature-subcommand in
> bpftool.rst
>
> Signed-off-by: Prashant Bhole
Acked-by: Yonghong Song
> ---
> tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 d
On Mon, Feb 4, 2019 at 9:49 AM Stanislav Fomichev wrote:
>
> On 02/01, Dmitry Vyukov wrote:
> > Hello,
> >
> > The following program leads to an unkillable process that eats CPU in
> > an infinite loop in BPF_PROG_TEST_RUN syscall. But kernel does not
> > self-detect cpu/rcu/task stalls either. Th
On Sun, Feb 3, 2019 at 12:18 AM Yafang Shao wrote:
>
> Then we can enable/disable socket debugging without modifying user code.
> That is more convenient for debugging.
>
> Signed-off-by: Yafang Shao
Acked-by: Yonghong Song
> ---
> include/net/sock.h | 8
> net/core/filter.c | 3 +++
On Fri, Feb 1, 2019 at 3:49 PM Stanislav Fomichev wrote:
>
> 'make clean' is supposed to remove generated files.
>
> Signed-off-by: Stanislav Fomichev
Acked-by: Yonghong Song
> ---
> tools/testing/selftests/bpf/Makefile | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
On Tue, Jan 29, 2019 at 7:13 AM Magnus Karlsson
wrote:
>
> Move the pr_*() functions in libbpf.c to a common header file called
> libbpf_internal.h. This so that the later libbpf AF_XDP helper library
> code in xsk.c can use these printing functions too.
>
> Signed-off-by: Magnus Karlsson
> ---
>
On Thu, Jan 31, 2019 at 1:18 AM Martynas Pumputis wrote:
>
> Previously, bpf_num_possible_cpus() had a bug when calculating a
> number of possible CPUs in the case of sparse CPU allocations, as
> it was considering only the first range or element of
> /sys/devices/system/cpu/possible.
>
> E.g. in
On Wed, Jan 30, 2019 at 6:05 AM Martynas Pumputis wrote:
>
> Previously, memory allocated for a map was not accounted. Therefore,
> this memory could not be taken into consideration by the cgroups
> memory controller.
>
> This patch introduces the "BPF_F_ACCOUNT_MEM" flag which enables
> the memor
[ My reply somehow rejected by netdev, this is to send it again. ]
On Wed, Jan 30, 2019 at 1:19 AM Martynas Pumputis wrote:
>
> Previously, bpf_num_possible_cpus() had a bug when calculating a
> number of possible CPUs in the case of sparse CPU allocations, as
> it was considering only the first
On Fri, Jan 4, 2019 at 6:27 AM Quentin Monnet
wrote:
>
> 2019-01-03 22:35 UTC-0800 ~ Y Song
> > On Thu, Jan 3, 2019 at 9:27 AM Quentin Monnet
> > wrote:
> >>
> >> Add probes to dump a number of options set (or not set) for compiling
> >> the kerne
On Thu, Jan 3, 2019 at 12:02 PM Stanislav Fomichev wrote:
>
> create_and_get_cgroup returns 0 on error, fix the users that assume
> negative value in case of an error.
>
> Signed-off-by: Stanislav Fomichev
Thanks for the fix!
Acked-by: Yonghong Song
> ---
> tools/testing/selftests/bpf/get_cgr
On Thu, Jan 3, 2019 at 9:27 AM Quentin Monnet
wrote:
>
> Add probes to dump a number of options set (or not set) for compiling
> the kernel image. These parameters provide information about what BPF
> components should be available on the system. A number of them are not
> directly related to eBPF
On Thu, Jan 3, 2019 at 9:26 AM Quentin Monnet
wrote:
>
> Add a set of probes to dump the eBPF-related parameters available from
> /proc/: availability of bpf() syscall for unprivileged users,
> JIT compiler status and hardening status, kallsyms exports status.
>
> Sample output:
>
> # bpftool
On Wed, Nov 21, 2018 at 3:44 AM Naresh Kamboju
wrote:
>
> Kselftest bpf get_cgroup_id_user is failed on all devices.
>
> selftests: bpf: get_cgroup_id_user
> main:PASS:setup_cgroup_environment
> main:PASS:create_and_get_cgroup
> main:PASS:join_cgroup
> main:PASS:bpf_prog_load
> main:PASS:bpf_find_
On Tue, Nov 20, 2018 at 1:37 PM Stanislav Fomichev wrote:
>
> Wrap headers in extern "C", to turn off C++ mangling.
> This simplifies including libbpf in c++ and linking against it.
>
> v2 changes:
> * do the same for btf.h
>
> Signed-off-by: Stanislav Fomichev
Acked-by: Yonghong Song
> ---
>
On Tue, Nov 20, 2018 at 10:19 AM Stanislav Fomichev wrote:
>
> Wrap headers in extern "C", to turn off C++ mangling.
> This simplifies including libbpf in c++ and linking against it.
>
> Signed-off-by: Stanislav Fomichev
> ---
> tools/lib/bpf/bpf.h| 9 +
> tools/lib/bpf/libbpf.h | 9
On Tue, Nov 20, 2018 at 7:43 AM Lorenz Bauer wrote:
>
> Right now, there is no safe way to use BPF_PROG_TEST_RUN with data_out.
> This is because bpf_test_finish copies the output buffer to user space
> without checking its size. This can lead to the kernel overwriting
> data in user space after t
On Tue, Nov 20, 2018 at 3:35 AM Lorenz Bauer wrote:
>
> On Sun, 18 Nov 2018 at 05:59, Y Song wrote:
> >
> > On Fri, Nov 16, 2018 at 12:55 PM Lorenz Bauer wrote:
> > >
> > > Make sure that bpf_prog_test_run returns the correct length
> > > in the s
1 - 100 of 186 matches
Mail list logo
