Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-18 Thread Xue Liu
Hello Andreas, On Mon, 17 Dec 2018 at 15:19, Andreas Färber wrote: > > Hello Xue Liu, > > Am 17.12.18 um 09:50 schrieb Xue Liu: > > I have a question about the architecture of your module. AFAIK LoRaWAN > > is already the MAC Layer above the LoRa technology. Why do yo

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-17 Thread Xue Liu
Hello Jian-Hong, Thanks for your work in LoRaWAN. I have a question about the architecture of your module. AFAIK LoRaWAN is already the MAC Layer above the LoRa technology. Why do you want to make a new layer called "maclorawan" ? Regards, Xue Liu On Sun, 16 Dec 2018 at 11:20, Jia

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

2018-04-10 Thread Xue Liu
Hallo, Thanks for the fix. It looks good. ACK-by: Xue Liu On 5 April 2018 at 18:20, Gustavo A. R. Silva wrote: > Free allocated memory for pdata before return. > > Addresses-Coverity-ID: 1466096 ("Resource leak") > Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20