d86b76d>] __do_sys_finit_module+0xb5/0x120
[<2b0cef95>] do_syscall_64+0x33/0x40
[<67b45bbb>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy")
Cc: Ong Boon Leong
Signed-off-by: Wong Vee Khee
---
drivers/
-space using
application such as testptp or any other applications that uses the
PTP_EXTTS_REQUEST ioctl request.
Cc: Richard Cochran
Signed-off-by: Tan Tee Min
Co-developed-by: Wong Vee Khee
Signed-off-by: Wong Vee Khee
---
v3 -> v4:
- Group variable of same datatype together in onel
On Sun, Apr 11, 2021 at 08:10:55AM -0700, Richard Cochran wrote:
> On Sun, Apr 11, 2021 at 10:40:28AM +0800, Wong Vee Khee wrote:
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
> > b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
> > index 60566598d644
-space using
application such as testptp or any other applications that uses the
PTP_EXTTS_REQUEST ioctl request.
Cc: Richard Cochran
Signed-off-by: Tan Tee Min
Co-developed-by: Wong Vee Khee
Signed-off-by: Wong Vee Khee
---
v2 -> v3:
- Flip ext_snapshot_en condition check for early return.
On Fri, Apr 09, 2021 at 05:50:04PM -0700, Jakub Kicinski wrote:
> Other than the minor nit below LGTM. Let's give Richard one more day.
>
> On Thu, 8 Apr 2021 01:04:42 +0800 Wong Vee Khee wrote:
> > +static void timestamp_interrupt(struct stmmac_priv *priv)
> > +{
>
-space using
application such as testptp or any other applications that uses the
PTP_EXTTS_REQUEST ioctl request.
Cc: Richard Cochran
Signed-off-by: Tan Tee Min
Co-developed-by: Wong Vee Khee
Signed-off-by: Wong Vee Khee
---
v1 -> v2:
Changed from pr_info() to netdev_dbg().
.../net/ether
On Wed, Apr 07, 2021 at 04:21:09PM +0200, Andrew Lunn wrote:
> On Wed, Apr 07, 2021 at 10:15:37PM +0800, Wong Vee Khee wrote:
> > From: Tan Tee Min
> >
> > The Synopsis MAC controller supports auxiliary snapshot feature that
> > allows user to store a snapshot of
-space using
application such as testptp or any other applications that uses the
PTP_EXTTS_REQUEST ioctl request.
Signed-off-by: Tan Tee Min
Co-developed-by: Wong Vee Khee
Signed-off-by: Wong Vee Khee
---
.../net/ethernet/stmicro/stmmac/dwmac-intel.c | 11 +
drivers/net/ethernet/stmicro/stmmac
The member 'tx_lpi_timer' is defined with __u32 datatype in the ethtool
header file. Hence, we should use ethnl_update_u32() in set_eee ops.
Fixes: fd77be7bd43c ("ethtool: set EEE settings with EEE_SET request")
Cc: # 5.10.x
Cc: Michal Kubecek
Signed-off-by: Wong Vee Kh
On Tue, Apr 06, 2021 at 01:13:06PM +0300, Andy Shevchenko wrote:
> The PCI device IDs are defined with a prefix PCI_DEVICE_ID.
> There is no need to repeat the ID part at the end of each definition.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Wong Vee Khee
> ---
>
On Tue, Apr 06, 2021 at 12:33:57AM +0800, Voon Weifeng wrote:
>
> EHL PSE SGMII mode requires to ungate the SERDES PHY rx clk for power up
> sequence and vice versa.
>
> Signed-off-by: Voon Weifeng
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 10 ++
> drivers/net/ethernet
n moved to the newly created driver.
Removing this unnecessary pci_enable_msi() call as there are no other
devices that uses stmmac-pci and need MSI to be enabled.
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/
Update dwmac-intel to use managed function, i.e. pcim_enable_device().
This will allow devres framework to call resource free function for us.
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff
: Tan Tee Min
Co-developed-by: Wong Vee Khee
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac5.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac5.c
b/drivers/net
On Wed, Mar 31, 2021 at 13:58, Eric Dumazet wrote:
>
> On Wed, Mar 31, 2021 at 2:01 AM Wong, Vee Khee
> wrote:
> >
> > Hi all,
> >
> >
> >
> > This patch introduced the following massive warnings printouts on a
> >
> > Intel x86 A
Hi all,
This patch introduced the following massive warnings printouts on a
Intel x86 Alderlake platform with STMMAC MAC and Marvell 88E2110 PHY.
[ 149.674232] unregister_netdevice: waiting for sit0 to become free. Usage
count = 2
[ 159.930310] unregister_netdevice: waiting for sit0 to become
-off-by: Wong Vee Khee
---
.../net/ethernet/stmicro/stmmac/dwmac-intel.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
index 08b4852eed4c..3d9a57043af2 100644
--- a
On Thu, 25 March 2021, 11:13PM +800, Marek Szyprowski wrote:
> This patch landed in today's linux-next as commit 5a5586112b92 ("net:
> stmmac: support FPE link partner hand-shaking procedure"). It causes the
> following NULL pointer dereference issue on various Amlogic SoC based
> boards:
>
> m
Add support for PHY loopback for Marvell 88x2110 and Marvell 88x3310.
This allow user to perform PHY loopback test using ethtool selftest.
Signed-off-by: Wong Vee Khee
---
drivers/net/phy/marvell10g.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/marvell10g.c b/drivers
This patch series add support for Clause-45 PHY loopback.
It involves adding a generic API in the PHY framework, which can be
accessed by all C45 PHY drivers using the .set_loopback callback.
Also, enable PHY loopback for the Marvell 88x3310/88x2110 driver.
Wong Vee Khee (2):
net: phy: add
Add generic code to enable C45 PHY loopback into the common phy-c45.c
file. This will allow C45 PHY drivers aceess this by setting
.set_loopback.
Suggested-by: Heiner Kallweit
Signed-off-by: Wong Vee Khee
---
drivers/net/phy/phy-c45.c | 8
include/linux/phy.h | 1 +
2 files
().
Device time is stored in the MAC Auxiliary register. The 64-bit System
time (ART timestamp) is stored in registers that are only addressable
by using MDIO space.
Signed-off-by: Tan Tee Min
Co-developed-by: Wong Vee Khee
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/common.h
From: Tan Tee Min
Add support for PHY loopback for the Marvell 88E2110 PHY.
This allow user to perform selftest using ethtool.
Signed-off-by: Tan Tee Min
Signed-off-by: Wong Vee Khee
---
drivers/net/phy/marvell10g.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers
On Fri, Mar 19, 2021 at 04:56PM +0800, Russell King - ARM Linux admin wrote:
> On Fri, Mar 19, 2021 at 08:40:45AM +0100, Heiner Kallweit wrote:
>> Is there a specific reason why c22 is probed first? Reversing the order
>> would solve the issue we speak about here.
>> c45-probing of c22-only PHY's s
: phy: clean up get_phy_c22_id() invalid ID handling")
Cc: sta...@vger.kernel.org
Reviewed-by: Voon Weifeng
Signed-off-by: Wong Vee Khee
---
v2 changelog:
- added fixes tag
- marked for net instead of net-next
---
drivers/net/phy/phy_device.c | 4 ++--
1 file changed, 2 insertions(+), 2
> -Original Message-
> From: Heiner Kallweit
> Sent: Wednesday, March 17, 2021 4:15 PM
> To: Wong, Vee Khee ; Andrew Lunn
> ; Russell King ; David S . Miller
> ; Jakub Kicinski
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> sta...@vger.kernel
: Wong Vee Khee
---
.../net/ethernet/stmicro/stmmac/stmmac_main.c| 16
1 file changed, 16 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index a10704d8e3c6..ddf54b8ad75d 100644
--- a/drivers/net
Reviewed-by: Voon Weifeng
Signed-off-by: Wong Vee Khee
---
drivers/net/phy/phy_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index a009d1769b08..f1afc00fcba2 100644
--- a/drivers/net/phy/phy_device.c
+++ b
register
Fixes: 88af9bd4efbd ("stmmac: intel: Add ADL-S 1Gbps PCI IDs")
Fixes: 8450e23f142f ("stmmac: intel: Add PCI IDs for TGL-H platform")
Signed-off-by: Wong Vee Khee
---
.../net/ethernet/stmicro/stmmac/dwmac-intel.c | 54 ++-
1 file changed, 41 insertions(+), 13 de
This patch populates the PCI bus info in the ethtool driver query data.
Users will be able to view PCI bus info using 'ethtool -i '.
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c| 1 +
drivers/net/ethernet/stmicro/stmmac/stmmac_eth
From: "Wong, Vee Khee"
Added PCI IDs for both Ethernet TSN Controllers on the ADL-S.
Also, skip SerDes programming sequences as these are being carried out
at the BIOS level for ADL-S.
Signed-off-by: Wong, Vee Khee
---
.../net/ethernet/stmicro/stmmac/dwmac-intel.c | 19
> -Original Message-
> From: Jakub Kicinski
> Sent: Thursday, December 24, 2020 4:14 AM
> To: Zulkifli, Muhammad Husaini
> Cc: da...@davemloft.net; peppe.cavall...@st.com;
> alexandre.tor...@st.com; joab...@synopsys.com;
> netdev@vger.kernel.org; Ahmad Tarmizi, Noor Azura
> ; Voon, Wei
Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45.
This extended the probing of C45 PHY devices on the MDIO bus.
Signed-off-by: Wong Vee Khee
---
v2 changelog:
- Added conditional check for gmac4.
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 3 +++
1 file chang
> -Original Message-
> From: Andrew Lunn
> Sent: Thursday, December 10, 2020 12:09 AM
> To: Wong, Vee Khee
> Cc: Giuseppe Cavallaro ; Alexandre Torgue
> ; Jose Abreu ; David
> S . Miller ; Jakub Kicinski ;
> Maxime Coquelin ; Voon, Weifeng
> ; netdev@vg
Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45.
This extends the probing of C45 PHY devices on the MDIO bus.
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/s
ULLIER
Cc: Alexandre TORGUE
Reviewed-by: Ong Boon Leong
Signed-off-by: Wong Vee Khee
---
v2 changelog:
- Move rtnl_lock() before priv->lock and release it after to avoid a
possible ABBA deadlock scenario.
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++
1 file changed,
For clause 45 PHY, introduce additional logics in get_phy_c45_ids() to
check if there is at least one valid device ID, return 0 on true, and
-ENODEV otherwise.
Signed-off-by: Wong Vee Khee
---
drivers/net/phy/phy_device.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers
ULLIER
Cc: Alexandre TORGUE
Reviewed-by: Ong Boon Leong
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_ma
This patch makes mdiobus_scan() to try on C45 first as C45 can access
all devices. This allows the function available for the PHY that
supports for both C45 and C22.
Reviewed-by: Voon Weifeng
Reviewed-by: Ong Boon Leong
Signed-off-by: Wong Vee Khee
---
drivers/net/phy/mdio_bus.c | 5
From: Voon Weifeng
Set all EHL/TGL phy_addr to -1 so that the driver will automatically
detect it at run-time by probing all the possible 32 addresses.
Signed-off-by: Voon Weifeng
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 6 +-
1 file changed, 1
r LPI cntr")
Cc: Voon Weifeng
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
b/drivers/net/ethernet/stmicro/stmmac
intel: Fix clock handling on error and remove
paths")
Cc: Andy Shevchenko
Reviewed-by: Voon Weifeng
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
b/d
From: "Chuah, Kim Tatt"
Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail
Queuing. This option allows packets that fail VLAN filter to be routed
to a specific Rx queue when Receive All is also set.
When this option is enabled:
- Enable VFFQ only when entering promiscuous mode,
This is a follow-up on a earlier patch submission at:-
https://patchwork.ozlabs.org/patch/1275604/
Changes since the previous patch submission:
- Enable VLAN fail queue for Intel platform data (dwmac-intel).
- Steer the VLAN failed packet to the last Rx queue.
Chuah, Kim Tatt (1):
net: stmmac:
From: "Tan, Tee Min"
For driver open(), rtnl_lock is acquired by network stack but not in the
resume(). Therefore, we introduce lock_acquired boolean to control when
to use rtnl_lock|unlock() within stmmac_hw_setup().
Fixes: 686cff3d7022 ("net: stmmac: Fix incorrect location to set
real_num_rx|
From: "Song, Yoong Siang"
This patch add support to --show-ring & --set-ring Ethtool functions:
- Adding min, max, power of two check to new ring parameter's value.
- Bring down the network interface before changing the value of ring
parameters.
- Bring up the network interface after changing t
t; To: David Miller ; Wong, Vee Khee
>
> Cc: peppe.cavall...@st.com; alexandre.tor...@st.com;
> joab...@synopsys.com; mcoquelin.st...@gmail.com; k...@kernel.org;
> joao.pi...@synopsys.com; a...@arndb.de; li...@armlinux.org.uk;
> netdev@vger.kernel.org; linux-st...@st-md-mailman.stor
This patch set is to add support for user to get or set Tx/Rx channel
via ethtool. There are two patches that fixes bug introduced on upstream
in order to have the feature work.
Tested on Intel Tigerlake Platform.
Aashish Verma (1):
net: stmmac: Fix incorrect location to set real_num_rx|tx_queu
From: Aashish Verma
netif_set_real_num_tx_queues() & netif_set_real_num_rx_queues() should be
used to inform network stack about the real Tx & Rx queue (active) number
in both stmmac_open() and stmmac_resume(), therefore, we move the code
from stmmac_dvr_probe() to stmmac_hw_setup().
Fixes: c02b
From: Aashish Verma
netif_set_real_num_tx_queues() & netif_set_real_num_rx_queues() should be
used to inform network stack about the real Tx & Rx queue (active) number
in both stmmac_open() and stmmac_resume(), therefore, we move the code
from stmmac_dvr_probe() to stmmac_hw_setup().
Fixes: c02b
From: Ong Boon Leong
The current implementation of stmmac_stop_all_queues() and
stmmac_start_all_queues() will not work correctly when the value of
tx_queues_to_use is changed through ethtool -L DEVNAME rx N tx M command.
Also, netif_tx_start|stop_all_queues() are only needed in driver open()
an
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of David Miller
> Sent: Friday, April 24, 2020 6:53 AM
> To: Wong, Vee Khee
> Cc: peppe.cavall...@st.com; alexandre.tor...@st.com;
> joab...@synopsys.com; mcoquelin.st...@gmail.com;
> netdev@v
52 matches
Mail list logo
