Re: tcan4x5x on a Raspberry Pi

Hello Konstantin, m 09.08.19 um 18:46 schrieb FIXED-TERM Buecheler Konstantin (ETAS-SEC/ECT-Mu): > >> Konstantin > >>> On 7/29/19 6:19 AM, FIXED-TERM Buecheler Konstantin (ETAS-SEC/ECT-Mu) wrote: >>> Hi all, >>> >>> I am currently working on a project where I am trying to use the tcan4550 >>> c

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

Am 08.03.19 um 18:52 schrieb Dan Murphy: > On 3/8/19 11:40 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> Am 08.03.19 um 18:25 schrieb Dan Murphy: >>> On 3/8/19 11:08 AM, Wolfgang Grandegger wrote: >>>> Hello, >>>> >>>> Am 0

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

Hello Dan, Am 08.03.19 um 18:25 schrieb Dan Murphy: > On 3/8/19 11:08 AM, Wolfgang Grandegger wrote: >> Hello, >> >> Am 08.03.19 um 16:48 schrieb Dan Murphy: >>> Wolfgang >>> >>> On 3/8/19 8:41 AM, Wolfgang Grandegger wrote: >>>>

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

Hello, Am 08.03.19 um 16:48 schrieb Dan Murphy: > Wolfgang > > On 3/8/19 8:41 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> thinking more about it... >> >> Am 08.03.19 um 14:29 schrieb Wolfgang Grandegger: >>> Hello Dan, >>> &

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

Hello Dan, thinking more about it... Am 08.03.19 um 14:29 schrieb Wolfgang Grandegger: > Hello Dan, > > Am 08.03.19 um 13:44 schrieb Dan Murphy: >> Wolfgang >> >> On 3/8/19 4:10 AM, Wolfgang Grandegger wrote: >>> Hallo Dan, >>> >>> Am 05.

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

Hello Dan, Am 08.03.19 um 13:44 schrieb Dan Murphy: > Wolfgang > > On 3/8/19 4:10 AM, Wolfgang Grandegger wrote: >> Hallo Dan, >> >> Am 05.03.19 um 16:52 schrieb Dan Murphy: >>> Create a m_can platform framework that peripherial >>> devices can regi

Re: [PATCH v7 2/4] can: m_can: Rename m_can_priv to m_can_classdev

Am 05.03.19 um 16:52 schrieb Dan Murphy: > Rename the common m_can_priv class structure to > m_can_classdev as this is more descriptive. > > Signed-off-by: Dan Murphy > --- > > v7 - Fixed remaining checkpatch issues, renamed priv to cdev - > https://lore.kernel.org/patchwork/patch/1047219/ >

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

Hallo Dan, Am 05.03.19 um 16:52 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial devices may provide read/write and configuration > support of the IP. > > Signed-off-by: Dan Murphy > --- >

Re: [PATCH v6 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel

Hello Dan, Am 04.03.19 um 20:07 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 12:29 PM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> Am 01.03.19 um 19:50 schrieb Dan Murphy: >>> Add the TCAN4x5x SPI CAN driver. This device uses the >>> Bosc

Re: [PATCH v6 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel

Hello Dan, Am 01.03.19 um 19:50 schrieb Dan Murphy: > Add the TCAN4x5x SPI CAN driver. This device uses the > Bosch MCAN IP core along with a SPI interface map. > Register to the MCAN common core code to manage the MCAN IP. > > This device has a special method to indicate a write/read > operatio

Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

Am 04.03.19 um 19:14 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 11:31 AM, Wolfgang Grandegger wrote: >> Hello, >> >> there are still "LTL" after renaming m_can_priv to m_can_classdev. >> > > Yes I know but some of those become unreadable

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

Am 04.03.19 um 18:22 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 10:56 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> the series already looks quite good. I still realized a few (minor) >> issues while browsing the patch/code... >> > >

Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

Hello, there are still "LTL" after renaming m_can_priv to m_can_classdev. Am 01.03.19 um 19:50 schrieb Dan Murphy: > Rename the common m_can_priv class structure to > m_can_classdev as this is more descriptive. If you change the struct name, I think you should also change the variable name to so

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

Hello Dan, the series already looks quite good. I still realized a few (minor) issues while browsing the patch/code... Am 01.03.19 um 19:50 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial d

Re: [PATCH v5 1/5] can: m_can: Create a m_can platform framework

Am 14.02.19 um 19:27 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial devices may provide read/write and configuration> support of > the IP. > > Signed-off-by: Dan Murphy > --- > > v5 -

Re: [PATCH v5 5/5] can: tcan4x5x: Add tcan4x5x driver to the kernel

Am 28.02.19 um 19:03 schrieb Dan Murphy: > > Wolfgang > > On 2/28/19 11:50 AM, Wolfgang Grandegger wrote: >> >> >> Am 14.02.19 um 19:27 schrieb Dan Murphy: >>> Add the TCAN4x5x SPI CAN driver. This device >>> uses the Bosch MCAN IP core along

Re: [PATCH v5 2/5] can: m_can: Migrate the m_can code to use the framework

Hello Dan, Am 28.02.19 um 18:57 schrieb Dan Murphy: > Wolfgang > > On 2/28/19 11:33 AM, Wolfgang Grandegger wrote: >> Am 14.02.19 um 19:27 schrieb Dan Murphy: >>> Migrate the m_can code to use the m_can_platform framework >>> code. >>> >>> Sign

Re: [PATCH v5 5/5] can: tcan4x5x: Add tcan4x5x driver to the kernel

Am 14.02.19 um 19:27 schrieb Dan Murphy: > Add the TCAN4x5x SPI CAN driver. This device > uses the Bosch MCAN IP core along with a SPI > interface map. Leverage the MCAN common core > code to manage the MCAN IP. > > This device has a special method to indicate a > write/read operation on the

Re: [PATCH v5 2/5] can: m_can: Migrate the m_can code to use the framework

Am 14.02.19 um 19:27 schrieb Dan Murphy: > Migrate the m_can code to use the m_can_platform framework > code. > > Signed-off-by: Dan Murphy > --- > > v5 - Updated copyright, change m_can_classdev to m_can_priv, removed extra > KCONFIG flag - https://lore.kernel.org/patchwork/patch/1033095/ > >

Re: [PATCH v5 0/5] M_CAN Framework re-write

Hello, Am 14.02.19 um 19:27 schrieb Dan Murphy: > Hello > > OK I did not give up on this patch series just got a little preoccupied with > some other kernel work. But here is the update per the comments. > > It should be understood I broke these out for reviewability. > For instance the first p

Re: [PATCH v5 0/5] M_CAN Framework re-write

Hello Dan, Am 22.02.19 um 18:05 schrieb Dan Murphy: > Wolfgang > > On 2/22/19 6:50 AM, Dan Murphy wrote: >> Wolfgang >> >> On 2/22/19 3:38 AM, Wolfgang Grandegger wrote: >>> Hello Dan, >>> >>> what kernel version is that patch series for. I h

Re: [PATCH v5 0/5] M_CAN Framework re-write

Hello Dan, what kernel version is that patch series for. I have problems to apply it! Wolfgang. Am 21.02.19 um 17:41 schrieb Wolfgang Grandegger: > Hello Dan, > > I will have a closer look end of this week! > > Wolfgang. > > Am 21.02.19 um 17:24 schrieb Dan Murphy: >

Re: [PATCH v5 0/5] M_CAN Framework re-write

Hello Dan, I will have a closer look end of this week! Wolfgang. Am 21.02.19 um 17:24 schrieb Dan Murphy: > Bump > > On 2/14/19 12:27 PM, Dan Murphy wrote: >> Hello >> >> OK I did not give up on this patch series just got a little preoccupied with >> some other kernel work. But here is the upd

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

Hello Dan, Am 22.01.19 um 14:04 schrieb Dan Murphy: > Wolfgang > > Thanks for the review > > On 1/22/19 2:16 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> looks already quite good... >> >> Am 17.01.19 um 21:05 schrieb Dan Murphy: >>&

Re: [PATCH v4 2/4] can: m_can: Migrate the m_can code to use the framework

Hello Dan, Am 22.01.19 um 14:37 schrieb Dan Murphy: > Wolfgang > > On 1/22/19 3:35 AM, Wolfgang Grandegger wrote: >> Hello, >> >> Am 17.01.19 um 21:05 schrieb Dan Murphy: >>> Migrate the m_can code to use the m_can_platform framework >>

Re: [PATCH v4 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel

Hello, Am 17.01.19 um 21:06 schrieb Dan Murphy: > Add the TCAN4x5x SPI CAN driver. This device > uses the Bosch MCAN IP core along with a SPI > interface map. Leverage the MCAN common core > code to manage the MCAN IP. > > This device has a special method to indicate a > write/read operation on

Re: [PATCH v4 2/4] can: m_can: Migrate the m_can code to use the framework

Hello, Am 17.01.19 um 21:05 schrieb Dan Murphy: > Migrate the m_can code to use the m_can_platform framework > code. > > Signed-off-by: Dan Murphy > --- > drivers/net/can/m_can/Kconfig | 12 + > drivers/net/can/m_can/Makefile | 4 +- > drivers/net/can/m_can/m_can.c

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

Hello Dan, looks already quite good... Am 17.01.19 um 21:05 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial devices may provide read/write and configuration > support of the IP. > > Signed

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

Hello Dan, Am 17.01.19 um 21:08 schrieb Dan Murphy: > Wolfgang > > On 1/17/19 2:05 PM, Dan Murphy wrote: >> Create a m_can platform framework that peripherial >> devices can register to and use common code and register sets. >> The peripherial devices may provide read/write and configuration >> s

Re: [RFC PATCH 1/3] can: m_can: Create m_can core to leverage common code

Hello Dan, Am 10.01.19 um 13:53 schrieb Dan Murphy: > Wolfgang > > On 1/10/19 1:44 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> sorry for my late response on that topic... >> >> Am 09.01.19 um 21:58 schrieb Dan Murphy: >>> Wolfgang >&

Re: [RFC PATCH 1/3] can: m_can: Create m_can core to leverage common code

Hello Dan, sorry for my late response on that topic... Am 09.01.19 um 21:58 schrieb Dan Murphy: > Wolfgang > > On 11/3/18 5:45 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> Am 31.10.2018 um 21:15 schrieb Dan Murphy: >>> Wolfgang >>> >>>

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 20.03.2017 um 16:14 schrieb Akshay Bhat: Hi Wolfgang, On 03/19/2017 12:17 PM, Wolfgang Grandegger wrote: Hello Akshay, I still see some improvements... Am 17.03.2017 um 22:10 schrieb Akshay Bhat: This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

interfaces with the host over SPI. Datasheet: www.holtic.com/documents/371-hi-3110_v-rev-jpdf.do Signed-off-by: Akshay Bhat --- v3 -> v4: Address comments from Wolfgang Grandegger: - Add support for CAN warning state reporting - Add support for reporting tx/rx error counts in bus error messa

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 17.03.2017 um 19:28 schrieb Akshay Bhat: Hi Wolfgang, On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: Hm, that's unusual. Cable disconnected and then send a message: $ grep /proc/interrupts; sleep 10; /proc/interrupts should make things clear. But maybe it'

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Akshay, Am 17.03.2017 um 17:00 schrieb Akshay Bhat: Hi Wolfgang, On 03/17/2017 03:39 AM, Wolfgang Grandegger wrote: Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 17.03.2017 um 08:39 schrieb Wolfgang Grandegger: Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for state changes to error warning and passive. Just the

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for state changes to error warning and passive. Just the following message is not correct: (000.200824) can0 2004 [8

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 16.03.2017 um 18:06 schrieb Akshay Bhat: > Hi Wolfgang, > > On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: >> Hello Akshay, >> > ..snip.. >>> >>> So here is my plan: >>> - Have the bus error interrupt always enabled &g

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip /disconnect cable can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME protocol-violation{{}{acknowledge-slot}} bus

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip /disconnect cable can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME protocol-violation{{}{acknowledge-slot}} bus

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Am 14.03.2017 um 19:08 schrieb Wolfgang Grandegger: Hello Akshay, Am 14.03.2017 um 17:20 schrieb Akshay Bhat: Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: ... snip ... A few other things to check: Run "cangen" and monitor the message with "candump -e a

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 14.03.2017 um 17:20 schrieb Akshay Bhat: Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: ... snip ... A few other things to check: Run "cangen" and monitor the message with "candump -e any,0:0,#FFF". Then 1) disconnect the cable or

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hallo Akshay, Am 13.03.2017 um 16:38 schrieb Akshay Bhat: Hi Wolfgang, On 03/09/2017 12:36 PM, Wolfgang Grandegger wrote: Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat: ... snip ... A few other things to check: Run "cangen

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat: This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN controller is capable of transmitting and receiving standard data frames, extended data frames and remote frames. The

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 09.03.2017 um 13:34 schrieb Akshay Bhat: On 03/09/2017 04:59 AM, Wolfgang Grandegger wrote: Hello Akshay, unfortunately there are not many CAN controllers for the SPI bus. I just know the MPC251x, which behaves badly (message losses) under Linux, especially at hight bit

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, unfortunately there are not many CAN controllers for the SPI bus. I just know the MPC251x, which behaves badly (message losses) under Linux, especially at hight bit-rates due to insufficient RX buffering. What is your experience with that driver for the HI-311x? Thanks, Wolfga

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

Am 09.08.2016 um 08:10 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 04:35:34PM +0200, Wolfgang Grandegger wrote: Am 08.08.2016 um 16:05 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: ---snip--- + + ndev = alloc_candev(sizeof(struct

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

Am 08.08.2016 um 16:05 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: Hello, Am 08.08.2016 um 13:39 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: Hello Andreas, a first quick review Am

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

Hello, Am 08.08.2016 um 13:39 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: Hello Andreas, a first quick review Am 26.07.2016 um 11:16 schrieb Andreas Werner: This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

Hello Andreas, a first quick review Am 26.07.2016 um 11:16 schrieb Andreas Werner: This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports the CAN2.0 specification. There are 255 RX and 255 Tx buffer within the IP. The pointer for the buffer are handled by HW to mak