Re: [PATCH] net: take care of bonding in build_skb_flow_key (v4)

2016-01-21 Thread Wengang Wang
akes the master become the target device that ip_rt_update_pmtu tries to update PMTU to. Signed-off-by: Wengang Wang --- net/ipv4/route.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 85f184e..7e766b5 100644 --- a/net/ipv4/route.c +++ b/

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v4)

2016-01-21 Thread Wengang Wang
ets doesn't change so all later fragments/packets are dropped too. The fix is letting build_skb_flow_key() take care of the transition of device index from bonding slave to the master. That makes the master become the target device that ip_rt_update_pmtu tries to update PMTU to. Signed-off-by: Weng

[PATCH] net: take care of bonding in build_skb_flow_key (v4)

2016-01-20 Thread Wengang Wang
care of the transition of device index from bonding slave to the master. That makes the master become the target device that ip_rt_update_pmtu tries to update PMTU to. Signed-off-by: Wengang Wang --- net/ipv4/route.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/ipv4/route

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

2016-01-20 Thread Wengang Wang
在 2016年01月21日 12:05, Jay Vosburgh 写道: Wengang Wang wrote: [...] For ipip, yes seems update_pmtu is called in line for each call of queue_xmit. Do you know if it's a good configuration for ipip + bonding? Yes, it is. Other's comment and suggestion? I agree wi

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

2016-01-20 Thread Wengang Wang
在 2016年01月20日 23:18, Sabrina Dubroca 写道: 2016-01-20, 13:32:13 +0800, Wengang Wang wrote: In a bonding setting, we determines fragment size according to MTU and PMTU associated to the bonding master. If the slave finds the fragment size is too big, it drops the fragment and calls

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

2016-01-20 Thread Wengang Wang
在 2016年01月20日 17:56, zhuyj 写道: On 01/20/2016 05:47 PM, Wengang Wang wrote: 在 2016年01月20日 15:54, zhuyj 写道: On 01/20/2016 03:38 PM, Wengang Wang wrote: 在 2016年01月20日 14:24, zhuyj 写道: On 01/20/2016 01:32 PM, Wengang Wang wrote: In a bonding setting, we determines fragment size according

Re: [PATCH] net: take care of bonding in build_skb_flow_key

2016-01-06 Thread Wengang Wang
Please see if the V2 is clear. thanks, wengang 在 2016年01月06日 16:18, zhuyj 写道: On 01/06/2016 04:14 PM, Wengang Wang wrote: 在 2016年01月06日 16:00, zhuyj 写道: On 01/06/2016 03:45 PM, Wengang Wang wrote: 在 2016年01月06日 15:35, zhuyj 写道: IMHO, "The path MTU is set to the active slave device

[PATCH] net: take care of bonding in build_skb_flow_key (v2)

2016-01-06 Thread Wengang Wang
care of the transition of device index from bonding slave to the master. That makes the master become the target device that ip_rt_update_pmtu tries to update PMTU to. Signed-off-by: Wengang Wang --- net/ipv4/route.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH] net: take care of bonding in build_skb_flow_key

2016-01-06 Thread Wengang Wang
在 2016年01月06日 16:00, zhuyj 写道: On 01/06/2016 03:45 PM, Wengang Wang wrote: 在 2016年01月06日 15:35, zhuyj 写道: IMHO, "The path MTU is set to the active slave device, not the bonding master." Can we set PMTU to bonding master when path MTU is set to the active slave device? Actually

Re: [PATCH] net: take care of bonding in build_skb_flow_key

2016-01-05 Thread Wengang Wang
MTU to the active slave failed(it didn't found a route on slave). So "set PMTU to bonding master when path MTU is set to the active slave device" is lacking a base. thanks, wengang If not appropriate, you can ignore it. Best Regards! Zhu Yanjun On 01/06/2016 03:06 PM, Wenga

Re: [PATCH] net: take care of bonding in build_skb_flow_key

2016-01-05 Thread Wengang Wang
ave's change_mtu * function for the duration of their * servitude. */ break; Best Regards! Zhu Yanjun On 01/06/2016 02:32 PM, Wengang Wang wrote: 在 2016年01月06日 14:18, David Miller 写道: From: Wengang Wang Date: Wed, 6 Jan 201

Re: [PATCH] net: take care of bonding in build_skb_flow_key

2016-01-05 Thread Wengang Wang
e the same with the master. bonding master's mtu is changed to path MTU, then slave dev's MTU should be changed, too. Zhu Yanjun On 01/06/2016 01:49 PM, Wengang Wang wrote: A problem is found that we are looking for route basing a bonding device and deal with path MTU there: The path

Re: [PATCH] net: take care of bonding in build_skb_flow_key

2016-01-05 Thread Wengang Wang
在 2016年01月06日 14:18, David Miller 写道: From: Wengang Wang Date: Wed, 6 Jan 2016 13:49:28 +0800 @@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4 *fl4, const struct sk_buff *skb, const struct sock *sk) { const struct iphdr *iph

[PATCH] net: take care of bonding in build_skb_flow_key

2016-01-05 Thread Wengang Wang
slave to the master. Signed-off-by: Wengang Wang --- net/ipv4/route.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 85f184e..3053f10 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -523,11 +523,20 @@ static void

Re: [PATCH] ip: find correct route for socket which is not bound (v2)

2015-10-07 Thread Wengang Wang
Hi, Any comment on this patch? thanks, wengang 在 2015年09月25日 09:52, Wengang Wang 写道: This is the v2, comparing the v1, the changes is: * for loopback outbound device, it continue skipping cached route; for others, it goes through the cached route. For multicast, we should find valid

[PATCH] ip: find correct route for socket which is not bound (v2)

2015-09-24 Thread Wengang Wang
ust set). But actually the second and later multicast packets got dropped too. And the reason is that the neighor looking up(fib_lookup) is skipped because of the socket is not bound to device(sk_bound_dev_if being 0). After applied the patch I proposed here, it works fine. Signed-off-by: Wengang W

Re: [PATCH] ip: find correct route for socket which is not bound (v2)

2015-09-24 Thread Wengang Wang
Hi David, 在 2015年09月25日 05:22, David Miller 写道: From: Wengang Wang Date: Mon, 21 Sep 2015 16:00:09 +0800 This is the v2, comparing the v1, the changes is: * for loopback outbound device, it continue skipping cached route; for others, it goes through the cached route. There are many

[PATCH] ip: find correct route for socket which is not bound (v2)

2015-09-21 Thread Wengang Wang
e pmtu I just set). But actually the second and later multi-cast packages got dropped too. And the reason is that the neighor looking up(fib_lookup) is skipped because of the socket is not bound to device(sk_bound_dev_if being 0). After applied the patch I proposed here, it works fine. Signed-of

Re: [PATCH] ip: find correct route for socket which is not bound to a device

2015-09-20 Thread Wengang Wang
Hi David, Thanks for your review on this. 在 2015年09月18日 12:20, David Miller 写道: From: Wengang Wang Date: Wed, 16 Sep 2015 14:34:15 +0800 For multi-cast, we should find valid route(thus get the meaniful pmtu) for the package on the socket which is not bound to a device(sk_bound_dev_if being

[PATCH] ip: find correct route for socket which is not bound to a device

2015-09-15 Thread Wengang Wang
of the socket is not bound to device(sk_bound_dev_if being 0). After applied the patch I proposed here, it works fine. Signed-off-by: Wengang Wang --- net/ipv4/route.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 5f4a556..032481a